[Safari] ...Search bookmarks not working

[ksandvik]

Extension

https://www.raycast.com/loris/safari

Raycast Version

1.92.0

macOS Version

15.3.1

Description

Error:

Error: maxObjectCount exceeded

y1.parseBuffer:bplistParser.js:92:10

---
89:   }
90: 
91:   if (numObjects > exports.maxObjectCount) {
92:     throw new Error("maxObjectCount exceeded");
93:   }
94: 
95:   // Handle offset table
---

iv:search-bookmarks.js:157710:24580
search-bookmarks.js:157710:25123
FSReqCallback.readFileAfterClose:context:68:3

Steps To Reproduce

Open search bookmarks

Current Behaviour

Nothing happens

Expected Behaviour

Show initial browser before starting to look at entries, but the errror above shows the issue with max object count exceeeded, some of us have a lot of bookmarks... And this works inside Safari.

[raycastbot]

Thank you for opening this issue!

🔔 @loris @thomaspaulmann @SKaplanOfficial @axsuul @iwex @xilopaint @ChangeHow @ridemountainpig @1weiho you might want to have a look.

💡 Author and Contributors commands

The author and contributors of loris/safari can trigger bot actions by commenting:

• @raycastbot close this issue Closes the issue.
• @raycastbot close as not planned Closes the issue as not planned.
• @raycastbot rename this issue to "Awesome new title" Renames the issue.
• @raycastbot reopen this issue Reopens the issue.
• @raycastbot assign me Assigns yourself to the issue.
• @raycastbot good first issue Adds the "Good first issue" label to the issue.
• @raycastbot keep this issue open Make sure the issue won't go stale and will be kept open by the bot.

[axsuul]

@raycastbot remove from list

[ChangeHow]

Can you provide more info about this crash? More detailed logs or screen recording would be better. It seems we need add pagination for searching bookmarks but my bookmarks can't reach the maximum(You might provide the count of bookmarks you have?)

[ksandvik]

I would think that the Javascript log gives enough clues that a certain limit is exceeded:

  if (numObjects > exports.maxObjectCount) {
92:     throw new Error("maxObjectCount exceeded");
93:   }

but hey here are the screenshots.

[ksandvik]

Or if nothing else provide us with a setting to increase the maxObject count (in case it's a static global value) to go around this bug.

[ChangeHow]

I would think that the Javascript log gives enough clues that a certain limit is exceeded:

  if (numObjects > exports.maxObjectCount) {
92:     throw new Error("maxObjectCount exceeded");
93:   }

but hey here are the screenshots.

Sure, this log shows a lot. but I can't reproduce this case so I can determine if I solve this issue in a right way.

If you know how to install an extension locally, I would fix it locally and send you a fixed version to you.

Once this version can neither reproduce this issue anymore nor cause other issue, I would create a PR for it.

[ChangeHow]

@raycastbot assign me

[iwex]

@ChangeHow
duplicates
#14384
#13833

it's limitation of https://github.com/joeferner/node-bplist-parser

[ChangeHow]

@ChangeHow duplicates #14384 #13833

it's limitation of https://github.com/joeferner/node-bplist-parser

thank you! I just found the source code in bplist-parser.

Is it possible to cut plist file into some smaller pieces to make it work?

[ksandvik]

Yes, send me the fixed version and I install it here for testing.

[ChangeHow]

Yes, send me the fixed version and I install it here for testing.

I've tried parsing large plist file by go-wasm(with the expectation of getting a higher performance and unlocking the limitation), but it causes some issue like the output not equal to the origin way. There are some bugs need to be resolved, I'll try this weekend(Earlier in Feb. 28).

I'm stuck in generating a large plist file that matches the format of the Safari bookmarks plist file and cause the extension to fail. It would be great if you can send me([email protected]) a test file(I mean your plist file) let me test in my computer. Never mind, I only use them for testing and deleted them once the extension works. 😄

[ksandvik]

Sorry my plist (bookmark file) is full of company internal links and I'm not allowed to share such info. You could synthesize big plists with small variations (use Claude or a similar tool to do it for you).

[ChangeHow]

Sorry my plist (bookmark file) is full of company internal links and I'm not allowed to share such info. You could synthesize big plists with small variations (use Claude or a similar tool to do it for you).

No problem, I'll try this weekend

[ChangeHow]

@ksandvik Hi, I just opened a PR(#17494) and try to solve this issue, but there still some issue I can't fixed. We can follow the update in such PR later.