Review formating

raysan5 · raysan5 · commit 6b220f279883 · 2024-12-12T12:13:17.000+01:00
diff --git a/src/platforms/rcore_android.c b/src/platforms/rcore_android.c
@@ -699,7 +699,7 @@ void PollInputEvents(void)
 
     // Poll Events (registered events) until we reach TIMEOUT which indicates there are no events left to poll
     // NOTE: Activity is paused if not enabled (platform.appEnabled)
-    while ((pollResult = ALooper_pollOnce(platform.appEnabled? 0 : -1, NULL, &pollEvents, (void**)&platform.source)) > ALOOPER_POLL_TIMEOUT)
+    while ((pollResult = ALooper_pollOnce(platform.appEnabled? 0 : -1, NULL, &pollEvents, ((void **)&platform.source)) > ALOOPER_POLL_TIMEOUT))
     {
         // Process this event
         if (platform.source != NULL) platform.source->process(platform.app, platform.source);
@@ -786,7 +786,7 @@ int InitPlatform(void)
     while (!CORE.Window.ready)
     {
         // Process events until we reach TIMEOUT, which indicates no more events queued.
-        while ((pollResult = ALooper_pollOnce(0, NULL, &pollEvents, (void**)&platform.source)) > ALOOPER_POLL_TIMEOUT)
+        while ((pollResult = ALooper_pollOnce(0, NULL, &pollEvents, ((void **)&platform.source)) > ALOOPER_POLL_TIMEOUT))
         {
             // Process this event
             if (platform.source != NULL) platform.source->process(platform.app, platform.source);
@@ -1226,7 +1226,7 @@ static int32_t AndroidInputCallback(struct android_app *app, AInputEvent *event)
             return 1; // Handled gamepad button
         }
 
-        KeyboardKey key = (keycode > 0 && keycode < KEYCODE_MAP_SIZE)? mapKeycode[keycode] : KEY_NULL;
+        KeyboardKey key = ((keycode > 0) && (keycode < KEYCODE_MAP_SIZE))? mapKeycode[keycode] : KEY_NULL;
         if (key != KEY_NULL)
         {
             // Save current key and its state
diff --git a/src/platforms/rcore_desktop_rgfw.c b/src/platforms/rcore_desktop_rgfw.c
@@ -485,7 +485,7 @@ void SetWindowIcons(Image *images, int count)
 // Set title for window
 void SetWindowTitle(const char *title)
 {
-    RGFW_window_setName(platform.window, (char*)title);
+    RGFW_window_setName(platform.window, (char *)title);
     CORE.Window.title = title;
 }
 
@@ -542,9 +542,9 @@ void SetWindowFocused(void)
 void *GetWindowHandle(void)
 {
 #ifdef RGFW_WEBASM
-    return (void*)platform.window->src.ctx;
+    return (void *)platform.window->src.ctx;
 #else
-    return (void*)platform.window->src.window;
+    return (void *)platform.window->src.window;
 #endif
 }
 
@@ -587,7 +587,7 @@ Vector2 GetMonitorPosition(int monitor)
 {
     RGFW_monitor *mons = RGFW_getMonitors();
 
-    return (Vector2){(float)mons[monitor].rect.x, (float)mons[monitor].rect.y};
+    return (Vector2){ (float)mons[monitor].rect.x, (float)mons[monitor].rect.y };
 }
 
 // Get selected monitor width (currently used by monitor)
@@ -609,7 +609,7 @@ int GetMonitorHeight(int monitor)
 // Get selected monitor physical width in millimetres
 int GetMonitorPhysicalWidth(int monitor)
 {
-    RGFW_monitor* mons = RGFW_getMonitors();
+    RGFW_monitor *mons = RGFW_getMonitors();
 
     return (int)mons[monitor].physW;
 }
@@ -654,7 +654,7 @@ Vector2 GetWindowScaleDPI(void)
 // Set clipboard text content
 void SetClipboardText(const char *text)
 {
-    RGFW_writeClipboard(text, (u32)strlen(text));
+    RGFW_writeClipboard(text, strlen(text));
 }
 
 // Get clipboard text content
@@ -1336,7 +1336,7 @@ int InitPlatform(void)
     // Load OpenGL extensions
     // NOTE: GL procedures address loader is required to load extensions
     //----------------------------------------------------------------------------
-    rlLoadExtensions((void*)RGFW_getProcAddress);
+    rlLoadExtensions((void *)RGFW_getProcAddress);
     //----------------------------------------------------------------------------
 
     // TODO: Initialize input events system
diff --git a/src/platforms/rcore_desktop_sdl.c b/src/platforms/rcore_desktop_sdl.c
@@ -68,7 +68,7 @@
     #define MAX_CLIPBOARD_BUFFER_LENGTH 1024 // Size of the clipboard buffer used on GetClipboardText()
 #endif
 
-#if ((defined(SDL_MAJOR_VERSION) && SDL_MAJOR_VERSION == 3) && (defined(SDL_MINOR_VERSION) && SDL_MINOR_VERSION >= 1))
+#if ((defined(SDL_MAJOR_VERSION) && (SDL_MAJOR_VERSION == 3)) && (defined(SDL_MINOR_VERSION) && (SDL_MINOR_VERSION >= 1)))
     #ifndef PLATFORM_DESKTOP_SDL3
         #define PLATFORM_DESKTOP_SDL3
     #endif
@@ -405,7 +405,7 @@ int SDL_GetNumTouchFingers(SDL_TouchID touchID)
 
 // Since SDL2 doesn't have this function we leave a stub
 // SDL_GetClipboardData function is available since SDL 3.1.3. (e.g. SDL3)
-void* SDL_GetClipboardData(const char *mime_type, size_t *size)
+void *SDL_GetClipboardData(const char *mime_type, size_t *size)
 {
     TRACELOG(LOG_WARNING, "Getting clipboard data that is not text is only available in SDL3");
 
@@ -1971,7 +1971,7 @@ void ClosePlatform(void)
 // Scancode to keycode mapping
 static KeyboardKey ConvertScancodeToKey(SDL_Scancode sdlScancode)
 {
-    if (sdlScancode >= 0 && sdlScancode < SCANCODE_MAPPED_NUM)
+    if ((sdlScancode >= 0) && (sdlScancode < SCANCODE_MAPPED_NUM))
     {
         return mapScancodeToKey[sdlScancode];
     }
diff --git a/src/platforms/rcore_drm.c b/src/platforms/rcore_drm.c
@@ -1529,7 +1529,7 @@ static void ConfigureEvdevDevice(char *device)
             platform.absRange.height = absinfo[ABS_Y].info.maximum - absinfo[ABS_Y].info.minimum;
         }
     }
-    else if (isGamepad && !isMouse && !isKeyboard && platform.gamepadCount < MAX_GAMEPADS)
+    else if (isGamepad && !isMouse && !isKeyboard && (platform.gamepadCount < MAX_GAMEPADS))
     {
         deviceKindStr = "gamepad";
         int index = platform.gamepadCount++;
@@ -1893,7 +1893,7 @@ static int FindExactConnectorMode(const drmModeConnector *connector, uint width,
 
         TRACELOG(LOG_TRACE, "DISPLAY: DRM Mode %d %ux%u@%u %s", i, mode->hdisplay, mode->vdisplay, mode->vrefresh, (mode->flags & DRM_MODE_FLAG_INTERLACE)? "interlaced" : "progressive");
 
-        if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && (!allowInterlaced)) continue;
+        if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && !allowInterlaced) continue;
 
         if ((mode->hdisplay == width) && (mode->vdisplay == height) && (mode->vrefresh == fps)) return i;
     }
@@ -1923,7 +1923,7 @@ static int FindNearestConnectorMode(const drmModeConnector *connector, uint widt
             continue;
         }
 
-        if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && (!allowInterlaced))
+        if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && !allowInterlaced)
         {
             TRACELOG(LOG_TRACE, "DISPLAY: DRM shouldn't choose an interlaced mode");
             continue;
diff --git a/src/platforms/rcore_web.c b/src/platforms/rcore_web.c
@@ -319,7 +319,7 @@ void ToggleBorderlessWindowed(void)
 // Set window state: maximized, if resizable
 void MaximizeWindow(void)
 {
-    if (glfwGetWindowAttrib(platform.handle, GLFW_RESIZABLE) == GLFW_TRUE && !(CORE.Window.flags & FLAG_WINDOW_MAXIMIZED))
+    if ((glfwGetWindowAttrib(platform.handle, GLFW_RESIZABLE) == GLFW_TRUE) && !(CORE.Window.flags & FLAG_WINDOW_MAXIMIZED))
     {
         platform.unmaximizedWidth = CORE.Window.screen.width;
         platform.unmaximizedHeight = CORE.Window.screen.height;
@@ -342,7 +342,7 @@ void MinimizeWindow(void)
 // Set window state: not minimized/maximized
 void RestoreWindow(void)
 {
-    if (glfwGetWindowAttrib(platform.handle, GLFW_RESIZABLE) == GLFW_TRUE && (CORE.Window.flags & FLAG_WINDOW_MAXIMIZED))
+    if ((glfwGetWindowAttrib(platform.handle, GLFW_RESIZABLE) == GLFW_TRUE) && (CORE.Window.flags & FLAG_WINDOW_MAXIMIZED))
     {
         if (platform.unmaximizedWidth && platform.unmaximizedHeight) glfwSetWindowSize(platform.handle, platform.unmaximizedWidth, platform.unmaximizedHeight);
 
@@ -1664,10 +1664,10 @@ static EM_BOOL EmscriptenResizeCallback(int eventType, const EmscriptenUiEvent *
     int height = EM_ASM_INT( return window.innerHeight; );
 
     if (width < (int)CORE.Window.screenMin.width) width = CORE.Window.screenMin.width;
-    else if (width > (int)CORE.Window.screenMax.width && CORE.Window.screenMax.width > 0) width = CORE.Window.screenMax.width;
+    else if ((width > (int)CORE.Window.screenMax.width) && (CORE.Window.screenMax.width > 0)) width = CORE.Window.screenMax.width;
 
     if (height < (int)CORE.Window.screenMin.height) height = CORE.Window.screenMin.height;
-    else if (height > (int)CORE.Window.screenMax.height && CORE.Window.screenMax.height > 0) height = CORE.Window.screenMax.height;
+    else if ((height > (int)CORE.Window.screenMax.height) && (CORE.Window.screenMax.height > 0)) height = CORE.Window.screenMax.height;
 
     emscripten_set_canvas_element_size("#canvas", width, height);
 
@@ -1722,7 +1722,7 @@ static EM_BOOL EmscriptenGamepadCallback(int eventType, const EmscriptenGamepadE
     for (int i = 0; i < gamepadEvent->numButtons; ++i) TRACELOGD("Button %d: Digital: %d, Analog: %g", i, gamepadEvent->digitalButton[i], gamepadEvent->analogButton[i]);
     */
 
-    if ((gamepadEvent->connected) && (gamepadEvent->index < MAX_GAMEPADS))
+    if (gamepadEvent->connected && (gamepadEvent->index < MAX_GAMEPADS))
     {
         CORE.Input.Gamepad.ready[gamepadEvent->index] = true;
         sprintf(CORE.Input.Gamepad.name[gamepadEvent->index], "%s", gamepadEvent->id);
diff --git a/src/rcore.c b/src/rcore.c
@@ -2063,7 +2063,7 @@ const char *GetDirectoryPath(const char *filePath)
 
     // In case provided path does not contain a root drive letter (C:\, D:\) nor leading path separator (\, /),
     // we add the current directory path to dirPath
-    if (filePath[1] != ':' && filePath[0] != '\\' && filePath[0] != '/')
+    if ((filePath[1] != ':') && (filePath[0] != '\\') && (filePath[0] != '/'))
     {
         // For security, we set starting path to current directory,
         // obtained path will be concatenated to this
diff --git a/src/rtextures.c b/src/rtextures.c
@@ -833,10 +833,7 @@ Image GenImageGradientLinear(int width, int height, int direction, Color start,
     // bottom-right or vice-versa), pixel (0, 0) is the farthest point on the gradient
     // (i.e. the pixel which should become one of the gradient's ends color); while for
     // directions that lie in the second or fourth quadrant, that point is pixel (width, 0).
-    float maxPosValue =
-            ((signbit(sinDir) != 0) == (signbit(cosDir) != 0))
-            ? fabsf(startingPos)
-            : fabsf(startingPos+width*cosDir);
+    float maxPosValue = ((signbit(sinDir) != 0) == (signbit(cosDir) != 0))? fabsf(startingPos) : fabsf(startingPos + width*cosDir);
     for (int i = 0; i < width; i++)
     {
         for (int j = 0; j < height; j++)

Original file line number	Diff line number	Diff line change
`@@ -699,7 +699,7 @@ void PollInputEvents(void)`
`699`	`699`
`700`	`700`	`// Poll Events (registered events) until we reach TIMEOUT which indicates there are no events left to poll`
`701`	`701`	`// NOTE: Activity is paused if not enabled (platform.appEnabled)`
`702`		`- while ((pollResult = ALooper_pollOnce(platform.appEnabled? 0 : -1, NULL, &pollEvents, (void**)&platform.source)) > ALOOPER_POLL_TIMEOUT)`
	`702`	`+ while ((pollResult = ALooper_pollOnce(platform.appEnabled? 0 : -1, NULL, &pollEvents, ((void **)&platform.source)) > ALOOPER_POLL_TIMEOUT))`
`703`	`703`	`{`
`704`	`704`	`// Process this event`
`705`	`705`	`if (platform.source != NULL) platform.source->process(platform.app, platform.source);`
`@@ -786,7 +786,7 @@ int InitPlatform(void)`
`786`	`786`	`while (!CORE.Window.ready)`
`787`	`787`	`{`
`788`	`788`	`// Process events until we reach TIMEOUT, which indicates no more events queued.`
`789`		`- while ((pollResult = ALooper_pollOnce(0, NULL, &pollEvents, (void**)&platform.source)) > ALOOPER_POLL_TIMEOUT)`
	`789`	`+ while ((pollResult = ALooper_pollOnce(0, NULL, &pollEvents, ((void **)&platform.source)) > ALOOPER_POLL_TIMEOUT))`
`790`	`790`	`{`
`791`	`791`	`// Process this event`
`792`	`792`	`if (platform.source != NULL) platform.source->process(platform.app, platform.source);`
`@@ -1226,7 +1226,7 @@ static int32_t AndroidInputCallback(struct android_app app, AInputEvent event)`
`1226`	`1226`	`return 1; // Handled gamepad button`
`1227`	`1227`	`}`
`1228`	`1228`
`1229`		`- KeyboardKey key = (keycode > 0 && keycode < KEYCODE_MAP_SIZE)? mapKeycode[keycode] : KEY_NULL;`
	`1229`	`+ KeyboardKey key = ((keycode > 0) && (keycode < KEYCODE_MAP_SIZE))? mapKeycode[keycode] : KEY_NULL;`
`1230`	`1230`	`if (key != KEY_NULL)`
`1231`	`1231`	`{`
`1232`	`1232`	`// Save current key and its state`
Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,7 @@ void SetWindowIcons(Image *images, int count)`
`485`	`485`	`// Set title for window`
`486`	`486`	`void SetWindowTitle(const char *title)`
`487`	`487`	`{`
`488`		`- RGFW_window_setName(platform.window, (char*)title);`
	`488`	`+ RGFW_window_setName(platform.window, (char *)title);`
`489`	`489`	`CORE.Window.title = title;`
`490`	`490`	`}`
`491`	`491`
`@@ -542,9 +542,9 @@ void SetWindowFocused(void)`
`542`	`542`	`void *GetWindowHandle(void)`
`543`	`543`	`{`
`544`	`544`	`#ifdef RGFW_WEBASM`
`545`		`- return (void*)platform.window->src.ctx;`
	`545`	`+ return (void *)platform.window->src.ctx;`
`546`	`546`	`#else`
`547`		`- return (void*)platform.window->src.window;`
	`547`	`+ return (void *)platform.window->src.window;`
`548`	`548`	`#endif`
`549`	`549`	`}`
`550`	`550`
`@@ -587,7 +587,7 @@ Vector2 GetMonitorPosition(int monitor)`
`587`	`587`	`{`
`588`	`588`	`RGFW_monitor *mons = RGFW_getMonitors();`
`589`	`589`
`590`		`- return (Vector2){(float)mons[monitor].rect.x, (float)mons[monitor].rect.y};`
	`590`	`+ return (Vector2){ (float)mons[monitor].rect.x, (float)mons[monitor].rect.y };`
`591`	`591`	`}`
`592`	`592`
`593`	`593`	`// Get selected monitor width (currently used by monitor)`
`@@ -609,7 +609,7 @@ int GetMonitorHeight(int monitor)`
`609`	`609`	`// Get selected monitor physical width in millimetres`
`610`	`610`	`int GetMonitorPhysicalWidth(int monitor)`
`611`	`611`	`{`
`612`		`- RGFW_monitor* mons = RGFW_getMonitors();`
	`612`	`+ RGFW_monitor *mons = RGFW_getMonitors();`
`613`	`613`
`614`	`614`	`return (int)mons[monitor].physW;`
`615`	`615`	`}`
`@@ -654,7 +654,7 @@ Vector2 GetWindowScaleDPI(void)`
`654`	`654`	`// Set clipboard text content`
`655`	`655`	`void SetClipboardText(const char *text)`
`656`	`656`	`{`
`657`		`- RGFW_writeClipboard(text, (u32)strlen(text));`
	`657`	`+ RGFW_writeClipboard(text, strlen(text));`
`658`	`658`	`}`
`659`	`659`
`660`	`660`	`// Get clipboard text content`
`@@ -1336,7 +1336,7 @@ int InitPlatform(void)`
`1336`	`1336`	`// Load OpenGL extensions`
`1337`	`1337`	`// NOTE: GL procedures address loader is required to load extensions`
`1338`	`1338`	`//----------------------------------------------------------------------------`
`1339`		`- rlLoadExtensions((void*)RGFW_getProcAddress);`
	`1339`	`+ rlLoadExtensions((void *)RGFW_getProcAddress);`
`1340`	`1340`	`//----------------------------------------------------------------------------`
`1341`	`1341`
`1342`	`1342`	`// TODO: Initialize input events system`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@`
`68`	`68`	`#define MAX_CLIPBOARD_BUFFER_LENGTH 1024 // Size of the clipboard buffer used on GetClipboardText()`
`69`	`69`	`#endif`
`70`	`70`
`71`		`-#if ((defined(SDL_MAJOR_VERSION) && SDL_MAJOR_VERSION == 3) && (defined(SDL_MINOR_VERSION) && SDL_MINOR_VERSION >= 1))`
	`71`	`+#if ((defined(SDL_MAJOR_VERSION) && (SDL_MAJOR_VERSION == 3)) && (defined(SDL_MINOR_VERSION) && (SDL_MINOR_VERSION >= 1)))`
`72`	`72`	`#ifndef PLATFORM_DESKTOP_SDL3`
`73`	`73`	`#define PLATFORM_DESKTOP_SDL3`
`74`	`74`	`#endif`
`@@ -405,7 +405,7 @@ int SDL_GetNumTouchFingers(SDL_TouchID touchID)`
`405`	`405`
`406`	`406`	`// Since SDL2 doesn't have this function we leave a stub`
`407`	`407`	`// SDL_GetClipboardData function is available since SDL 3.1.3. (e.g. SDL3)`
`408`		`-void* SDL_GetClipboardData(const char mime_type, size_t size)`
	`408`	`+void SDL_GetClipboardData(const char mime_type, size_t *size)`
`409`	`409`	`{`
`410`	`410`	`TRACELOG(LOG_WARNING, "Getting clipboard data that is not text is only available in SDL3");`
`411`	`411`
`@@ -1971,7 +1971,7 @@ void ClosePlatform(void)`
`1971`	`1971`	`// Scancode to keycode mapping`
`1972`	`1972`	`static KeyboardKey ConvertScancodeToKey(SDL_Scancode sdlScancode)`
`1973`	`1973`	`{`
`1974`		`- if (sdlScancode >= 0 && sdlScancode < SCANCODE_MAPPED_NUM)`
	`1974`	`+ if ((sdlScancode >= 0) && (sdlScancode < SCANCODE_MAPPED_NUM))`
`1975`	`1975`	`{`
`1976`	`1976`	`return mapScancodeToKey[sdlScancode];`
`1977`	`1977`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1529,7 +1529,7 @@ static void ConfigureEvdevDevice(char *device)`
`1529`	`1529`	`platform.absRange.height = absinfo[ABS_Y].info.maximum - absinfo[ABS_Y].info.minimum;`
`1530`	`1530`	`}`
`1531`	`1531`	`}`
`1532`		`- else if (isGamepad && !isMouse && !isKeyboard && platform.gamepadCount < MAX_GAMEPADS)`
	`1532`	`+ else if (isGamepad && !isMouse && !isKeyboard && (platform.gamepadCount < MAX_GAMEPADS))`
`1533`	`1533`	`{`
`1534`	`1534`	`deviceKindStr = "gamepad";`
`1535`	`1535`	`int index = platform.gamepadCount++;`
`@@ -1893,7 +1893,7 @@ static int FindExactConnectorMode(const drmModeConnector *connector, uint width,`
`1893`	`1893`
`1894`	`1894`	`TRACELOG(LOG_TRACE, "DISPLAY: DRM Mode %d %ux%u@%u %s", i, mode->hdisplay, mode->vdisplay, mode->vrefresh, (mode->flags & DRM_MODE_FLAG_INTERLACE)? "interlaced" : "progressive");`
`1895`	`1895`
`1896`		`- if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && (!allowInterlaced)) continue;`
	`1896`	`+ if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && !allowInterlaced) continue;`
`1897`	`1897`
`1898`	`1898`	`if ((mode->hdisplay == width) && (mode->vdisplay == height) && (mode->vrefresh == fps)) return i;`
`1899`	`1899`	`}`
`@@ -1923,7 +1923,7 @@ static int FindNearestConnectorMode(const drmModeConnector *connector, uint widt`
`1923`	`1923`	`continue;`
`1924`	`1924`	`}`
`1925`	`1925`
`1926`		`- if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && (!allowInterlaced))`
	`1926`	`+ if ((mode->flags & DRM_MODE_FLAG_INTERLACE) && !allowInterlaced)`
`1927`	`1927`	`{`
`1928`	`1928`	`TRACELOG(LOG_TRACE, "DISPLAY: DRM shouldn't choose an interlaced mode");`
`1929`	`1929`	`continue;`
Original file line number	Diff line number	Diff line change
`@@ -2063,7 +2063,7 @@ const char GetDirectoryPath(const char filePath)`
`2063`	`2063`
`2064`	`2064`	`// In case provided path does not contain a root drive letter (C:\, D:\) nor leading path separator (\, /),`
`2065`	`2065`	`// we add the current directory path to dirPath`
`2066`		`- if (filePath[1] != ':' && filePath[0] != '\\' && filePath[0] != '/')`
	`2066`	`+ if ((filePath[1] != ':') && (filePath[0] != '\\') && (filePath[0] != '/'))`
`2067`	`2067`	`{`
`2068`	`2068`	`// For security, we set starting path to current directory,`
`2069`	`2069`	`// obtained path will be concatenated to this`