RANGER-3902: dbLoadTime is not added correctly in RangerServicePoliciesCache

ramackri · mneethiraj · commit d234db2590a8 · 2022-10-11T10:53:57.000-07:00
Signed-off-by: Madhan Neethiraj &lt;madhan@apache.org&gt;
diff --git a/security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java b/security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
@@ -313,10 +313,9 @@ boolean getLatest(String serviceName, ServiceStore serviceStore, Long lastKnownV
 				}
 
 				final long            startTimeMs           = System.currentTimeMillis();
+				final ServicePolicies servicePoliciesFromDb = serviceStore.getServicePolicyDeltasOrPolicies(serviceName, cachedServicePoliciesVersion);
 				final long            dbLoadTime            = System.currentTimeMillis() - startTimeMs;
 
-				ServicePolicies       servicePoliciesFromDb = serviceStore.getServicePolicyDeltasOrPolicies(serviceName, cachedServicePoliciesVersion);
-
 				if (dbLoadTime > longestDbLoadTimeInMs) {
 					longestDbLoadTimeInMs = dbLoadTime;
 				}

Original file line number	Diff line number	Diff line change
`@@ -313,10 +313,9 @@ boolean getLatest(String serviceName, ServiceStore serviceStore, Long lastKnownV`
`313`	`313`	`}`
`314`	`314`
`315`	`315`	`final long startTimeMs = System.currentTimeMillis();`
	`316`	`+ final ServicePolicies servicePoliciesFromDb = serviceStore.getServicePolicyDeltasOrPolicies(serviceName, cachedServicePoliciesVersion);`
`316`	`317`	`final long dbLoadTime = System.currentTimeMillis() - startTimeMs;`
`317`	`318`
`318`		`- ServicePolicies servicePoliciesFromDb = serviceStore.getServicePolicyDeltasOrPolicies(serviceName, cachedServicePoliciesVersion);`
`319`		`-`
`320`	`319`	`if (dbLoadTime > longestDbLoadTimeInMs) {`
`321`	`320`	`longestDbLoadTimeInMs = dbLoadTime;`
`322`	`321`	`}`