Skip to content

Commit d344a4d

Browse files
committed
[trino] Fix logging in Trino plugin
Ranger plugin access control class is injected via classloader, its logger needs to go through trino's logger. More details: facebookarchive/swift#287 (comment) Signed-off-by: Utkarsh Saxena <[email protected]>
1 parent da92e12 commit d344a4d

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

plugin-trino/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@
3737
<artifactId>trino-spi</artifactId>
3838
<version>${trino.version}</version>
3939
</dependency>
40+
<dependency>
41+
<groupId>io.airlift</groupId>
42+
<artifactId>log</artifactId>
43+
<version>${trino.airlift.version}</version>
44+
</dependency>
4045
<dependency>
4146
<groupId>io.trino</groupId>
4247
<artifactId>trino-jdbc</artifactId>

plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@
4141
import org.apache.ranger.plugin.policyengine.RangerAccessResourceImpl;
4242
import org.apache.ranger.plugin.policyengine.RangerAccessResult;
4343
import org.apache.ranger.plugin.service.RangerBasePlugin;
44-
import org.slf4j.Logger;
45-
import org.slf4j.LoggerFactory;
44+
import io.airlift.log.Logger;
4645

4746
import java.io.IOException;
4847
import java.net.URL;
@@ -62,7 +61,7 @@
6261

6362
public class RangerSystemAccessControl
6463
implements SystemAccessControl {
65-
private static Logger LOG = LoggerFactory.getLogger(RangerSystemAccessControl.class);
64+
private static final Logger LOG = Logger.get(RangerSystemAccessControl.class);
6665

6766
final public static String RANGER_CONFIG_KEYTAB = "ranger.keytab";
6867
final public static String RANGER_CONFIG_PRINCIPAL = "ranger.principal";

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@
207207
<presto.re2j.version>1.1</presto.re2j.version>
208208

209209
<!-- trino plugin deps -->
210-
<trino.airlift.version>0.192</trino.airlift.version>
210+
<trino.airlift.version>208</trino.airlift.version>
211211
<trino.bval-jsr.version>2.0.0</trino.bval-jsr.version>
212212
<trino.guice.version>4.2.2</trino.guice.version>
213213
<trino.guava.version>26.0-jre</trino.guava.version>

0 commit comments

Comments
 (0)