Skip to content

Commit e17ffa3

Browse files
committed
RANGER-3387: fix for PMD violation - #2
1 parent ee2dc9b commit e17ffa3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
187187
if (IS_CSRF_ENABLED) {
188188
final HttpServletRequest httpRequest = (HttpServletRequest)request;
189189
final HttpServletResponse httpResponse = (HttpServletResponse)response;
190-
Boolean spnegoEnabled = httpRequest.getAttribute("spnegoEnabled") != null ? Boolean.valueOf(String.valueOf(httpRequest.getAttribute("spnegoEnabled"))) : false;
191-
Boolean trustedProxyEnabled = httpRequest.getAttribute("trustedProxyEnabled") != null ? Boolean.valueOf(String.valueOf(httpRequest.getAttribute("trustedProxyEnabled"))) : false;
190+
Boolean spnegoEnabled = httpRequest.getAttribute("spnegoEnabled") != null && Boolean.valueOf(String.valueOf(httpRequest.getAttribute("spnegoEnabled")));
191+
Boolean trustedProxyEnabled = httpRequest.getAttribute("trustedProxyEnabled") != null && Boolean.valueOf(String.valueOf(httpRequest.getAttribute("trustedProxyEnabled")));
192192
handleHttpInteraction(new ServletFilterHttpInteraction(httpRequest, httpResponse, chain), spnegoEnabled, trustedProxyEnabled);
193193
}else{
194194
chain.doFilter(request, response);

0 commit comments

Comments
 (0)