Skip to content

Commit fc38927

Browse files
committed
dry up
1 parent 87532ec commit fc38927

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

configuration_setup_utility/generic_run_rb.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@echo Loading... we have splash for this too...
1+
@echo Loading... we set a splash for this purpose too...
22
@echo off
33
setlocal
44
@rem disable any other local rubyopt settings, just in case...

configuration_setup_utility/record_with_buttons.rb

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def elements
4545
}
4646

4747
def get_old_files
48-
old_files = Dir[current_storage_dir + '/*.{wav,mp4,mkv,ac3,mp3,mpg,mov}']
48+
old_files = Dir[current_storage_dir + "/*.{#{(@audio_extensions + @video_extensions).join(',')}}"]
4949
old_files.select!{|f| File.basename(f) =~ /^\d+\..../}
5050
old_files = old_files.sort_by{|f| f =~ /(\d+)\....$/; $1.to_i}
5151
old_files
@@ -166,7 +166,7 @@ def start_recording_with_current_settings just_preview = false
166166
faster_streaming_start = "-g 30 -qp 10 -tune zerolatency" # also has fixed quality...wonder what that means...
167167
end
168168
codecs = "-vcodec libx264 #{faster_streaming_start} -pix_fmt #{pixel_type} #{rescale_to_size} -preset ultrafast -vsync vfr -acodec libmp3lame"
169-
# qtrle was 10 fps, this kept up at 15 on dual core, plus is .mp4 friendly, though lossy, looked all right
169+
# qtrle was 10 fps, this kept up at 15 on dual core, plus is .mp4 friendly, though lossy, looked all right, went with x264 I guess?
170170
else
171171
prefix_to_audio_codec = {'mp3' => '-acodec libmp3lame -ac 2', 'aac' => '-acodec aac -strict experimental', 'wav' => '-acodec pcm_s16le'}
172172
audio_type = prefix_to_audio_codec[storage['current_ext_sans_dot']]
@@ -330,13 +330,16 @@ def bootstrap_devices
330330

331331
end
332332

333+
# TODO 'wav' here once it works with solely wav :)
334+
@audio_extensions = ['mp3', 'aac']
335+
@video_extensions = ['mkv', 'mp4']
336+
333337
def choose_extension
334338
if audio_devices_or_nil && !video_device
335-
# TODO 'wav' here once it works with solely wav :)
336-
storage['current_ext_sans_dot'] = DropDownSelector.new(@frame, ['mp3', 'aac'], "You are set to record only audio--Select audio Save as type").go_selected_value
339+
storage['current_ext_sans_dot'] = DropDownSelector.new(@frame, @audio_extensions, "You are set to record only audio--Select audio Save as type").go_selected_value
337340
else
338341
# at least video
339-
storage['current_ext_sans_dot'] = DropDownSelector.new(@frame, ['mkv', 'mp4'], "Select file extension container save as type, mkv is more robust to interrupted recordings").go_selected_value
342+
storage['current_ext_sans_dot'] = DropDownSelector.new(@frame, @video_extensions, "Select file extension container save as type, mkv is more robust to interrupted recordings").go_selected_value
340343
end
341344
end
342345

configuration_setup_utility/record_with_buttons_options_pane.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def show_options_frame
154154
choose_audio
155155
}
156156

157-
raise unless RUBY_VERSION > '1.9.0' # need ordered hashes here... :) plus we control the version so should be safe...
157+
raise unless RUBY_VERSION > '1.9.0' # need ordered hashes here... :) plus we control the version so this should be safe...
158158
elements[:change_resolution].on_clicked {
159159
# want to have our own names here, as requested...
160160
english_names = ResolutionOptions.map{|k, v| resolution_english_string(v)}

innosetup_installer_options.iss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#define AppVer "0.13.3.beta"
1+
#define AppVer "0.13.3.beta1"
22

33
#define AppName "Screen Capturer Recorder"
44
; AppId === AppName by default BTW

0 commit comments

Comments
 (0)