Skip to content

Commit 1cffebd

Browse files
committed
chore: adjust
1 parent aba7802 commit 1cffebd

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/hooks/useOpen.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ export default function useOpen(
8888

8989
// Since `mergedOpen` is post-processed, we need to check if the value really changed
9090
if (!weak) {
91-
weakLockRef.current = true;
91+
// Only `true` need lock
92+
weakLockRef.current = nextOpenVal;
9293
}
9394

9495
// Weak update can be ignored

tests/Select.test.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ describe('Select.Basic', () => {
603603
</Select>,
604604
);
605605

606-
keyDown(container.querySelector('input'), 40);
606+
keyDown(container.querySelector('input'), KeyCode.DOWN);
607607
expectOpen(container);
608608
});
609609

@@ -2566,9 +2566,9 @@ describe('Select.Basic', () => {
25662566
await waitFakeTimer();
25672567
expectOpen(container, true);
25682568

2569-
keyDown(inputElem!, 40);
2570-
keyUp(inputElem!, 40);
2571-
keyDown(inputElem!, 13);
2569+
keyDown(inputElem!, KeyCode.DOWN);
2570+
keyUp(inputElem!, KeyCode.DOWN);
2571+
keyDown(inputElem!, KeyCode.ENTER);
25722572

25732573
await waitFakeTimer();
25742574
expect(onBlur).toHaveBeenCalledTimes(1);
@@ -2579,9 +2579,9 @@ describe('Select.Basic', () => {
25792579
await waitFakeTimer();
25802580
expectOpen(container, true);
25812581

2582-
keyDown(inputElem!, 40);
2583-
keyUp(inputElem!, 40);
2584-
keyDown(inputElem!, 13);
2582+
keyDown(inputElem!, KeyCode.DOWN);
2583+
keyUp(inputElem!, KeyCode.DOWN);
2584+
keyDown(inputElem!, KeyCode.ENTER);
25852585

25862586
await waitFakeTimer();
25872587
expect(onBlur).toHaveBeenCalledTimes(2);

0 commit comments

Comments
 (0)