-
Notifications
You must be signed in to change notification settings - Fork 35
By default, fail fast if navigation is not found in context #37
Comments
We're throwing an error in navigation ex. I think it's more confusing for the user to give undefined instead of a proper error. |
The lint rule won't allow it, but I wonder what's wrong with having it in try catch. The order if hooks should still hold true |
Honestly I'd find it more easy to handle with |
idk, it seems to be a very specific use case. I'd rather export |
Yes that would do the job too :) don't know why I didn't think of that 👍 |
Will be fixed by #38, going to merge/release soon |
should be fixed by release 1.0.3 and #38, please tell me if everything works |
Uh oh!
There was an error while loading. Please reload this page.
Related to #33
We'd rather fail fast if context is not found and user use
useNavigation()
, with an option to allow useNavigation to return undefined, to support more advanced usecases (see the PR)The text was updated successfully, but these errors were encountered: