Skip to content

Commit a862ba7

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover devtoolsruntimesettings with Stable API guards (#58131)
Summary: Pull Request resolved: #58131 Classifies `devtoolsruntimesettings:devtoolsruntimesettings` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's single exported header (`DevToolsRuntimeSettings.h`), and wires the guard dependency into BUCK and CMake. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117328566 fbshipit-source-id: e63e8d1fb710b95ec96ce3f0227ab2f47ccbbd7a
1 parent 4f95564 commit a862ba7

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

packages/react-native/ReactCommon/devtoolsruntimesettings/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ add_library(devtoolsruntimesettings OBJECT ${devtoolsruntimesettings_SRCS})
1313

1414
target_include_directories(devtoolsruntimesettings PUBLIC .)
1515

16-
target_link_libraries(devtoolsruntimesettings jsi react_codegen_rncore)
16+
target_link_libraries(devtoolsruntimesettings jsi react_codegen_rncore react_cxxstableapi)
1717
target_compile_reactnative_options(devtoolsruntimesettings PRIVATE)

packages/react-native/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
1113

1214
namespace facebook::react {

0 commit comments

Comments
 (0)