NativeEventEmitter behaviour in new architecture

[intergalacticspacehighway]

Is something changed with NativeEventEmitter on android? Noticed that we pass null on android here.

Also, do these methods trigger on android? NetInfo uses them to set and reset some flags. These flags are used for optimisation while triggering event call from native. Thanks 🙏

[fabOnReact]

facebook/react-native#34353 (comment)
facebook/react-native#30841 (comment)

I'm also investigating these changes in the Java/CPP API which essentially add the surfaceId to the event. Is a Fabric optimisation, but does not work with onAccessibililtyAction callback on Fabric

https://github.com/facebook/react-native/blob/28e9c3b87e709dce3ffec208ff5228d07eaad512/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java#L360-L373

https://github.com/fabriziobertoglio1987/react-native/blob/b80bcb3104c903f97974d90db3827b997af9c7cc/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/EventDispatcherImpl.java#L112

https://github.com/facebook/react-native/blob/163171ccab6937785f4f3c85e011bd14540bebf5/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/ReactEventEmitter.java#L130-L140

https://github.com/fabriziobertoglio1987/react-native/blob/b80bcb3104c903f97974d90db3827b997af9c7cc/ReactCommon/react/renderer/components/view/ViewEventEmitter.cpp#L15

I'm reading this documentation now https://github.com/fabriziobertoglio1987/react-native/blob/b80bcb3104c903f97974d90db3827b997af9c7cc/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/Event.java#L60, but seems to apply to the old architecture

I quote mrousavy

RN Core they always pass null to new NativeEventEmitter(..) on Android. Only on iOS they actually pass the native module. I believe on Android the event names are shared across all event emitters, so the argument is not needed on Android.

facebook/react-native@114be1d
facebook/react-native-website#2791