Skip to content

Commit c072cdd

Browse files
authored
Tests: mock dns queries to avoid flaky tests (#11821)
1 parent ca860b8 commit c072cdd

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

readthedocs/rtd_tests/tests/test_domains.py

+9
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
from unittest import mock
2+
3+
import dns.resolver
14
from django.conf import settings
25
from django.test import TestCase, override_settings
36
from django_dynamic_fixture import get
@@ -28,6 +31,12 @@ def test_save_parsing(self):
2831
self.assertEqual(domain.domain, "www.google.com")
2932

3033

34+
# We are using random domain names to test the form validation,
35+
# so we are mocking the DNS resolver to avoid making real DNS queries.
36+
@mock.patch(
37+
"readthedocs.projects.forms.dns.resolver.resolve",
38+
new=mock.MagicMock(side_effect=dns.resolver.NoAnswer),
39+
)
3140
class FormTests(TestCase):
3241
def setUp(self):
3342
self.project = get(Project, slug="kong")

0 commit comments

Comments
 (0)