I want to open an MR for put the points props back in Line, but I am getting a 403 when pushing branch

[brodriguezmilla]

I checked out the repo, changed to the master branch, checkout -b nameOfMyBranch, made my changes, added, committed, but when git push, and I got a

remote: Permission to recharts/recharts.git denied to brodriguezmilla.
fatal: unable to access 'https://github.com/recharts/recharts.git/': The requested URL returned error: 403

What am I doing wrong? Thank you.

[ckifer]

recharts is not an open repository to push branches to, for external collaborators we use the fork and pull model. You will need to fork recharts, make you change in a branch in your fork, and then open a PR to recharts across forks

put the points props back in Line

Can you elaborate? Why? points is internal

[brodriguezmilla]

You did something similar here: https://github.com/recharts/recharts/pull/4481/files?diff=split&w=1. Points was a prop accessible through the customizible dots, and I am using that prop to build a graph. That was some versions ago, and I just updated my recharts version and the prop points is no longer there, though you just put it back 2 days ago in the 3.x branch.

[brodriguezmilla]

I wanted to do the same you did in Area, but for Line - for v2.15.1.

[ckifer]

Ok, I misunderstood then you do not mean the points prop passed to Line, but as part of what comes back from the custom dot callback.

From what I can see this looks the same as Area https://github.com/recharts/recharts/blob/3.x/src/cartesian/Line.tsx#L257

Feel free to open a backport to 2.x, but I'm not sure when the next 2.x release will be as we're prioritizing 3.x and not backporting some things