Skip to content

Commit 5482e9e

Browse files
Merge pull request #112 from GomathiselviS/integ_tests_fix
Fix test failures in deploy_flask_app and backup_select_resources roles
2 parents 7a63084 + cc253ca commit 5482e9e

File tree

8 files changed

+13
-7
lines changed

8 files changed

+13
-7
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
bugfixes:
3+
- Fix incorrect dict attribute in backup_select_resources role.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
minor_changes:
3+
- Replace the postgres db engine version from 14.8 to 16.2

playbooks/webapp/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ To delete the webapp:
126126
* **rds_instance_class** (str): DB instance class for the RDS instance. Default: `db.m6g.large`
127127
* **rds_instance_name** (str): Name for the database. Default: `mysampledb123`
128128
* **rds_engine** (str): Engine to use for the database. Default: `postgres`
129-
* **rds_engine_version** (str): Version number of the database engine to use. Default: `"14.8"`
129+
* **rds_engine_version** (str): Version number of the database engine to use. Default: `"16.2"`
130130
* **deploy_flask_app_rds_master_username** (str): Name of the master user for the database instance. Default: `ansible`
131131
* **deploy_flask_app_rds_master_password** (str): Password for the master database user. Default: `L#5cH2mgy_`
132132

playbooks/webapp/vars/main.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ rds_allocated_storage_gb: 20
2222
rds_instance_class: db.m6g.large
2323
rds_instance_name: mysampledb123
2424
rds_engine: postgres
25-
rds_engine_version: "14.8"
25+
rds_engine_version: "16.2"
2626
bastion_host_type: t3.micro
2727
bastion_host_venv_path: ~/env
2828
rds_listening_port: 5432

roles/backup_select_resources/tasks/main.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353

5454
- name: Set backup role ARN
5555
ansible.builtin.set_fact:
56-
backup_select_resources_backup_role_arn: "{{ backup_select_resources_role_info.iam_roles[0].arn if backup_select_resources_new_role_info is skipped else backup_select_resources_new_role_info.arn }}"
56+
backup_select_resources_backup_role_arn: "{{ backup_select_resources_role_info.iam_roles[0].arn if backup_select_resources_new_role_info is skipped else backup_select_resources_new_role_info.iam_role.arn }}"
5757

5858
- name: Create or update backup selection
5959
amazon.aws.backup_selection:

tests/integration/targets/test_deploy_flask_app/roles/run_deploy_flask_app/tasks/create.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@
184184
- "{{ secgroup.group_id }}"
185185
user_data: |
186186
#!/bin/bash
187-
yum install -y python3 python-virtualenv sshpass netcat ansible
187+
yum install -y python3 python3-virtualenv sshpass netcat ansible-core
188188
wait: true
189189
state: started
190190
register: vm_result

tests/integration/targets/test_deploy_flask_app/roles/run_deploy_flask_app/vars/main.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ rds_allocated_storage_gb: 20
1919
rds_instance_class: db.m6g.large
2020
rds_instance_name: mysampledb123
2121
rds_engine: postgres
22-
rds_engine_version: "14.8"
22+
rds_engine_version: "16.2"
2323
bastion_host_type: t3.micro
2424
bastion_host_venv_path: ~/env
25-
image_filter: Fedora-Cloud-Base-38-*
25+
image_filter: Fedora-Cloud-Base-39-*
2626
bastion_host_iam_role: "{{ resource_prefix }}-role"
2727

2828
# vars for the deploy_flask_app role and create task

tests/integration/targets/test_deploy_flask_app/runme.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ trap 'cleanup "${@}"' ERR
1313
ansible-playbook run.yaml -e "run_deploy_flask_app_operation=create" "$@"
1414

1515
# Delete web application
16-
ansible-playbook run.yaml -e "run_deploy_flask_app_operation=delete" "$@"
16+
ansible-playbook run.yaml -e "run_deploy_flask_app_operation=delete" "$@"

0 commit comments

Comments
 (0)