Fix#122 (#124)

* fixes#122

Signed-off-by: raffaelespazzoli <[email protected]>

* fixed status

Signed-off-by: raffaelespazzoli <[email protected]>

* added docs

Signed-off-by: raffaelespazzoli <[email protected]>

Author: raffaelespazzoli

README.md

@@ -184,6 +184,10 @@ spec:
 
 User will be selected by this `UserConfig` only if they login via the *okta-provider* and if the extra field was populate with the label `sandbox_enabled: "true"`. Note that not all authentication provider allow populating the extra fields in the Identity object.
 
+## CR status
+
+The CR status will display the outcome of the last reconcile cycle, plus any error regarding specific resources. Notice that in the past the operator was displaying also successful reconcile statuses for watched resources. Removing the status about successful resources allows for the operator to manage more resources with a single configuration (there is a limit to how big a CR can be).
+
 ## Deploying the Operator
 
 This is a cluster-level operator that you can deploy in any namespace, `namespace-configuration-operator` is recommended.

config/manifests/bases/namespace-configuration-operator.clusterserviceversion.yaml

@@ -11,16 +11,16 @@ metadata:
     description: This operator provides a facility to define and enforce namespace
       configurations
     operatorframework.io/suggested-namespace: namespace-configuration-operator
+    operators.openshift.io/infrastructure-features: '["Disconnected"]'
     repository: https://github.com/redhat-cop/namespace-configuration-operator
     support: Best Effort
-    operators.openshift.io/infrastructure-features: '["Disconnected"]'
-  name: namespace-configuration-operator.v0.0.0
-  namespace: placeholder
   labels:
-    operatorframework.io/os.linux: supported
     operatorframework.io/arch.amd64: supported
     operatorframework.io/arch.arm64: supported
     operatorframework.io/arch.ppc64le: supported
+    operatorframework.io/os.linux: supported
+  name: namespace-configuration-operator.v0.0.0
+  namespace: placeholder
 spec:
   apiservicedefinitions: {}
   customresourcedefinitions:

controllers/userconfig_controller.go

@@ -224,7 +224,8 @@ func (r *UserConfigReconciler) findApplicableUserConfigsFromUser(user *userv1.Us
 	}
 	matchingIdentities := []userv1.Identity{}
 	for _, identity := range identitiesList.Items {
-		matchingIdentities = append(matchingIdentities, identity)
+		cidentity := identity.DeepCopy()
+		matchingIdentities = append(matchingIdentities, *cidentity)
 	}
 	return r.findApplicableUserConfigsFromIdentities(user, matchingIdentities)
 }

go.mod

@@ -7,10 +7,10 @@ require (
 	github.com/onsi/ginkgo v1.16.4
 	github.com/onsi/gomega v1.13.0
 	github.com/openshift/api v3.9.0+incompatible
-	github.com/redhat-cop/operator-utils v1.1.4
+	github.com/redhat-cop/operator-utils v1.2.2
 	github.com/scylladb/go-set v1.0.2
-	k8s.io/api v0.20.2
-	k8s.io/apimachinery v0.20.2
-	k8s.io/client-go v0.20.2
-	sigs.k8s.io/controller-runtime v0.8.3
+	k8s.io/api v0.21.2
+	k8s.io/apimachinery v0.21.2
+	k8s.io/client-go v0.21.2
+	sigs.k8s.io/controller-runtime v0.9.2
 )