fix: address linter errors and enable all usual checks for the codebase

Signed-off-by: Denis Golovin <[email protected]>

Author: dgolovin

.eslintrc.json

@@ -20,7 +20,8 @@
     "sourceType": "module",
     "warnOnUnsupportedTypeScriptVersion": false,
     "project": [
-      "tsconfig.json"
+      "tsconfig.json",
+      "tests/tsconfig.json"
     ]
   },
   "overrides": [

.github/workflows/pr-check.yaml

@@ -20,10 +20,68 @@ name: pr-check
 on: [pull_request]
 
 jobs:
-  pr-check-job:
+  
+  build:
+    name: Build
+    needs: test
     strategy:
       matrix:
         target: [windows-2022, macos-14, ubuntu-20.04]
+      fail-fast: true
     uses: redhat-developer/podman-desktop-redhat-account-ext/.github/workflows/build.yaml@main
     with:
-      runs-on: ${{ matrix.target }}
+      runs-on: ${{ matrix.target }}
+  
+  test:
+    name: Test
+    runs-on: ${{ matrix.target }}
+    strategy:
+      matrix:
+        target: [windows-2022, macos-14, ubuntu-22.04]
+      fail-fast: true
+      
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+
+      - name: Get yarn cache directory path (Windows)
+        if: ${{ matrix.target=='windows-2022' }}
+        id: yarn-cache-dir-path-windows
+        run: echo "dir=$(yarn cache dir)" >> ${env:GITHUB_OUTPUT}
+
+      - name: Get yarn cache directory path (mac/Linux)
+        if: ${{ matrix.target=='ubuntu-22.04'}}
+        id: yarn-cache-dir-path-unix
+        run: echo "dir=$(yarn cache dir)" >> ${GITHUB_OUTPUT}
+
+      - uses: actions/cache@v4
+        if: ${{ matrix.target=='windows-2022' }}
+        id: yarn-cache-windows
+        with:
+          path: ${{ steps.yarn-cache-dir-path-windows.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.target }}-yarn-
+
+      - uses: actions/cache@v4
+        if: ${{ matrix.target=='ubuntu-22.04'}}
+        id: yarn-cache-unix
+        with:
+          path: ${{ steps.yarn-cache-dir-path-unix.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+
+      - name: Execute yarn
+        run: yarn --frozen-lockfile --network-timeout 180000
+
+      - name: Run linter
+        run: yarn lint:check
+
+      - name: Run formatter
+        run: yarn format:check
+
+      - name: Run unit tests
+        run: yarn test

package.json

@@ -34,7 +34,7 @@
   "scripts": {
     "build": "rollup --bundleConfigAsCjs --config rollup.config.js --compact --environment BUILD:production  && node ./scripts/build.js",
     "watch": "rollup --bundleConfigAsCjs --config rollup.config.js -w",
-    "format:check": "prettier --cache --check \"{src,types,scripts}/**/*.{ts,js}\"",
+    "format:check": "prettier --end-of-line auto --cache --check \"{src,types,scripts}/**/*.{ts,js}\"",
     "format:fix": "prettier --cache --write \"{src,types,scripts}/**/*.{ts,js}\"",
     "lint:clean": "rimraf .eslintcache",
     "lint:fix": "node --max-old-space-size=6144 node_modules/eslint/bin/eslint.js --cache . --fix --ext js,ts",

src/authentication-server.ts

@@ -16,22 +16,30 @@
  * SPDX-License-Identifier: Apache-2.0
  ***********************************************************************/
 
-import * as fs from 'fs';
-import * as http from 'http';
-import * as path from 'path';
-import * as url from 'url';
-import { ServerConfig, AuthConfig } from './configuration';
+import * as fs from 'node:fs';
+import * as http from 'node:http';
+import * as path from 'node:path';
+import * as url from 'node:url';
+
+import type { AuthConfig, ServerConfig } from './configuration';
 
 interface Deferred<T> {
   resolve: (result: T | Promise<T>) => void;
-  reject: (reason: any) => void;
+  reject: (reason: unknown) => void;
 }
 
 export type RedirectResult =
   | { req: http.IncomingMessage; res: http.ServerResponse }
-  | { err: any; res: http.ServerResponse };
+  | { err: unknown; res: http.ServerResponse };
 
-export function createServer(config: AuthConfig, nonce: string) {
+export function createServer(
+  config: AuthConfig,
+  nonce: string,
+): {
+  server: http.Server<typeof http.IncomingMessage, typeof http.ServerResponse>;
+  redirectPromise: Promise<RedirectResult>;
+  callbackPromise: Promise<RedirectResult>;
+} {
   let deferredRedirect: Deferred<RedirectResult>;
   const redirectPromise = new Promise<RedirectResult>((resolve, reject) => (deferredRedirect = { resolve, reject }));
 
@@ -76,7 +84,7 @@ export function createServer(config: AuthConfig, nonce: string) {
 export async function startServer(config: ServerConfig, server: http.Server): Promise<string> {
   let portTimer: NodeJS.Timeout;
 
-  function cancelPortTimer() {
+  function cancelPortTimer(): void {
     clearTimeout(portTimer);
   }
 
@@ -87,6 +95,7 @@ export async function startServer(config: ServerConfig, server: http.Server): Pr
 
     server.on('listening', () => {
       const address = server.address();
+      // eslint-disable-next-line no-null/no-null
       if (typeof address === 'undefined' || address === null) {
         reject(new Error('adress is null or undefined'));
       } else if (typeof address === 'string') {
@@ -111,7 +120,7 @@ export async function startServer(config: ServerConfig, server: http.Server): Pr
   return port;
 }
 
-function sendFile(res: http.ServerResponse, filepath: string, contentType: string) {
+function sendFile(res: http.ServerResponse, filepath: string, contentType: string): void {
   fs.stat(filepath, (err, stats) => {
     if (err) {
       console.error(err);

src/authentication-service.spec.ts

@@ -16,10 +16,13 @@
  * SPDX-License-Identifier: Apache-2.0
  ***********************************************************************/
 
+import type { ExtensionContext } from '@podman-desktop/api';
+import { authentication } from '@podman-desktop/api';
+import type { BaseClient, TokenSet } from 'openid-client';
+import { Issuer } from 'openid-client';
 import { beforeEach, expect, test, vi } from 'vitest';
-import { RedHatAuthenticationService, convertToSession } from './authentication-service';
-import { AuthenticationProvider, ExtensionContext, authentication } from '@podman-desktop/api';
-import { TokenSet, Issuer, BaseClient } from 'openid-client';
+
+import { convertToSession, RedHatAuthenticationService } from './authentication-service';
 import { getAuthConfig } from './configuration';
 
 vi.mock('@podman-desktop/api', async () => {
@@ -70,11 +73,11 @@ test('An authentication token is converted to a session', () => {
 });
 
 test('Authentication service loads tokens form secret storage during initialization', async () => {
-  vi.spyOn(Issuer, 'discover').mockImplementation(async (url: string) => {
+  vi.spyOn(Issuer, 'discover').mockImplementation(async () => {
     return {
       Client: vi.fn().mockImplementation(() => {
         return {
-          refresh: vi.fn().mockImplementation((refreshToken: string): TokenSet => {
+          refresh: vi.fn().mockImplementation((): TokenSet => {
             return {
               claims: vi.fn().mockImplementation(() => {
                 return {
@@ -98,9 +101,7 @@ test('Authentication service loads tokens form secret storage during initializat
     } as unknown as Issuer<BaseClient>;
   });
 
-  let provider: AuthenticationProvider;
-  vi.mocked(authentication.registerAuthenticationProvider).mockImplementation((_id, _label, ssoProvider) => {
-    provider = ssoProvider;
+  vi.mocked(authentication.registerAuthenticationProvider).mockImplementation((_id, _label, _ssoProvider) => {
     return {
       dispose: vi.fn(),
     };