Skip to content

Commit 5181471

Browse files
authored
chore(ci): fix sanity checks & re-enable audit-log for showcase (#2417)
* chore(ci): fix sanity checks & re-enable audit-log for showcase * Fix the directory * Add option to overwrite the plugins key
1 parent 8f18aa0 commit 5181471

File tree

6 files changed

+46
-32
lines changed

6 files changed

+46
-32
lines changed

.ibm/pipelines/cluster/aks/deployment.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ initiate_aks_deployment() {
99
cd "${DIR}" || exit
1010
local rhdh_base_url="https://${K8S_CLUSTER_ROUTER_BASE}"
1111
apply_yaml_files "${DIR}" "${NAME_SPACE_K8S}" "${rhdh_base_url}"
12-
yq_merge_value_files "${DIR}/value_files/${HELM_CHART_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_AKS_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_K8S_MERGED_VALUE_FILE_NAME}"
12+
yq_merge_value_files "merge" "${DIR}/value_files/${HELM_CHART_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_AKS_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_K8S_MERGED_VALUE_FILE_NAME}"
1313
mkdir -p "${ARTIFACT_DIR}/${NAME_SPACE_K8S}"
1414
cp -a "/tmp/${HELM_CHART_K8S_MERGED_VALUE_FILE_NAME}" "${ARTIFACT_DIR}/${NAME_SPACE_K8S}/" # Save the final value-file into the artifacts directory.
1515
echo "Deploying image from repository: ${QUAY_REPO}, TAG_NAME: ${TAG_NAME}, in NAME_SPACE: ${NAME_SPACE_K8S}"
@@ -30,7 +30,7 @@ initiate_rbac_aks_deployment() {
3030
cd "${DIR}" || exit
3131
local rbac_rhdh_base_url="https://${K8S_CLUSTER_ROUTER_BASE}"
3232
apply_yaml_files "${DIR}" "${NAME_SPACE_RBAC_K8S}" "${rbac_rhdh_base_url}"
33-
yq_merge_value_files "${DIR}/value_files/${HELM_CHART_RBAC_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_RBAC_AKS_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_RBAC_K8S_MERGED_VALUE_FILE_NAME}"
33+
yq_merge_value_files "merge" "${DIR}/value_files/${HELM_CHART_RBAC_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_RBAC_AKS_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_RBAC_K8S_MERGED_VALUE_FILE_NAME}"
3434
mkdir -p "${ARTIFACT_DIR}/${NAME_SPACE_RBAC_K8S}"
3535
cp -a "/tmp/${HELM_CHART_RBAC_K8S_MERGED_VALUE_FILE_NAME}" "${ARTIFACT_DIR}/${NAME_SPACE_RBAC_K8S}/" # Save the final value-file into the artifacts directory.
3636
echo "Deploying image from repository: ${QUAY_REPO}, TAG_NAME: ${TAG_NAME}, in NAME_SPACE: ${NAME_SPACE_RBAC_K8S}"

.ibm/pipelines/cluster/gke/deployment.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ initiate_gke_deployment() {
1111
local rhdh_base_url="https://${K8S_CLUSTER_ROUTER_BASE}"
1212
apply_yaml_files "${DIR}" "${NAME_SPACE_K8S}" "${rhdh_base_url}"
1313
oc apply -f "${DIR}/cluster/gke/frontend-config.yaml" --namespace="${project}"
14-
yq_merge_value_files "${DIR}/value_files/${HELM_CHART_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_GKE_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_K8S_MERGED_VALUE_FILE_NAME}"
14+
yq_merge_value_files "merge" "${DIR}/value_files/${HELM_CHART_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_GKE_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_K8S_MERGED_VALUE_FILE_NAME}"
1515
mkdir -p "${ARTIFACT_DIR}/${NAME_SPACE_K8S}"
1616
cp -a "/tmp/${HELM_CHART_K8S_MERGED_VALUE_FILE_NAME}" "${ARTIFACT_DIR}/${NAME_SPACE_K8S}/" # Save the final value-file into the artifacts directory.
1717
echo "Deploying image from repository: ${QUAY_REPO}, TAG_NAME: ${TAG_NAME}, in NAME_SPACE: ${NAME_SPACE_K8S}"
@@ -34,7 +34,7 @@ initiate_rbac_gke_deployment() {
3434
cd "${DIR}" || exit
3535
local rbac_rhdh_base_url="https://${K8S_CLUSTER_ROUTER_BASE}"
3636
apply_yaml_files "${DIR}" "${NAME_SPACE_RBAC_K8S}" "${rbac_rhdh_base_url}"
37-
yq_merge_value_files "${DIR}/value_files/${HELM_CHART_RBAC_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_RBAC_GKE_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_RBAC_K8S_MERGED_VALUE_FILE_NAME}"
37+
yq_merge_value_files "merge" "${DIR}/value_files/${HELM_CHART_RBAC_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_RBAC_GKE_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_RBAC_K8S_MERGED_VALUE_FILE_NAME}"
3838
mkdir -p "${ARTIFACT_DIR}/${NAME_SPACE_RBAC_K8S}"
3939
cp -a "/tmp/${HELM_CHART_RBAC_K8S_MERGED_VALUE_FILE_NAME}" "${ARTIFACT_DIR}/${NAME_SPACE_RBAC_K8S}/" # Save the final value-file into the artifacts directory.
4040
echo "Deploying image from repository: ${QUAY_REPO}, TAG_NAME: ${TAG_NAME}, in NAME_SPACE: ${NAME_SPACE_RBAC_K8S}"

.ibm/pipelines/env_variables.sh

+3
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ HELM_CHART_AKS_DIFF_VALUE_FILE_NAME="diff-values_showcase_AKS.yaml"
1010
HELM_CHART_RBAC_AKS_DIFF_VALUE_FILE_NAME="diff-values_showcase-rbac_AKS.yaml"
1111
HELM_CHART_GKE_DIFF_VALUE_FILE_NAME="diff-values_showcase_GKE.yaml"
1212
HELM_CHART_RBAC_GKE_DIFF_VALUE_FILE_NAME="diff-values_showcase-rbac_GKE.yaml"
13+
HELM_CHART_SANITY_PLUGINS_DIFF_VALUE_FILE_NAME="diff-values_showcase-sanity-plugins.yaml"
14+
HELM_CHART_SANITY_PLUGINS_MERGED_VALUE_FILE_NAME="merged-values_showcase-sanity-plugins.yaml"
15+
1316
HELM_IMAGE_NAME=backstage
1417
HELM_REPO_NAME=rhdh-chart
1518
HELM_REPO_URL="https://redhat-developer.github.io/rhdh-chart"

.ibm/pipelines/utils.sh

+39-27
Original file line numberDiff line numberDiff line change
@@ -218,28 +218,38 @@ reportportal_slack_alert() {
218218

219219
# Merge the base YAML value file with the differences file for Kubernetes
220220
yq_merge_value_files() {
221-
local base_file=$1
222-
local diff_file=$2
221+
local plugin_operation=$1 # Chose whether you want to merge or overwrite the plugins key (the second file will overwrite the first)
222+
local base_file=$2
223+
local diff_file=$3
223224
local step_1_file="/tmp/step-without-plugins.yaml"
224225
local step_2_file="/tmp/step-only-plugins.yaml"
225-
local final_file=$3
226-
# Step 1: Merge files, excluding the .global.dynamic.plugins key
227-
# Values from `diff_file` override those in `base_file`
228-
yq eval-all '
229-
select(fileIndex == 0) * select(fileIndex == 1) |
230-
del(.global.dynamic.plugins)
231-
' "${base_file}" "${diff_file}" > "${step_1_file}"
232-
# Step 2: Merge files, combining the .global.dynamic.plugins key
233-
# Values from `diff_file` take precedence; plugins are merged and deduplicated by the .package field
234-
yq eval-all '
235-
select(fileIndex == 0) *+ select(fileIndex == 1) |
236-
.global.dynamic.plugins |= (reverse | unique_by(.package) | reverse)
237-
' "${base_file}" "${diff_file}" > "${step_2_file}"
238-
# Step 3: Combine results from the previous steps and remove null values
239-
# Values from `step_2_file` override those in `step_1_file`
240-
yq eval-all '
241-
select(fileIndex == 0) * select(fileIndex == 1) | del(.. | select(. == null))
242-
' "${step_2_file}" "${step_1_file}" > "${final_file}"
226+
local final_file=$4
227+
if [ "$plugin_operation" = "merge" ]; then
228+
# Step 1: Merge files, excluding the .global.dynamic.plugins key
229+
# Values from `diff_file` override those in `base_file`
230+
yq eval-all '
231+
select(fileIndex == 0) * select(fileIndex == 1) |
232+
del(.global.dynamic.plugins)
233+
' "${base_file}" "${diff_file}" > "${step_1_file}"
234+
# Step 2: Merge files, combining the .global.dynamic.plugins key
235+
# Values from `diff_file` take precedence; plugins are merged and deduplicated by the .package field
236+
yq eval-all '
237+
select(fileIndex == 0) *+ select(fileIndex == 1) |
238+
.global.dynamic.plugins |= (reverse | unique_by(.package) | reverse)
239+
' "${base_file}" "${diff_file}" > "${step_2_file}"
240+
# Step 3: Combine results from the previous steps and remove null values
241+
# Values from `step_2_file` override those in `step_1_file`
242+
yq eval-all '
243+
select(fileIndex == 0) * select(fileIndex == 1) | del(.. | select(. == null))
244+
' "${step_2_file}" "${step_1_file}" > "${final_file}"
245+
elif [ "$plugin_operation" = "overwrite" ]; then
246+
yq eval-all '
247+
select(fileIndex == 0) * select(fileIndex == 1)
248+
' "${base_file}" "${diff_file}" > "${final_file}"
249+
else
250+
echo "Invalid operation with plugins key: $plugin_operation"
251+
exit 1
252+
fi
243253
}
244254

245255
# Waits for a Kubernetes/OpenShift deployment to become ready within a specified timeout period
@@ -833,14 +843,16 @@ initiate_sanity_plugin_checks_deployment() {
833843
uninstall_helmchart "${NAME_SPACE_SANITY_PLUGINS_CHECK}" "${RELEASE_NAME}"
834844
oc apply -f "$DIR/resources/redis-cache/redis-deployment.yaml" --namespace="${NAME_SPACE_SANITY_PLUGINS_CHECK}"
835845
apply_yaml_files "${DIR}" "${NAME_SPACE_SANITY_PLUGINS_CHECK}" "${sanity_plugins_url}"
846+
yq_merge_value_files "overwrite" "${DIR}/value_files/${HELM_CHART_VALUE_FILE_NAME}" "${DIR}/value_files/${HELM_CHART_SANITY_PLUGINS_DIFF_VALUE_FILE_NAME}" "/tmp/${HELM_CHART_SANITY_PLUGINS_MERGED_VALUE_FILE_NAME}"
847+
mkdir -p "${ARTIFACT_DIR}/${NAME_SPACE_SANITY_PLUGINS_CHECK}"
848+
cp -a "/tmp/${HELM_CHART_SANITY_PLUGINS_MERGED_VALUE_FILE_NAME}" "${ARTIFACT_DIR}/${NAME_SPACE_SANITY_PLUGINS_CHECK}/" # Save the final value-file into the artifacts directory.
836849
helm upgrade -i "${RELEASE_NAME}" \
837-
-n "${NAME_SPACE_SANITY_PLUGINS_CHECK}" "${HELM_REPO_NAME}/${HELM_IMAGE_NAME}" \
838-
--version "${CHART_VERSION}" \
839-
-f "${DIR}/value_files/${HELM_CHART_VALUE_FILE_NAME}" \
840-
-f "${DIR}/value_files/sanity-check-plugins.yaml" \
841-
--set global.clusterRouterBase="${K8S_CLUSTER_ROUTER_BASE}" \
842-
--set upstream.backstage.image.repository="${QUAY_REPO}" \
843-
--set upstream.backstage.image.tag="${TAG_NAME}"
850+
-n "${NAME_SPACE_SANITY_PLUGINS_CHECK}" "${HELM_REPO_NAME}/${HELM_IMAGE_NAME}" \
851+
--version "${CHART_VERSION}" \
852+
-f "/tmp/${HELM_CHART_SANITY_PLUGINS_MERGED_VALUE_FILE_NAME}" \
853+
--set global.clusterRouterBase="${K8S_CLUSTER_ROUTER_BASE}" \
854+
--set upstream.backstage.image.repository="${QUAY_REPO}" \
855+
--set upstream.backstage.image.tag="${TAG_NAME}"
844856
}
845857

846858
check_and_test() {

e2e-tests/playwright.config.ts

-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export default defineConfig({
6262
"**/playwright/e2e/verify-tls-config-health-check.spec.ts",
6363
"**/playwright/e2e/configuration-test/config-map.spec.ts",
6464
"**/playwright/e2e/plugins/tekton/tekton.spec.ts",
65-
"**/playwright/e2e/audit-log/**/*.spec.ts",
6665
],
6766
},
6867
{

0 commit comments

Comments
 (0)