Lombok @SuperBuilder annotation not supported by extension

[zymotik]

Environment

• Operating System: Microsoft Windows 11 Home 10.0.22621 N/A Build 22621 Ubuntu 20.04.4 LTS
• JDK version: openjdk version "17.0.4" 2022-07-19 LTS
• Visual Studio Code version: 1.73.1
• Java extension version: v1.13.2022112903 (pre-release)

Steps To Reproduce

1. Clone repo https://github.com/zymotik/redhat-developer-vscode-java-issue-2805
2. Open in Visual Studio Code (with Java extension)
3. Open src/main/java/com/virtualvenue/model/widget/ContentWidget.java and check line 33 is marked as valid
4. Application builds without issue, the problem is only reported by the VSCode extension

Java Language Server workspace logs - SuperBuilder annotation error

Current Result

Duplicate type parameter CJava(536871432)
Bound mismatch: The type C is not a valid substitute for the bounded parameter <C extends ScheduledContentInstance> of the type ContentWidget<C>Java(16777742)
Bound mismatch: The type C is not a valid substitute for the bounded parameter <C extends ScheduledContentInstance> of the type ContentWidget.ContentWidgetBuilder<C,C,B>Java(16777742)
Bound mismatch: The type ContentWidget<C> is not a valid substitute for the bounded parameter <C extends ContentWidget<C>> of the type ContentWidget.ContentWidgetBuilder<C,C,B>Java(16777742)
Type mismatch: cannot convert from List<C> to Collection<? extends capture#1-of ?>Java(16777233)
The constructor ArrayList<C>(ArrayList<capture#1-of ?>) is undefinedJava(134217858)
The method unmodifiableList(List<? extends T>) in the type Collections is not applicable for the arguments (ArrayList<C>)Java(67108979)

Expected Result

No errors reported in VSCode

[jdneo]

@testforstephen Is this related with the type mismatch issues you are looking in jdt core recently?

[snjeza]

This is an upstream lombok issue. lombok uses C and B as its internal generics.
See https://github.com/projectlombok/lombok/blob/731bb185077918af8bc1e6a9e6bb538b2d3fbbd8/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java#L254
There is a bug in https://github.com/projectlombok/lombok/blob/731bb185077918af8bc1e6a9e6bb538b2d3fbbd8/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java#L1112
You can try the following PR

diff --git a/src/main/java/com/virtualvenue/model/widget/ContentWidget.java b/src/main/java/com/virtualvenue/model/widget/ContentWidget.java
index 69eb0c2..0f71a39 100644
--- a/src/main/java/com/virtualvenue/model/widget/ContentWidget.java
+++ b/src/main/java/com/virtualvenue/model/widget/ContentWidget.java
@@ -43,7 +43,7 @@ import java.util.stream.Collectors;
 @JsonSubTypes({
     @JsonSubTypes.Type(value = TextNotificationWidget.class)
 })
-public class ContentWidget<C extends ScheduledContentInstance> implements WithUniqueID<ContentWidget<C>>, AssetUser {
+public class ContentWidget<X extends ScheduledContentInstance> implements WithUniqueID<ContentWidget<X>>, AssetUser {
 
     /**
      * Globally Unique OBJECT ID
@@ -71,7 +71,7 @@ public class ContentWidget<C extends ScheduledContentInstance> implements WithUn
         // we do not add ScheduledCustomAreaNav here intentionally, since no "ContentWidget" should ever use it
     })
     @XmlElementWrapper(name = "configurations")
-    List<C> configurations = new ArrayList<>();//@NonNull!
+    List<X> configurations = new ArrayList<>();//@NonNull!
 
     @Override
     public List<String> listAssetUses(String assetId) {

[zymotik]

This is an upstream lombok issue. lombok uses C and B as its internal generics. See https://github.com/projectlombok/lombok/blob/731bb185077918af8bc1e6a9e6bb538b2d3fbbd8/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java#L254 There is a bug in https://github.com/projectlombok/lombok/blob/731bb185077918af8bc1e6a9e6bb538b2d3fbbd8/src/core/lombok/eclipse/handlers/HandleSuperBuilder.java#L1112 You can try the following PR

This worked for me, thank you @snjeza! 👍