New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quick Fix to support creating a Record when encountering an unknown type #3988

Closed

erikweibust opened this issue Mar 26, 2025 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#3420

Assignees

Labels

code action enhancement

Milestone

Early April 2025

erikweibust commented Mar 26, 2025

When using the Quick Fix feature I expect that it should recommend "create record XXX" when it encounters an unknown type in code. I don't see that or a way to enable it.

rgrunber added enhancement code action labels

Member

rgrunber commented Mar 26, 2025

Looks like we're missing the code from places like https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/8e8ab276f031282fc8c37aaa2a89d6a38e913c8f/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corrections/proposals/NewCUProposal.java#L293-L310 . It should be pretty easy to implement though so I can try that and see if it resolves things.

rgrunber self-assigned this

rgrunber added this to Java Tooling

rgrunber moved this to In Progress in Java Tooling

Author

erikweibust commented Mar 26, 2025

Awesome! Please let me know if I can help test this enhancement.

rgrunber mentioned this issue

Add "Create record" quick fix. eclipse-jdtls/eclipse.jdt.ls#3420

Merged

rgrunber moved this from In Progress to Pending review in Java Tooling

rgrunber added this to the End April 2025 milestone

rgrunber closed this as completed in eclipse-jdtls/eclipse.jdt.ls#3420

github-project-automation bot moved this from Pending review to Done in Java Tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment