Auto close/complete diamond operator <>

[mamilic]

At the moment when open diamond operator is being typed it is not autoclosed, it would improve the writing flow if the diamon operator could be auto closed/completed.

[mamilic]

Hi @rgrunber , are there any issues in this repo or the jdt.ls that I can jump in to solve?

[rgrunber]

I think this is probably controlled by

vscode-java/language-support/java/language-configuration.json

Lines 27 to 65 in 99c1257

	"autoClosingPairs": [
	[
	"{",
	"}"
	],
	[
	"[",
	"]"
	],
	[
	"(",
	")"
	],
	{
	"open": "\"",
	"close": "\"",
	"notIn": [
	"string"
	]
	},
	[
	"'",
	"'"
	],
	{
	"open": "/*",
	"close": " */",
	"notIn": [
	"string"
	]
	},
	{
	"open": "\"\"\"",
	"close": "\"\"\";",
	"notIn": [
	"comment"
	]
	}
	],

so if the angle brackets are just added there, it'd work. They're already added to surroundingPairs which would have them surround a selected text range.

The reason I can think of for not doing this is that the < could imply a diamond operator <> or just a comparison (.. < ...). Trying to figure out which (in an expression or not), would require info from the language server, which complicates things :\

[mamilic]

Hi @rgrunber , I agree with you, thanks for explanation. Also, if you have some issues that I can take on, please let me know.

[rgrunber]

@mamilic , do you want something purely typescript related, or would you be interested in things on the Java language server side ?

eclipse-jdtls/eclipse.jdt.ls#2940 I think is pretty straightforward, just involves making a helper method for a few calls.

eclipse-jdtls/eclipse.jdt.ls#1872 would be nice to fix if it still occurs. Peek Call hierarchy doesn't correctly jump to the right reference because we duplicate the fromRange data from the first occurrence.

eclipse-jdtls/eclipse.jdt.ls#3083 seems like maybe something could be done ? There was a piece of logic there that made no sense to me but I never had the time to fix it.

[mamilic]

Hi @rgrunber , have no preference on the tool. All of those sounds interesting will take them. Thanks!