Skip to content

Commit 5c11f2c

Browse files
Properly saving the results folder and website (#312)
* Storing ann benchmark artifacts (website and results) into s3. Agnostic client artifacts table * Fixed ann-benchmarks results folder not being properly deleted * Properly saving the results folder and website
1 parent fc6fe15 commit 5c11f2c

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

redisbench_admin/run_remote/remote_client.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -112,25 +112,25 @@ def run_remote_client_tool(
112112
benchmark_suffix = local_bench_fname[: len(local_bench_fname) - 5]
113113
create_website_path = pkg_path + "/run/ann/pkg/"
114114
logging.info("Remote create website path: {}".format(create_website_path))
115-
website_outputdir = "/tmp/website-{}".format(benchmark_suffix)
115+
website_outputdir = "website-{}".format(benchmark_suffix)
116116
website_outputdir_zip = "/tmp/website-{}.zip".format(benchmark_suffix)
117117
website_outputdir_zip_local = "website-{}.zip".format(benchmark_suffix)
118-
results_outputdir = pkg_path + "/run/ann/pkg/results"
118+
results_outputdir = pkg_path + "/run/ann/pkg"
119119
results_outputdir_zip = "/tmp/results-{}.zip".format(benchmark_suffix)
120120
results_outputdir_zip_local = "results-{}.zip".format(benchmark_suffix)
121121

122-
mkdir_command = "mkdir -p {}".format(website_outputdir)
122+
mkdir_command = "mkdir -p /tmp/{}".format(website_outputdir)
123123
create_website_command = (
124-
"cd {} && sudo python3 create_website.py --outputdir {}".format(
124+
"cd {} && sudo python3 create_website.py --outputdir /tmp/{}".format(
125125
create_website_path, website_outputdir
126126
)
127127
)
128-
zip_website_command = "zip -r {} {}".format(
128+
zip_website_command = "cd /tmp && zip -r {} {}/*".format(
129129
website_outputdir_zip, website_outputdir
130130
)
131131

132-
zip_results_command = "zip -r {} {}".format(
133-
results_outputdir_zip, results_outputdir
132+
zip_results_command = "cd {} && zip -r {} results/*".format(
133+
results_outputdir, results_outputdir_zip
134134
)
135135
commands.append(mkdir_command)
136136
commands.append(create_website_command)
@@ -238,7 +238,7 @@ def setup_remote_benchmark_ann(
238238
)
239239
logging.info("ensuring there is a clean results folder on ann-benchmarks pkg")
240240
commands = [
241-
"sudo rm -rf {}/results/*".format(pkg_path),
241+
"sudo rm -rf {}/run/ann/pkg/results/*".format(pkg_path),
242242
]
243243
execute_remote_commands(
244244
client_public_ip, username, private_key, commands, client_ssh_port, True

0 commit comments

Comments
 (0)