Detect and work with missing --github_actor, --github_branch, and --github_sha (#73)

Author: filipecosta90

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redisbench-admin"
-version = "0.1.60"
+version = "0.1.61"
 description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
 authors = ["filipecosta90 <[email protected]>"]
 readme = "README.md"

redisbench_admin/run_remote/args.py

@@ -22,10 +22,10 @@ def create_run_remote_arguments(parser):
         default="",
         help="specify a test to run. By default will run all of them.",
     )
-    parser.add_argument("--github_actor", type=str, default=None)
+    parser.add_argument("--github_actor", type=str, default=None, nargs="?", const="")
     parser.add_argument("--github_repo", type=str, default=None)
     parser.add_argument("--github_org", type=str, default=None)
-    parser.add_argument("--github_sha", type=str, default=None)
+    parser.add_argument("--github_sha", type=str, default=None, nargs="?", const="")
     parser.add_argument("--github_branch", type=str, default=None, nargs="?", const="")
     parser.add_argument("--triggering_env", type=str, default=socket.gethostname())
     parser.add_argument("--terraform_bin_path", type=str, default=TERRAFORM_BIN_PATH)

tests/test_args.py

@@ -0,0 +1,34 @@
+import argparse
+
+from redisbench_admin.run_local.args import create_run_local_arguments
+from redisbench_admin.run_remote.args import create_run_remote_arguments
+
+
+def test_create_run_remote_arguments():
+    parser = argparse.ArgumentParser(
+        description="test",
+        formatter_class=argparse.ArgumentDefaultsHelpFormatter,
+    )
+    parser = create_run_remote_arguments(parser)
+    args = parser.parse_args(args=["--github_actor", "--module_path", "mymodule.so"])
+    assert args.github_actor == ""
+    args = parser.parse_args(args=["--github_branch", "--module_path", "mymodule.so"])
+    assert args.github_branch == ""
+    args = parser.parse_args(args=["--github_sha", "--module_path", "mymodule.so"])
+    assert args.github_sha == ""
+    args = parser.parse_args(
+        args=["--github_actor", "gh.user", "--module_path", "mymodule.so"]
+    )
+    assert args.github_actor == "gh.user"
+
+
+def test_create_run_local_arguments():
+    parser = argparse.ArgumentParser(
+        description="test",
+        formatter_class=argparse.ArgumentDefaultsHelpFormatter,
+    )
+    parser = create_run_local_arguments(parser)
+    args = parser.parse_args(
+        args=["--module_path", "mymodule.so", "--test", "test1.yml"]
+    )
+    assert args.test == "test1.yml"