Facing issue in mocking while migrating from go-redis, mockery mocks

[akshaykhairmode]

Hi @rueian

Currently facing mock issue in my repo for mocking the Cache() method. The Cache() method returns a concrete type of CachaCompat.

cacheCompat := mocks.NewCacheCompat(t)

stringCmd := &rueidiscompat.StringCmd{}
stringCmd.SetErr(rueidiscompat.Nil)
RedisClient.On("Cache", 100*time.Millisecond).Return(cacheCompat)
cacheCompat.On("Get", ctx, "key").Return(stringCmd)

Also creating an interface at my end does not work as mockery fails it with incorrect type.

panic: interface conversion: interface {} is *mocks.CacheCompat, not rueidiscompat.CacheCompat [recovered, repanicked]

Only solution which I see is to return the CacheCompat as an interface, what do you suggest?

[akshaykhairmode]

Having my own wrapper seems to be working, but not sure if this is idiomatic.

type RueidisWrapperClient struct {
	rueidiscompat.Cmdable
}

func (c *RueidisWrapperClient) Cache(ttl time.Duration) CacheCompatWrapperIface {
	cacheCompat := c.Cmdable.Cache(ttl)
	return &CacheCompatWrapper{CacheCompat: cacheCompat}
}

type RedisClient interface {
	rueidiscompat.CoreCmdable

	Cache(ttl time.Duration) CacheCompatWrapperIface
}

var _ RedisClient = (*RueidisWrapperClient)(nil)

---

type CacheCompatWrapper struct {
	CacheCompat rueidiscompat.CacheCompat
}

func (ccw *CacheCompatWrapper) Get(ctx context.Context, key string) *rueidiscompat.StringCmd {
	return ccw.CacheCompat.Get(ctx, key)
}

type CacheCompatWrapperIface interface {
	Get(ctx context.Context, key string) *rueidiscompat.StringCmd
}

Working test code snippet,

localCacheClient := mocks.NewCacheCompatWrapperIface(t)

stringCmd := &rueidiscompat.StringCmd{}
stringCmd.SetErr(rueidiscompat.Nil)
RedisClient.On("Cache", 100*time.Millisecond).Return(localCacheClient)
localCacheClient.On("Get", ctx, "key").Return(stringCmd)