authz/loader: fix unused param lint, go mod tidy

Author: birdayz

authz/loader/atomic_rename_test.go

@@ -1,3 +1,12 @@
+// Copyright 2026 Redpanda Data, Inc.
+//
+// Use of this software is governed by the Business Source License
+// included in the file licenses/BSL.md
+//
+// As of the Change Date specified in that file, in accordance with
+// the Business Source License, use of this software will be governed
+// by the Apache License, Version 2.0
+
 package loader_test
 
 import (
@@ -7,10 +16,11 @@ import (
 	"testing"
 	"time"
 
-	"github.com/redpanda-data/common-go/authz"
-	"github.com/redpanda-data/common-go/authz/loader"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/redpanda-data/common-go/authz"
+	"github.com/redpanda-data/common-go/authz/loader"
 )
 
 // TestWatchPolicyFile_AtomicRename reproduces the neovim atomic save pattern

authz/loader/loader_watch_test.go

@@ -80,7 +80,7 @@ func TestWatchUnwatch(t *testing.T) {
 	writeTestPolicy(t, path, 1)
 
 	var calls atomic.Int32
-	policy, unwatch, err := loader.WatchPolicyFile(path, func(p authz.Policy, err error) {
+	policy, unwatch, err := loader.WatchPolicyFile(path, func(_ authz.Policy, _ error) {
 		calls.Add(1)
 	})
 	require.NoError(t, err)

kvstore/client_test.go

@@ -185,11 +185,9 @@ func TestSync_NoSpuriousWakeups(t *testing.T) {
 	// Send broadcasts at intermediate offsets
 	var wg sync.WaitGroup
 	for i := 1; i < 100; i++ {
-		wg.Add(1)
-		go func(offset int) {
-			defer wg.Done()
-			c.setOffset(int64(offset))
-		}(i)
+		wg.Go(func() {
+			c.setOffset(int64(i))
+		})
 	}
 	wg.Wait()
 

kvstore/sync_test.go

@@ -97,15 +97,13 @@ func TestSync_ConcurrentPuts(t *testing.T) {
 	errCount := make(chan struct{}, numWrites)
 
 	for i := 0; i < numWrites; i++ {
-		wg.Add(1)
-		go func(i int) {
-			defer wg.Done()
+		wg.Go(func() {
 			key := []byte(fmt.Sprintf("key-%d", i))
 			value := fmt.Sprintf("value-%d", i)
 			if err := client.Put(ctx, key, []byte(value)); err != nil {
 				errCount <- struct{}{}
 			}
-		}(i)
+		})
 	}
 
 	wg.Wait()
@@ -437,17 +435,15 @@ func TestMultiClient_ConcurrentWrites(t *testing.T) {
 	// Each client writes its own set of keys concurrently
 	var wg sync.WaitGroup
 	for clientID := 0; clientID < numClients; clientID++ {
-		wg.Add(1)
-		go func(clientID int) {
-			defer wg.Done()
+		wg.Go(func() {
 			client := clients[clientID]
 			for i := 0; i < writesPerClient; i++ {
 				key := []byte(fmt.Sprintf("client%d-key%d", clientID, i))
 				value := []byte(fmt.Sprintf("client%d-value%d", clientID, i))
 				err := client.Put(ctx, key, value)
 				require.NoError(t, err)
 			}
-		}(clientID)
+		})
 	}
 
 	wg.Wait()
@@ -579,11 +575,8 @@ func TestSync_StressReadYourOwnWrites(t *testing.T) {
 	var totalOps atomic.Int64
 	var wg sync.WaitGroup
 
-	for p := 0; p < numProducers; p++ {
-		wg.Add(1)
-		go func(producerID int) {
-			defer wg.Done()
-
+	for producerID := 0; producerID < numProducers; producerID++ {
+		wg.Go(func() {
 			// Each producer has its own key - no concurrent writes to same key
 			key := []byte(fmt.Sprintf("producer-%d-key", producerID))
 
@@ -618,7 +611,7 @@ func TestSync_StressReadYourOwnWrites(t *testing.T) {
 
 				totalOps.Add(1)
 			}
-		}(p)
+		})
 	}
 
 	wg.Wait()