Skip to content

Commit b85ff4f

Browse files
EskiMojo14markerikson
authored andcommitted
errorSchema -> errorResponse
1 parent 0b961e2 commit b85ff4f

File tree

4 files changed

+18
-17
lines changed

4 files changed

+18
-17
lines changed

packages/toolkit/src/query/core/buildThunks.ts

+6-5
Original file line numberDiff line numberDiff line change
@@ -745,12 +745,13 @@ export function buildThunks<
745745
endpointDefinition,
746746
'transformErrorResponse',
747747
)
748-
const { rawErrorSchema, errorSchema } = endpointDefinition
748+
const { rawErrorResponseSchema, errorResponseSchema } =
749+
endpointDefinition
749750

750751
let { value, meta } = caughtError
751752

752-
if (rawErrorSchema) {
753-
value = await parseWithSchema(rawErrorSchema, value)
753+
if (rawErrorResponseSchema) {
754+
value = await parseWithSchema(rawErrorResponseSchema, value)
754755
}
755756

756757
if (metaSchema) {
@@ -763,9 +764,9 @@ export function buildThunks<
763764
meta,
764765
arg.originalArgs,
765766
)
766-
if (errorSchema) {
767+
if (errorResponseSchema) {
767768
transformedErrorResponse = await parseWithSchema(
768-
errorSchema,
769+
errorResponseSchema,
769770
transformedErrorResponse,
770771
)
771772
}

packages/toolkit/src/query/endpointDefinitions.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ type EndpointDefinitionWithQuery<
108108
rawResponseSchema?: StandardSchemaV1<BaseQueryResult<BaseQuery>>
109109

110110
/** A schema for the error object returned by the `query` or `queryFn`, *before* it's passed to `transformErrorResponse` */
111-
rawErrorSchema?: StandardSchemaV1<BaseQueryError<BaseQuery>>
111+
rawErrorResponseSchema?: StandardSchemaV1<BaseQueryError<BaseQuery>>
112112
}
113113

114114
type EndpointDefinitionWithQueryFn<
@@ -170,7 +170,7 @@ type EndpointDefinitionWithQueryFn<
170170
transformResponse?: never
171171
transformErrorResponse?: never
172172
rawResponseSchema?: never
173-
rawErrorSchema?: never
173+
rawErrorResponseSchema?: never
174174
}
175175

176176
type BaseEndpointTypes<QueryArg, BaseQuery extends BaseQueryFn, ResultType> = {
@@ -196,7 +196,7 @@ export type BaseEndpointDefinition<
196196
responseSchema?: StandardSchemaV1<ResultType>
197197

198198
/** A schema for the error object returned by the `query` or `queryFn` (including `transformErrorResponse` if provided) */
199-
errorSchema?: StandardSchemaV1<BaseQueryError<BaseQuery>>
199+
errorResponseSchema?: StandardSchemaV1<BaseQueryError<BaseQuery>>
200200

201201
/** A schema for the `meta` property returned by the `query` or `queryFn` */
202202
metaSchema?: StandardSchemaV1<BaseQueryMeta<BaseQuery>>

packages/toolkit/src/query/tests/createApi.test-d.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ describe('type tests', () => {
383383
title: v.string(),
384384
body: v.string(),
385385
}) satisfies v.GenericSchema<Post>
386-
const errorSchema = v.object({
386+
const errorResponseSchema = v.object({
387387
status: v.number(),
388388
data: v.unknown(),
389389
}) satisfies v.GenericSchema<FetchBaseQueryError>
@@ -399,7 +399,7 @@ describe('type tests', () => {
399399
query: ({ id }) => `/post/${id}`,
400400
argSchema,
401401
responseSchema: postSchema,
402-
errorSchema,
402+
errorResponseSchema,
403403
metaSchema,
404404
}),
405405
bothMismatch: build.query<Post, { id: number }>({
@@ -409,7 +409,7 @@ describe('type tests', () => {
409409
// @ts-expect-error wrong schema
410410
responseSchema: v.object({ id: v.string() }),
411411
// @ts-expect-error wrong schema
412-
errorSchema: v.object({ status: v.string() }),
412+
errorResponseSchema: v.object({ status: v.string() }),
413413
// @ts-expect-error wrong schema
414414
metaSchema: v.object({ request: v.string() }),
415415
}),
@@ -425,8 +425,8 @@ describe('type tests', () => {
425425
id: v.pipe(v.string(), v.transform(Number)),
426426
}) satisfies v.GenericSchema<any, Post>,
427427
// @ts-expect-error can't expect different input
428-
errorSchema: v.object({
429-
...errorSchema.entries,
428+
errorResponseSchema: v.object({
429+
...errorResponseSchema.entries,
430430
status: v.pipe(v.string(), v.transform(Number)),
431431
}) satisfies v.GenericSchema<any, FetchBaseQueryError>,
432432
// @ts-expect-error can't expect different input
@@ -450,8 +450,8 @@ describe('type tests', () => {
450450
id: v.pipe(v.number(), v.transform(String)),
451451
}) satisfies v.GenericSchema<Post, any>,
452452
// @ts-expect-error can't provide different output
453-
errorSchema: v.object({
454-
...errorSchema.entries,
453+
errorResponseSchema: v.object({
454+
...errorResponseSchema.entries,
455455
status: v.pipe(v.number(), v.transform(String)),
456456
}) satisfies v.GenericSchema<FetchBaseQueryError, any>,
457457
// @ts-expect-error can't provide different output

packages/toolkit/src/query/tests/createApi.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1266,7 +1266,7 @@ describe('endpoint schemas', () => {
12661266
endpoints: (build) => ({
12671267
query: build.query<{ success: boolean }, void>({
12681268
query: () => '/error',
1269-
rawErrorSchema: v.object({
1269+
rawErrorResponseSchema: v.object({
12701270
status: v.pipe(v.number(), v.minValue(400), v.maxValue(499)),
12711271
data: v.unknown(),
12721272
}),
@@ -1290,7 +1290,7 @@ describe('endpoint schemas', () => {
12901290
data: error,
12911291
error: 'whoops',
12921292
}),
1293-
errorSchema: v.object({
1293+
errorResponseSchema: v.object({
12941294
status: v.literal('CUSTOM_ERROR'),
12951295
error: v.literal('oh no'),
12961296
data: v.unknown(),

0 commit comments

Comments
 (0)