Skip to content

Fix Fast fill error handler #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedromcunha merged 2 commits into from
Jan 30, 2026
Merged

Fix Fast fill error handler #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c50264b
Improve fast fills error handling
pedromcunha Jan 30, 2026
2491134
feat: changeset
pedromcunha Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/full-rooms-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@relayprotocol/relay-sdk': patch
---

Improve fast fills error handling
16 changes: 9 additions & 7 deletions demo/pages/api/fast-fill.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,20 @@ export default async function handler(

return res.status(200).json(fastFillData)
} catch (error: any) {
// Handle APIError from the SDK
if (error.statusCode) {
return res.status(error.statusCode).json({
error: error.message || 'Fast fill failed'
})
return res.status(400).json({
message: error.message || 'Fast fill failed',
code: error?.rawError?.code ?? 'UNKNOWN_ERROR'
} as any)
} else {
throw error
}
throw error
}
} catch (error: any) {
console.error('Fast fill proxy error:', error)
return res.status(500).json({
error: error?.message || 'Internal server error'
})
error: error?.message || 'Internal server error',
code: 'UNKNOWN_ERROR'
} as any)
}
}
14 changes: 7 additions & 7 deletions packages/sdk/src/actions/fastFill.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ export async function fastFill(
data: parameters,
headers: getApiKeyHeader(client)
}

const res = await axios.request(request)
if (res.status !== 200) {
try {
const res = await axios.request(request)
return res.data
} catch (error: any) {
throw new APIError(
res?.data?.error || res?.data?.message,
res.status,
res.data
error?.message || 'Fast fill failed',
error?.statusCode || 500,
error
)
}
return res.data
}
2 changes: 1 addition & 1 deletion packages/sdk/src/utils/axios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ axios.interceptors.response.use(
(error) => {
return Promise.reject(
new APIError(
error.response?.data?.message,
error.response?.data?.message || error.response?.data?.error,
error.response?.data?.statusCode || 500,
{
...error.response?.data,
Expand Down