Skip to content

Commit 991dede

Browse files
committed
[changed] activeRoute is a function that returns null when no child routes are active.
1 parent 2d0fb47 commit 991dede

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

examples/master-detail/app.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ var App = React.createClass({
111111
var contacts = this.state.contacts.map(function(contact) {
112112
return <li key={contact.id}><Link to="contact" id={contact.id}>{contact.first}</Link></li>
113113
});
114-
var content = (this.props.activeRoute) ? this.props.activeRoute() : this.indexTemplate();
115114
return (
116115
<div className="App">
117116
<div className="ContactList">
@@ -121,7 +120,7 @@ var App = React.createClass({
121120
</ul>
122121
</div>
123122
<div className="Content">
124-
{content}
123+
{this.props.activeRoute() || this.indexTemplate()}
125124
</div>
126125
</div>
127126
);

modules/components/Route.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
var React = require('react');
22
var warning = require('react/lib/warning');
33
var invariant = require('react/lib/invariant');
4+
var emptyFunction = require('react/lib/emptyFunction');
45
var ExecutionEnvironment = require('react/lib/ExecutionEnvironment');
56
var mergeProperties = require('../helpers/mergeProperties');
67
var goBack = require('../helpers/goBack');
@@ -426,7 +427,7 @@ function computeHandlerProps(matches, query) {
426427
key: null,
427428
params: null,
428429
query: null,
429-
activeRoute: null
430+
activeRoute: emptyFunction.thatReturnsNull
430431
};
431432

432433
var childHandler;
@@ -443,7 +444,7 @@ function computeHandlerProps(matches, query) {
443444
if (childHandler) {
444445
props.activeRoute = childHandler;
445446
} else {
446-
props.activeRoute = null;
447+
props.activeRoute = emptyFunction.thatReturnsNull;
447448
}
448449

449450
childHandler = function (props, addedProps, children) {

0 commit comments

Comments
 (0)