Skip to content

Commit ae912a6

Browse files
committed
Merge branch 'cody-when'
2 parents 4a770e8 + 5a2c1d9 commit ae912a6

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.jshintrc

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
2+
"asi": true,
23
"eqnull": true,
34
"esnext": true,
45
"unused": "vars",
56
"predef": [ "-Promise" ]
6-
}
7+
}

examples/async-data/app.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
var React = require('react');
22
var Router = require('react-router');
3-
var whenKeys = require('when/keys');
43
var EventEmitter = require('events').EventEmitter;
54
var { Route, DefaultRoute, RouteHandler, Link } = Router;
65

@@ -120,12 +119,13 @@ var routes = (
120119
);
121120

122121
function fetchData(routes, params) {
123-
return whenKeys.all(routes.filter((route) => {
124-
return route.handler.fetchData;
125-
}).reduce((data, route) => {
126-
data[route.name] = route.handler.fetchData(params);
127-
return data;
128-
}, {}));
122+
var data = {};
123+
return Promise.all(routes
124+
.filter(route => route.handler.fetchData)
125+
.map(route => {
126+
return route.handler.fetchData(params).then(d => {data[route.name] = d;});
127+
})
128+
).then(() => data);
129129
}
130130

131131
Router.run(routes, function (Handler, state) {

0 commit comments

Comments
 (0)