fix(webhooks): remove unnecessary code on webhook

Author: tiagomichaelsousa

src/Instances/Webhook.php

@@ -4,38 +4,6 @@
 
 class Webhook extends Instance
 {
-    /**
-     * Get the webhook name.
-     *
-     * @return string
-     */
-    public function getName(): string
-    {
-        return $this->getAttribute('name');
-    }
-
-    /**
-     * Set the webhook name.
-     *
-     * @param  string  $name
-     * @return $this
-     */
-    public function setName(string $name): self
-    {
-        return $this->setAttribute('name', $name);
-    }
-
-    /**
-     * Set the webhook rules.
-     *
-     * @param  array  $rules
-     * @return $this
-     */
-    public function setRules(array $rules = [])
-    {
-        return $this->setAttribute('rules', $rules);
-    }
-
     /**
      * Add a new rule to the webook.
      *
@@ -61,98 +29,4 @@ public function addRules(array $rules)
 
         return $this;
     }
-
-    /**
-     * Get the webhook rules.
-     *
-     * @return array
-     */
-    public function getRules(): array
-    {
-        return $this->getAttribute('rules', []);
-    }
-
-    /**
-     * Get the webhook client config rules.
-     *
-     * @return array
-     */
-    public function getClientConfig(): array
-    {
-        return $this->getAttribute('clientConfig');
-    }
-
-    /**
-     * Set the webhook client config rules.
-     *
-     * @param  array  $clientConfig
-     * @return $this
-     */
-    public function setClientConfig(array $clientConfig): self
-    {
-        return $this->setAttribute('clientConfig', $clientConfig);
-    }
-
-    /**
-     * Get the webhook admission review versions.
-     *
-     * @return array
-     */
-    public function getAdmissionReviewVersions(): array
-    {
-        return $this->getAttribute('admissionReviewVersions');
-    }
-
-    /**
-     * Set the webhook admission review versions.
-     *
-     * @param  array  $admissionReviewVersions
-     * @return $this
-     */
-    public function setAdmissionReviewVersions(array $admissionReviewVersions): self
-    {
-        return $this->setAttribute('admissionReviewVersions', $admissionReviewVersions);
-    }
-
-    /**
-     * Get the webhook side effects.
-     *
-     * @return string
-     */
-    public function getSideEffects(): string
-    {
-        return $this->getAttribute('sideEffects');
-    }
-
-    /**
-     * Set the webhook side effects.
-     *
-     * @param  string  $sideEffects
-     * @return $this
-     */
-    public function setSideEffects(string $sideEffects): self
-    {
-        return $this->setAttribute('sideEffects', $sideEffects);
-    }
-
-    /**
-     * Set the webhook timeout seconds.
-     *
-     * @return int
-     */
-    public function getTimeoutSeconds(): int
-    {
-        return $this->getAttribute('timeoutSeconds');
-    }
-
-    /**
-     * Set the webhook timeout seconds.
-     *
-     * @param  int  $timeoutSeconds
-     * @return $this
-     */
-    public function setTimeoutSeconds(int $timeoutSeconds): self
-    {
-        return $this->setAttribute('timeoutSeconds', $timeoutSeconds);
-    }
 }

tests/ValidatingWebhookConfigurationTest.php

@@ -64,12 +64,14 @@ public function runCreationTests()
     {
         $webhook = K8s::webhook()
             ->setName('v1.webhook.com')
-            ->addRule([
-                'apiGroups' => [''],
-                'apiVersions' => ['v1'],
-                'operations' => ['CREATE'],
-                'resources' => ['pods'],
-                'scope' => 'Namespaced',
+            ->addRules([
+                [
+                    'apiGroups' => [''],
+                    'apiVersions' => ['v1'],
+                    'operations' => ['CREATE'],
+                    'resources' => ['pods'],
+                    'scope' => 'Namespaced',
+                ]
             ])
             ->setClientConfig(['url' => 'https://my-webhook.example.com:9443/my-webhook-path'])
             ->setAdmissionReviewVersions(['v1', 'v1beta'])