renovate try to install package in submodule as workspace package

[trim21]

How are you running Renovate?

A Mend.io-hosted app

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

I have a project with such files:

package.json
pnpm-lock.yaml

vendor/common(a git submodule)
  vendor/common/package.json
  vendor/common/yarn.lock

here vendor/common/package.json has nothing to do with current project, it's not a monorepo. it only contains some deps like prettier to format code inside submodule.

When renovate try to update package from /package.json, somehow it want to install project vendor/common:

(it's not 100% reproducible, this error disappear with rebase/retry, so maybe another problem is that we checkout submodule in one branch but didn't remove it in another branch)

But when I use pr checkbox to trigger it again, this error disappear

Logs (if relevant)

Logs

{"name":"renovate","hostname":"jr-microvm","pid":863,"level":20,"logContext":"ud1L8BD1fSX_99e8N2x2s","repository":"bangumi/server-private","branch":"renovate/deps","command":"pnpm install --recursive --lockfile-only --ignore-scripts --ignore-pnpmfile","msg":"Executing command","time":"2025-03-09T21:48:34.342Z","v":0}
{"name":"renovate","hostname":"jr-microvm","pid":863,"level":20,"logContext":"ud1L8BD1fSX_99e8N2x2s","repository":"bangumi/server-private","branch":"renovate/deps","err":{"cmd":"/bin/sh -c pnpm install --recursive --lockfile-only --ignore-scripts --ignore-pnpmfile","stderr":"","stdout":"Scope: all 2 projects\nProgress: resolved 1, reused 0, downloaded 0, added 0\nvendor/common                            | Progress: resolved 1, reused 0, downloaded 0, added 0\nundefined\n/tmp/renovate/repos/github/bangumi/server-private/vendor/common:\n ERR_PNPM_PATCH_NOT_APPLIED  The following patches were not applied: fastify-socket.io\n\nEither remove them from \"patchedDependencies\" or update them to match packages in your dependencies.\n","options":{"cwd":"/tmp/renovate/repos/github/bangumi/server-private","encoding":"utf-8","env":{"NPM_CONFIG_CACHE":"/runner/cache/others/npm","npm_config_store":"/runner/cache/others/pnpm","HOME":"/home/ubuntu","PATH":"/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin","LC_ALL":"C.UTF-8","LANG":"C.UTF-8","CONTAINERBASE_CACHE_DIR":"/runner/cache/containerbase"},"maxBuffer":10485760,"timeout":900000},"exitCode":1,"name":"ExecError","message":"Command failed: pnpm install --recursive --lockfile-only --ignore-scripts --ignore-pnpmfile\n","stack":"ExecError: Command failed: pnpm install --recursive --lockfile-only --ignore-scripts --ignore-pnpmfile\n\n    at ChildProcess.<anonymous> (/usr/local/renovate/lib/util/exec/common.ts:119:11)\n    at ChildProcess.emit (node:events:530:35)\n    at ChildProcess.emit (node:domain:489:12)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)"},"durationMs":1649,"msg":"rawExec err","time":"2025-03-09T21:48:36.001Z","v":0}

[trim21]

I think we use wrong command here: pnpm install --recursive, when a project is not a workspace, it should not enable --recursive flag

renovate/lib/modules/manager/npm/post-update/pnpm.ts

Line 73 in d0fb3b7

let args = '--recursive --lockfile-only';

we should only add --recursive flag when pnpm-workspace.yaml file exists

a example repo: https://github.com/trim21/renovate-bug-34718

trim21/renovate-bug-34718#1