requested changes

Author: aspeddro

pages/docs/react/latest/forwarding-refs.mdx

@@ -59,9 +59,7 @@ let make = () => {
   let input = React.useRef(Nullable.null)
 
   let focusInput = () =>
-    input.current
-    ->Nullable.toOption
-    ->Option.forEach(input => input->focus)
+    input.current->Nullable.forEach(input => input->focus)
 
   let onClick = _ => focusInput()
 

pages/docs/react/latest/hooks-ref.mdx

@@ -59,9 +59,7 @@ let make = () => {
   let inputEl = React.useRef(Nullable.null)
 
   let onClick = _ => {
-    inputEl.current
-    ->Nullable.toOption
-    ->Option.forEach(input => input->focus)
+    inputEl.current->Nullable.forEach(input => input->focus)
   }
 
   <>
@@ -75,13 +73,12 @@ let make = () => {
 function TextInputWithFocusButton(Props) {
   var inputEl = React.useRef(null);
   var onClick = function (param) {
-    return Belt_Option.forEach(Caml_option.nullable_to_opt(inputEl.current), (function (input) {
-                  input.focus();
-
-                }));
+    Core__Nullable.forEach(inputEl.current, (function (input) {
+            input.focus();
+          }));
   };
-  return React.createElement(React.Fragment, undefined, React.createElement("input", {
-                  ref: inputEl,
+  return React.createElement(React.Fragment, {}, React.createElement("input", {
+                  ref: Caml_option.some(inputEl),
                   type: "text"
                 }), React.createElement("button", {
                   onClick: onClick
@@ -110,9 +107,7 @@ let make = () => {
   }
 
   let focusTextInput = _ => {
-    textInput.current
-    ->Nullable.toOption
-    ->Option.forEach(input => input->focus)
+    textInput.current->Nullable.forEach(input => input->focus)
   }
 
   <div>
@@ -129,16 +124,14 @@ function CustomTextInput(Props) {
   var textInput = React.useRef(null);
   var setTextInputRef = function (element) {
     textInput.current = element;
-
   };
   var focusTextInput = function (param) {
-    return Belt_Option.forEach(Caml_option.nullable_to_opt(textInput.current), (function (input) {
-                  input.focus();
-
-                }));
+    Core__Nullable.forEach(textInput.current, (function (input) {
+            input.focus();
+          }));
   };
   return React.createElement("div", undefined, React.createElement("input", {
-                  ref: setTextInputRef,
+                  ref: Caml_option.some(setTextInputRef),
                   type: "text"
                 }), React.createElement("input", {
                   type: "button",

pages/docs/react/latest/refs-and-the-dom.mdx

@@ -86,9 +86,9 @@ let make = () => {
   let textInput = React.useRef(Nullable.null)
 
   let focusInput = () =>
-    switch textInput.current->Nullable.toOption {
-    | Some(dom) => dom->focus
-    | None => ()
+    switch textInput.current {
+    | Value(dom) => dom->focus
+    | Null | Undefined => ()
     }
 
   let onClick = _ => focusInput()
@@ -103,22 +103,29 @@ let make = () => {
 ```js
 function CustomTextInput(Props) {
   var textInput = React.useRef(null);
-  var onClick = function (param) {
+  var focusInput = function () {
     var dom = textInput.current;
-    if (!(dom == null)) {
-      dom.focus();
+    if (dom === null || dom === undefined) {
       return ;
     }
-
+    dom.focus();
   };
-  return React.createElement("div", undefined, React.createElement("input", {
-                  ref: textInput,
-                  type: "text"
-                }), React.createElement("input", {
-                  type: "button",
-                  value: "Focus the text input",
-                  onClick: onClick
-                }));
+  var onClick = function (param) {
+    focusInput();
+  };
+  return JsxRuntime.jsxs("div", {
+              children: [
+                JsxRuntime.jsx("input", {
+                      ref: Caml_option.some(textInput),
+                      type: "text"
+                    }),
+                JsxRuntime.jsx("input", {
+                      type: "button",
+                      value: "Focus the text input",
+                      onClick: onClick
+                    })
+              ]
+            });
 }
 ```
 
@@ -199,9 +206,7 @@ let make = () => {
   }
 
   let focusTextInput = _ => {
-    textInput.current
-    ->Nullable.toOption
-    ->Option.forEach(input => input->focus)
+    textInput.current->Nullable.forEach(input => input->focus)
   }
 
   <div>
@@ -218,16 +223,14 @@ function CustomTextInput(Props) {
   var textInput = React.useRef(null);
   var setTextInputRef = function (element) {
     textInput.current = element;
-
   };
   var focusTextInput = function (param) {
-    return Belt_Option.forEach(Caml_option.nullable_to_opt(textInput.current), (function (input) {
-                  input.focus();
-
-                }));
+    Core__Nullable.forEach(textInput.current, (function (input) {
+            input.focus();
+          }));
   };
   return React.createElement("div", undefined, React.createElement("input", {
-                  ref: setTextInputRef,
+                  ref: Caml_option.some(setTextInputRef),
                   type: "text"
                 }), React.createElement("input", {
                   type: "button",

src/ApiDocs.res

@@ -223,7 +223,7 @@ module SidebarTree = {
         </div>
         <div className="hl-overline text-gray-80 mt-5 mb-2"> {"submodules"->React.string} </div>
         {node.children
-        ->Belt.SortArray.stableSortBy((v1, v2) => v1.name > v2.name ? 1 : -1)
+        ->Array.toSorted((v1, v2) => String.compare(v1.name, v2.name))
         ->Array.map(renderNode)
         ->React.array}
       </aside>

src/Packages.res

@@ -100,7 +100,7 @@ module Resource = {
 
     fuser
     ->Fuse.search(pattern)
-    ->Belt.SortArray.stableSortBy((a, b) => a["item"].searchScore > b["item"].searchScore ? -1 : 1)
+    ->Array.toSorted((a, b) => Float.compare(a["item"].searchScore, b["item"].searchScore))
   }
 
   let applyUrlResourceSearch = (urls: array<urlResource>, pattern: string): array<

src/components/SearchBox.res

@@ -29,9 +29,8 @@ let make = (
 
   let onAreaFocus = evt => {
     let el = ReactEvent.Focus.target(evt)
-    // TODO(aspeddro)
-    // let isDiv = Js.Null_undefined.isNullable(el["type"])
-    let isDiv = Nullable.toOption(el["type"])->Option.isSome
+    // TODO(aspeddro): Replace with `Nullable.isNullable` when Core merge https://github.com/rescript-association/rescript-core/pull/227 and publish a new release
+    let isDiv = Js.Null_undefined.isNullable(el["type"])
 
     if isDiv && state === Inactive {
       focusInput()