Skip to content

No-op to idempotency table when table is empty on boot #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slinkydeveloper opened this issue Mar 24, 2025 · 1 comment · May be fixed by #3011
Open

No-op to idempotency table when table is empty on boot #2983

slinkydeveloper opened this issue Mar 24, 2025 · 1 comment · May be fixed by #3011
Labels
good first issue Good for newcomers performance Performance tasks rocksdb

Comments

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Mar 24, 2025

Completely disable codepaths using IdempotencyTable when the key space of idempotency table is empty. We can do so because in the next release, no one will write to the idempotency table key space anymore, so if the table is empty will remain empty for the rest of the execution.

We can probably add a check for that when initializing the PartitionStore.

Essentially like #2186 for idempotency table

@zhaohaidao
Copy link
Contributor

If no one is solving it, I'd like to try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers performance Performance tasks rocksdb
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants