Add an integration test that runs on JDK-8 (opensearch-project#795)

reta · web-flow · commit f8ec75e23762 · 2024-01-03T16:18:05.000-05:00
* Add an integration test that runs on JDK-8

Signed-off-by: Andriy Redko &lt;andriy.redko@aiven.io&gt;

* Refactor the runtime Java selection

Signed-off-by: Andriy Redko &lt;andriy.redko@aiven.io&gt;

---------

Signed-off-by: Andriy Redko &lt;andriy.redko@aiven.io&gt;
diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml
@@ -7,7 +7,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        java: [ 11, 17, 21 ]
+        java: [ 8, 11, 17, 21 ]
         os: [ubuntu-latest, windows-latest, macOS-latest]
     steps:
       - name: Checkout Java Client
@@ -21,4 +21,17 @@ jobs:
           cache: 'gradle'
 
       - name: Run Unit Test
+        if: ${{ matrix.java != 8 }}
         run: ./gradlew clean unitTest
+
+      - name: Set up JDK 11
+        uses: actions/setup-java@v3
+        if: ${{ matrix.java == 8 }}
+        with:
+          java-version: 11
+          distribution: 'temurin'
+          cache: 'gradle'
+
+      - name: Run Unit Test
+        if: ${{ matrix.java == 8 }}
+        run: ./gradlew clean unitTest -D"runtime.java=8"
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -49,6 +49,7 @@ This section is for maintaining a changelog for all breaking changes for the cli
 
 ### Changed
 - Restore support for Java 8 ([#767](https://github.com/opensearch-project/opensearch-java/pull/767))
+- Add an integration test that runs on JDK-8 ([#795](https://github.com/opensearch-project/opensearch-java/pull/795))
 
 ### Deprecated
 - Deprecated "_toQuery()" in Query and QueryVariant ([#760](https://github.com/opensearch-project/opensearch-java/pull/760)
diff --git a/java-client/build.gradle.kts b/java-client/build.gradle.kts
@@ -32,6 +32,7 @@
 
 import com.github.jk1.license.ProjectData
 import com.github.jk1.license.render.ReportRenderer
+import org.gradle.api.tasks.testing.Test
 import java.io.FileWriter
 
 buildscript {
@@ -63,6 +64,12 @@ configurations {
     }
 }
 
+val runtimeJavaVersion = (System.getProperty("runtime.java")?.toInt())?.let(JavaVersion::toVersion) ?: JavaVersion.current()
+logger.quiet("=======================================")
+logger.quiet("  Runtime JDK Version   : " + runtimeJavaVersion)
+logger.quiet("  Gradle JDK Version    : " + JavaVersion.current())
+logger.quiet("=======================================")
+
 java {
     targetCompatibility = JavaVersion.VERSION_1_8
     sourceCompatibility = JavaVersion.VERSION_1_8
@@ -73,6 +80,11 @@ java {
     registerFeature("awsSdk2Support") {
         usingSourceSet(sourceSets.get("main"))
     }
+    
+    toolchain {
+      languageVersion = JavaLanguageVersion.of(runtimeJavaVersion.majorVersion)
+      vendor = JvmVendorSpec.ADOPTIUM
+    }
 }
 
 tasks.withType<ProcessResources> {
@@ -337,7 +349,7 @@ publishing {
     }
 }
 
-if (JavaVersion.current() >= JavaVersion.VERSION_11) {
+if (runtimeJavaVersion >= JavaVersion.VERSION_11) {
   val java11: SourceSet = sourceSets.create("java11") {
     java {
       compileClasspath += sourceSets.main.get().output + sourceSets.test.get().output
@@ -369,5 +381,4 @@ if (JavaVersion.current() >= JavaVersion.VERSION_11) {
     testClassesDirs += java11.output.classesDirs
     classpath = sourceSets["java11"].runtimeClasspath
   }
- 
 }
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/GeoDistanceQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/GeoDistanceQueryTest.java
@@ -1,6 +1,6 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch._types.GeoLocation;
 import org.opensearch.client.opensearch.model.ModelTestCase;
@@ -9,7 +9,7 @@ public class GeoDistanceQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         GeoDistanceQuery origin = new GeoDistanceQuery.Builder().field("field")
-            .location(new GeoLocation.Builder().coords(List.of(1.0)).build())
+            .location(new GeoLocation.Builder().coords(Collections.singletonList(1.0)).build())
             .build();
         GeoDistanceQuery copied = origin.toBuilder().build();
 
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/PinnedQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/PinnedQueryTest.java
@@ -1,14 +1,14 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch._types.FieldValue;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class PinnedQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
-        PinnedQuery origin = new PinnedQuery.Builder().organic(buildDummyQuery()).ids(List.of("1")).build();
+        PinnedQuery origin = new PinnedQuery.Builder().organic(buildDummyQuery()).ids(Collections.singletonList("1")).build();
         PinnedQuery copied = origin.toBuilder().build();
 
         assertEquals(toJson(copied), toJson(origin));
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanContainingQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanContainingQueryTest.java
@@ -1,15 +1,15 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanContainingQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         SpanContainingQuery origin = new SpanContainingQuery.Builder().big(
-            new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build()
-        ).little(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build()).build();
+            new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()
+        ).little(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()).build();
         SpanContainingQuery copied = origin.toBuilder().build();
 
         assertEquals(toJson(copied), toJson(origin));
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanFieldMaskingQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanFieldMaskingQueryTest.java
@@ -1,14 +1,14 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanFieldMaskingQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         SpanFieldMaskingQuery origin = new SpanFieldMaskingQuery.Builder().field("field")
-            .query(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build())
+            .query(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build())
             .build();
         SpanFieldMaskingQuery copied = origin.toBuilder().build();
 
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanFirstQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanFirstQueryTest.java
@@ -1,14 +1,14 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanFirstQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         SpanFirstQuery origin = new SpanFirstQuery.Builder().end(1)
-            .match(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build())
+            .match(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build())
             .build();
         SpanFirstQuery copied = origin.toBuilder().build();
 
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanNearQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanNearQueryTest.java
@@ -1,14 +1,16 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanNearQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         SpanNearQuery origin = new SpanNearQuery.Builder().clauses(
-            List.of(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build())
+            Collections.singletonList(
+                new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()
+            )
         ).build();
         SpanNearQuery copied = origin.toBuilder().build();
 
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanNotQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanNotQueryTest.java
@@ -1,15 +1,15 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanNotQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         SpanNotQuery origin = new SpanNotQuery.Builder().include(
-            new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build()
-        ).exclude(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build()).build();
+            new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()
+        ).exclude(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()).build();
         SpanNotQuery copied = origin.toBuilder().build();
 
         assertEquals(toJson(copied), toJson(origin));
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanOrQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanOrQueryTest.java
@@ -1,14 +1,16 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanOrQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         SpanOrQuery origin = new SpanOrQuery.Builder().clauses(
-            List.of(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build())
+            Collections.singletonList(
+                new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()
+            )
         ).build();
         SpanOrQuery copied = origin.toBuilder().build();
 
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanQueryTest.java
@@ -1,13 +1,13 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
-        SpanQuery origin = new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build();
+        SpanQuery origin = new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build();
         SpanQuery copied = origin.toBuilder().build();
 
         assertEquals(toJson(copied), toJson(origin));
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanWithinQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/SpanWithinQueryTest.java
@@ -1,15 +1,15 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class SpanWithinQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         SpanWithinQuery origin = new SpanWithinQuery.Builder().big(
-            new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build()
-        ).little(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(List.of()).build()).build()).build();
+            new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()
+        ).little(new SpanQuery.Builder().spanOr(new SpanOrQuery.Builder().clauses(Collections.emptyList()).build()).build()).build();
         SpanWithinQuery copied = origin.toBuilder().build();
 
         assertEquals(toJson(copied), toJson(origin));
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/TermsQueryFieldTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/TermsQueryFieldTest.java
@@ -1,14 +1,14 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch._types.FieldValue;
 import org.opensearch.client.opensearch.model.ModelTestCase;
 
 public class TermsQueryFieldTest extends ModelTestCase {
     @Test
     public void toBuilder() {
-        TermsQueryField origin = new TermsQueryField.Builder().value(List.of(FieldValue.of("1"))).build();
+        TermsQueryField origin = new TermsQueryField.Builder().value(Collections.singletonList(FieldValue.of("1"))).build();
         TermsQueryField copied = origin.toBuilder().build();
 
         assertEquals(toJson(copied), toJson(origin));
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/TermsQueryTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/_types/query_dsl/TermsQueryTest.java
@@ -1,6 +1,6 @@
 package org.opensearch.client.opensearch._types.query_dsl;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Test;
 import org.opensearch.client.opensearch._types.FieldValue;
 import org.opensearch.client.opensearch.model.ModelTestCase;
@@ -9,7 +9,7 @@ public class TermsQueryTest extends ModelTestCase {
     @Test
     public void toBuilder() {
         TermsQuery origin = new TermsQuery.Builder().field("field")
-            .terms(new TermsQueryField.Builder().value(List.of(FieldValue.of("1"))).build())
+            .terms(new TermsQueryField.Builder().value(Collections.singletonList(FieldValue.of("1"))).build())
             .build();
         TermsQuery copied = origin.toBuilder().build();
 
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/core/BulkRequestTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/core/BulkRequestTest.java
@@ -1,6 +1,6 @@
 package org.opensearch.client.opensearch.core;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Assert;
 import org.junit.Test;
 import org.opensearch.client.opensearch.core.bulk.BulkOperation;
@@ -11,7 +11,9 @@ public class BulkRequestTest extends Assert {
     @Test
     public void toBuilder() {
         BulkRequest origin = new BulkRequest.Builder().index("index")
-            .operations(List.of(new BulkOperation.Builder().delete(new DeleteOperation.Builder().id("id").build()).build()))
+            .operations(
+                Collections.singletonList(new BulkOperation.Builder().delete(new DeleteOperation.Builder().id("id").build()).build())
+            )
             .build();
         BulkRequest copied = origin.toBuilder().build();
 
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/core/ClearScrollRequestTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/core/ClearScrollRequestTest.java
@@ -1,14 +1,14 @@
 package org.opensearch.client.opensearch.core;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Assert;
 import org.junit.Test;
 
 public class ClearScrollRequestTest extends Assert {
 
     @Test
     public void toBuilder() {
-        ClearScrollRequest origin = new ClearScrollRequest.Builder().scrollId(List.of("1")).build();
+        ClearScrollRequest origin = new ClearScrollRequest.Builder().scrollId(Collections.singletonList("1")).build();
         ClearScrollRequest copied = origin.toBuilder().build();
 
         assertEquals(copied.scrollId(), origin.scrollId());
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/core/MsearchRequestTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/core/MsearchRequestTest.java
@@ -1,14 +1,14 @@
 package org.opensearch.client.opensearch.core;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Assert;
 import org.junit.Test;
 
 public class MsearchRequestTest extends Assert {
 
     @Test
     public void toBuilder() {
-        MsearchRequest origin = new MsearchRequest.Builder().index("index").searches(List.of()).build();
+        MsearchRequest origin = new MsearchRequest.Builder().index("index").searches(Collections.emptyList()).build();
         MsearchRequest copied = origin.toBuilder().build();
 
         assertEquals(copied.index(), origin.index());
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/core/MsearchTemplateRequestTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/core/MsearchTemplateRequestTest.java
@@ -1,14 +1,16 @@
 package org.opensearch.client.opensearch.core;
 
-import java.util.List;
+import java.util.Collections;
 import org.junit.Assert;
 import org.junit.Test;
 
 public class MsearchTemplateRequestTest extends Assert {
 
     @Test
     public void toBuilder() {
-        MsearchTemplateRequest origin = new MsearchTemplateRequest.Builder().index("index").searchTemplates(List.of()).build();
+        MsearchTemplateRequest origin = new MsearchTemplateRequest.Builder().index("index")
+            .searchTemplates(Collections.emptyList())
+            .build();
         MsearchTemplateRequest copied = origin.toBuilder().build();
 
         assertEquals(copied.index(), origin.index());
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/core/PutIndexTemplateRequestTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/core/PutIndexTemplateRequestTest.java
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/core/RankEvalRequestTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/core/RankEvalRequestTest.java
diff --git a/java-client/src/test/java/org/opensearch/client/opensearch/core/search/InnerHitsTest.java b/java-client/src/test/java/org/opensearch/client/opensearch/core/search/InnerHitsTest.java
diff --git a/settings.gradle.kts b/settings.gradle.kts

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@`
`32`	`32`
`33`	`33`	`import com.github.jk1.license.ProjectData`
`34`	`34`	`import com.github.jk1.license.render.ReportRenderer`
	`35`	`+import org.gradle.api.tasks.testing.Test`
`35`	`36`	`import java.io.FileWriter`
`36`	`37`
`37`	`38`	`buildscript {`
`@@ -63,6 +64,12 @@ configurations {`
`63`	`64`	`}`
`64`	`65`	`}`
`65`	`66`
	`67`	`+val runtimeJavaVersion = (System.getProperty("runtime.java")?.toInt())?.let(JavaVersion::toVersion) ?: JavaVersion.current()`
	`68`	`+logger.quiet("=======================================")`
	`69`	`+logger.quiet(" Runtime JDK Version : " + runtimeJavaVersion)`
	`70`	`+logger.quiet(" Gradle JDK Version : " + JavaVersion.current())`
	`71`	`+logger.quiet("=======================================")`
	`72`	`+`
`66`	`73`	`java {`
`67`	`74`	`targetCompatibility = JavaVersion.VERSION_1_8`
`68`	`75`	`sourceCompatibility = JavaVersion.VERSION_1_8`
`@@ -73,6 +80,11 @@ java {`
`73`	`80`	`registerFeature("awsSdk2Support") {`
`74`	`81`	`usingSourceSet(sourceSets.get("main"))`
`75`	`82`	`}`
	`83`	`+`
	`84`	`+ toolchain {`
	`85`	`+ languageVersion = JavaLanguageVersion.of(runtimeJavaVersion.majorVersion)`
	`86`	`+ vendor = JvmVendorSpec.ADOPTIUM`
	`87`	`+ }`
`76`	`88`	`}`
`77`	`89`
`78`	`90`	`tasks.withType<ProcessResources> {`
`@@ -337,7 +349,7 @@ publishing {`
`337`	`349`	`}`
`338`	`350`	`}`
`339`	`351`
`340`		`-if (JavaVersion.current() >= JavaVersion.VERSION_11) {`
	`352`	`+if (runtimeJavaVersion >= JavaVersion.VERSION_11) {`
`341`	`353`	`val java11: SourceSet = sourceSets.create("java11") {`
`342`	`354`	`java {`
`343`	`355`	`compileClasspath += sourceSets.main.get().output + sourceSets.test.get().output`
`@@ -369,5 +381,4 @@ if (JavaVersion.current() >= JavaVersion.VERSION_11) {`
`369`	`381`	`testClassesDirs += java11.output.classesDirs`
`370`	`382`	`classpath = sourceSets["java11"].runtimeClasspath`
`371`	`383`	`}`
`372`		`-`
`373`	`384`	`}`