Invalid indentaion

[zdm]

Hi,

Multiline command indentation is broken.

Result:

RUN \
 # install dependencies
 NODE_ENV=production npm install-clean \
 # cleanup
 && /usr/bin/env bash <(curl -fsSL https://raw.githubusercontent.com/softvisio/scripts/main/env-build-node.sh) cleanup

I have 4 spaces indentation configured, but it always make 1 space indent, which is not very readable.

Link to the original issue: un-ts/prettier#441 (comment)

[reteps]

What is your dockerfmt version and invocation?

[reteps]

This report is not consistent with my test suite output from 0.3.4. https://github.com/reteps/dockerfmt/blob/main/tests/out/run5.dockerfile

[zdm]

dockerfmt: v0.3.2

[zdm]

Invoked from the prettier-plugin-sh, I don't know details.

[reteps]

You need dockerfmt 0.3.4. It should be published.

[zdm]

Not published yet, will wait.

[reteps]

What leads you to believe it isn't published? You should double check whatever you are claiming before you write it...

[reteps]

https://www.npmjs.com/package/@reteps/dockerfmt/v/0.3.4

[zdm]

npm up doesn't install latest version

[reteps]

I cannot reproduce. I made an empty repo, and did npm i prettier-plugin-sh. It used 0.3.4.

[zdm]

With v0.3.4 result is the same, indented with 1 space, ingoting settings.

[reteps]

If you want to report a bug in the JS formatter wrapper, please report it there. If you want to report a bug in the golang parser, please show your dockerfmt version and invocation. That is, invoke the go binary on the command line.

[JounQin]

@reteps

@reteps/dockerfmt v0.3.4

import { formatDockerfileContents } from '@reteps/dockerfmt'

console.log(
  await formatDockerfileContents(
    `
RUN \
    # install dependencies
    NODE_ENV=production npm install-clean \
    \
    # cleanup
    && /usr/bin/env bash <(curl -fsSL https://raw.githubusercontent.com/softvisio/scripts/main/env-build-node.sh) cleanup
`.trim(),
    {
      indent: 4,
      spaceRedirects: false,
      trailingNewline: true,
    },
  ),
)

Output:

RUN \
 # install dependencies

[reteps]

@reteps

@reteps/dockerfmt v0.3.4

import { formatDockerfileContents } from '@reteps/dockerfmt'

console.log(
await formatDockerfileContents(
RUN \ # install dependencies NODE_ENV=production npm install-clean \ \ # cleanup && /usr/bin/env bash <(curl -fsSL https://raw.githubusercontent.com/softvisio/scripts/main/env-build-node.sh) cleanup.trim(),
{
indent: 4,
spaceRedirects: false,
trailingNewline: true,
},
),
)
Output:

RUN \

install dependencies

I can't replicate this -- can you show the bug as replicated on the CLI?

[zdm]

In 0.3.5 bug still exists.
The code above reproduces the issue.

[reteps]

If you want to report a bug in the JS formatter wrapper, please report it there. If you want to report a bug in the golang parser, please show your dockerfmt version and invocation. That is, invoke the go binary on the command line.

[JounQin]

I can't replicate this -- can you show the bug as replicated on the CLI?

@reteps What do you mean? I'm using the js API, not CLI? Isn't it the WASM/js library you provided?

[reteps]

I can't replicate this -- can you show the bug as replicated on the CLI?

What do you mean? I'm using the js API, not CLI?

It's hard for me to tell if this is a bug in the JS API or in the internal golang formatter. If I can replicate through the CLI, I can fix the issue much easier.

[reteps]

If there is a difference in behavior between the WASM library and the golang library, then potentially there is an issue in the WASM bindings.

[JounQin]

Then it's an issue from the js/wasm API? For example, byte size, etc.

[reteps]

If you can't replicate it via the CLI, then it must be an issue with the wasm API.

[JounQin]

If you can't replicate it via the CLI, then it must be an issue with the wasm API.

@reteps Yes, then are we going to resolve the WASM API issue here?

[zdm]

Possible to fix this? Does any help needed?

[reteps]

Help is wanted; this seems related to #25 as well. They are both JS WASM issues that I don't have a clear solution for.

[zdm]

I don't understand anything in go. ((
Can help with js and testing.