Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 7 always added jQuery and jQuery.once to the page #22

Open
mglaman opened this issue Jul 5, 2023 · 2 comments
Open

Drupal 7 always added jQuery and jQuery.once to the page #22

mglaman opened this issue Jul 5, 2023 · 2 comments

Comments

@mglaman
Copy link
Collaborator

mglaman commented Jul 5, 2023

No description provided.

@mglaman mglaman added this to the Asset libraries milestone Jul 14, 2023
@damienmckenna
Copy link

An initial task could be to just add documentation about this for when people are adding custom JS files to a new library.

@mglaman
Copy link
Collaborator Author

mglaman commented Oct 19, 2023

That is true. One idea I had was to have https://github.com/retrofit-drupal/retrofit/blob/main/src/Render/AttachmentResponseSubscriber.php always add the libraries (doesn't fix the fact jQuery.once is removed)

If folks wanted to disable this feature, there can be a service parameter to stop it from being added. So sites/default/services.yml could control how Retrofit works in this regard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants