build: Fix thinko, don't create CSV export from GitHub Actions

Commit 911d995 was misguided in the
sense that `continue-on-error: true` of course causes the report file
to be generated, but it also doesn't fail the build — and thus we
wouldn't be getting a notification if we had dead links on the site.

That's clearly not intentional, so drop CSV file generation from
`.linkcheckerrc`, and also remove the artifact upload step from the
`check` job. Instead, rely on the GitHub Actions job log to discern
which links are dead.

Getting a CSV file with a full report is still an option, when
running from a local checkout:

    tox -e check -- -F csv

Substitute other `-F` options like `html` or `xml` as needed.

References:
https://linkchecker.github.io/linkchecker/man/linkchecker.html#cmdoption-F
https://linkchecker.github.io/linkchecker/man/linkchecker.html#output-types

Author: fghaas

.github/workflows/check.yml

@@ -12,15 +12,9 @@ jobs:
       - name: Install Python dependencies
         run: |
           pip install tox
-      - continue-on-error: true
-        name: Test with tox
+      - name: Test with tox
         run: |
           tox -e check
-      - name: Upload link check report
-        uses: actions/upload-artifact@v3
-        with:
-          name: check-${{ github.sha }}
-          path: linkchecker-out.csv
 
 name: 'Check links'
 

.gitignore

@@ -3,4 +3,4 @@
 site/
 .cache/
 .tox/
-linkchecker-out.csv
+linkchecker-out.*

.linkcheckerrc

@@ -11,8 +11,3 @@ checkextern=1
 ignore =
   .*github\.com.*/edit/.*
   .*localhost.*
-
-[output]
-# Create a CSV file containing all checked links, which can be
-# processed as a build artifact.
-fileoutput=csv

tox.ini

@@ -39,7 +39,7 @@ commands =
 [testenv:check]
 deps = linkchecker
 commands =
-  linkchecker -f .linkcheckerrc https://docs.cleura.cloud/sitemap.xml
+  linkchecker -f .linkcheckerrc {posargs} https://docs.cleura.cloud/sitemap.xml
 
 [testenv:deploy-github]
 passenv =