### Quality Control Improvements for Update v0.9.0:

- QC: Improved formatting and representation of different units in the converter commands.
- QC: Fixed issue where in the Horsepower to Kilowatts converter, the inputted horsepower value would be the same as the outputted kilowatts value.
- QC: In a couple of converters in the Converter command, an issue was fixed where inputted values would be converted to whole numbers instead of being accepted as a floating-point number. Fixed by using NumInputld() instead of NumInputll().
- QC: Fixed an issue in the RandNum command, where when the -f argument is specified, a whole number is still calculated instead of a floating-point.
- QC: Improved formatting of the help page of the Title command.
- QC: Changed max character limit from 256 characters to 254 characters in the Title command, to comply with the Window Title ANSI Escape Sequence limit.
- QC: Fixed a bug where supplying no data string arguments to a ToFile-enabled command would cause UB across the entire program.
- QC: When the ToFile feature is enabled, the std::cerr stream will redirect to the set file now, along with std::cout.

Author: rforzachamp821

CommandFiles/CommandHelpMessages.cpp

@@ -218,12 +218,12 @@ namespace helpmsgs
 		colourSubheading();
 		std::cout << "What this command does:" << NOULINE_STR;
 		colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
-		std::cout << wordWrap("\n- This command allows you to set the title of this window, which is the window running ZeeTerminal.\n- The title can only be a maximum of 256 characters.\n\n");
+		std::cout << wordWrap("\n- This command allows you to set the title of this window, which is the window running ZeeTerminal.\n- The title can only be a maximum of 254 characters.\n\n");
 
 		colourSubheading();
 		std::cout << "Possible arguments for this command:" << NOULINE_STR;
 		colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
-		std::cout << wordWrap("\n -h\tDisplays this help message.\n <title>\tThe title to set. Put the title in place of <title>.\n\nExample: title \"Test Title\"\n\nNOTE: If the title contains spaces, use quotes like the example.\n\n");
+		std::cout << wordWrap("\n -h\t\tDisplays this help message.\n <title>\tThe title to set. Put the title in place of <title>.\n\nExample: title \"Test Title\"\n\nNOTE: If the title contains spaces, use quotes like the example.\n\n");
 
 		return;
 	}

CommandFiles/CommandsFiles/CommandsFile_1to10.cpp

@@ -965,7 +965,7 @@ bool commands::Commands1To10(const std::string sCommand, char* cCommandArgs, con
 			std::cout << "\n";
 
 			// Take title input
-			sTitle = StrInput("Please input your desired title (256 characters max): > ");
+			sTitle = StrInput("Please input your desired title (254 characters max): > ");
 		}
 
 		// Set the window title
@@ -976,7 +976,7 @@ bool commands::Commands1To10(const std::string sCommand, char* cCommandArgs, con
 		}
 		else {
 			// Failed - too long of a string
-			UserErrorDisplay("Setting console window title failed!\nPlease check if your title is too long. It cannot be longer than 256 characters.\n");
+			UserErrorDisplay("Setting console window title failed!\nPlease check if your title is too long. It cannot be longer than 254 characters.\n");
 		}
 
 		return true;

CommandFiles/CommandsFiles/CommandsFile_61to70.cpp

@@ -272,8 +272,8 @@ bool commands::Commands61To70(const std::string sCommand, char* cCommandArgs, co
 	// RandNum
 	else if (sCommand == "randnum" || sCommand == "62") {
 		bool bCalculateFloatingPoint = false;
-		int64_t nMaxNumber = 0;
-		int64_t nMinNumber = 0;
+		long double nMaxNumber = 0;
+		long double nMinNumber = 0;
 		bool bFromArgument = false;
 
 		// Arguments Interface
@@ -285,16 +285,16 @@ bool commands::Commands61To70(const std::string sCommand, char* cCommandArgs, co
 			else if (cCommandArgs[i] == 'f') {
 				bCalculateFloatingPoint = true;
 			}
-			
+
 			// Max-min arguments
 			if (sStringDataCommandArgs[0] != "") {
 				if (sStringDataCommandArgs[1] != "") {
 					// Convert min argument to 64-bit integer and check
-					if (isNumberll(sStringDataCommandArgs[1])) {
-						nMinNumber = std::stoll(sStringDataCommandArgs[1]);
+					if (isNumberld(sStringDataCommandArgs[1])) {
+						nMinNumber = std::stold(sStringDataCommandArgs[1]);
 					}
 					else {
-						VerbosityDisplay("In Commands61To70() - ERROR: Could not detect numerical value in string-based number argument, due to isNumberll fail.\n");
+						VerbosityDisplay("In Commands61To70() - ERROR: Could not detect numerical value in string-based number argument, due to isNumberld fail.\n");
 						UserErrorDisplay("ERROR - Your minimum number generation boundary argument is invalid. Please try again.\nSee \"randnum -h\" for more info.\n");
 
 						return true;
@@ -306,13 +306,13 @@ bool commands::Commands61To70(const std::string sCommand, char* cCommandArgs, co
 
 					return true;
 				}
-				
+
 				// Convert max argument to 64-bit integer and check
-				if (isNumberll(sStringDataCommandArgs[0])) {
-					nMaxNumber = std::stoll(sStringDataCommandArgs[0]);
+				if (isNumberld(sStringDataCommandArgs[0])) {
+					nMaxNumber = std::stold(sStringDataCommandArgs[0]);
 				}
 				else {
-					VerbosityDisplay("In Commands61To70() - ERROR: Could not detect numerical value in string-based number argument, due to isNumberll fail.\n");
+					VerbosityDisplay("In Commands61To70() - ERROR: Could not detect numerical value in string-based number argument, due to isNumberld fail.\n");
 					UserErrorDisplay("ERROR - Your maximum number generation boundary argument is invalid. Please try again.\nSee \"randnum -h\" for more info.\n");
 
 					return true;
@@ -331,8 +331,8 @@ bool commands::Commands61To70(const std::string sCommand, char* cCommandArgs, co
 			colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
 
 			while (true) {
-				nMaxNumber = NumInputll("Please input the maximum boundary for the generator: > ");
-				nMinNumber = NumInputll("Please input the minimum boundary for the generator: > ");
+				nMaxNumber = NumInputld("Please input the maximum boundary for the generator: > ");
+				nMinNumber = NumInputld("Please input the minimum boundary for the generator: > ");
 
 				// Check if max boundary is less than minimum boundary
 				if (nMaxNumber < nMinNumber) {
@@ -351,22 +351,20 @@ bool commands::Commands61To70(const std::string sCommand, char* cCommandArgs, co
 			return true;
 		}
 
-		// Calculate random number and output result
+		long double dCalculatedNumber = 0.0;
 		if (bCalculateFloatingPoint == true) {
-			// Calculate using RandNumld (floating-point)
-			std::cout << "Final Calculated Number: ";
-			colour(LCYN, ConfigObjMain.sColourGlobalBack);
-			std::cout << RandNumld(nMaxNumber, nMinNumber) << "\n";
-			colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
+			dCalculatedNumber = RandNumld(nMaxNumber, nMinNumber);
 		}
 		else {
-			// Calculate using RandNumll (integral)
-			std::cout << "Final Calculated Number: ";
-			colour(LCYN, ConfigObjMain.sColourGlobalBack);
-			std::cout << RandNumll(nMaxNumber, nMinNumber) << "\n";
-			colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
+			dCalculatedNumber = RandNumll(nMaxNumber, nMinNumber);
 		}
 
+		// Display result for calculated number
+		std::cout << "Final Calculated Number: ";
+		colour(LCYN, ConfigObjMain.sColourGlobalBack);
+		std::cout << dCalculatedNumber << "\n";
+		colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
+
 		return true;
 	}
 

CommandFiles/ConverterAssets/ConverterAssets.cpp

@@ -365,7 +365,7 @@ namespace converter
 			slowcolourfn(ConfigObjMain.sColourSubheading, ConfigObjMain.sColourSubheadingBack, "Welcome to the Seconds to Other Time Types Converter!");
 			std::cout << "\n\n";
 			while (true) {
-				dSeconds = NumInputll("Please input the seconds value that you want to convert: > ");
+				dSeconds = NumInputld("Please input the seconds value that you want to convert: > ");
 
 				// Negative numbers are not allowed
 				if (dSeconds < 0) {
@@ -413,7 +413,7 @@ namespace converter
 			slowcolourfn(ConfigObjMain.sColourSubheading, ConfigObjMain.sColourSubheadingBack, "Welcome to the Kilowatts to Horsepower Converter!");
 			std::cout << "\n\n";
 			while (true) {
-				dKilowatts = NumInputll("Please input the kilowatts value that you want to convert: > ");
+				dKilowatts = NumInputld("Please input the kilowatts value that you want to convert: > ");
 
 				// Negative numbers are not allowed
 				if (dKilowatts < 0) {
@@ -438,7 +438,7 @@ namespace converter
 		colourSubheading();
 		std::cout << "Results:" << NOULINE_STR;
 		colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
-		std::cout << "\n\nInputted kilowatt value: " << dKilowatts << "\nConverted horsepower value: " << dHorsepower << "\n\n";
+		std::cout << "\n\nInputted kilowatt value: " << dKilowatts << "kw\nConverted horsepower value: " << dHorsepower << "hp\n\n";
 
 		return;
 	}
@@ -447,10 +447,10 @@ namespace converter
 	void HorsepowerToKilowatts(long double dHorsepower, bool bFromArgument) {
 		// Prompt
 		if (!bFromArgument) {
-			slowcolourfn(ConfigObjMain.sColourSubheading, ConfigObjMain.sColourSubheadingBack, "Welcome to Horsepower to Kilowatts Converter!");
+			slowcolourfn(ConfigObjMain.sColourSubheading, ConfigObjMain.sColourSubheadingBack, "Welcome to the Horsepower to Kilowatts Converter!");
 			std::cout << "\n\n";
 			while (true) {
-				dHorsepower = NumInputll("Please input the horsepower value that you want to convert: > ");
+				dHorsepower = NumInputld("Please input the horsepower value that you want to convert: > ");
 
 				// Negative numbers are not allowed
 				if (dHorsepower < 0) {
@@ -475,7 +475,7 @@ namespace converter
 		colourSubheading();
 		std::cout << "Results:" << NOULINE_STR;
 		colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
-		std::cout << "\n\nInputted horsepower value: " << dKilowatts << "\nConverted kilowatt value: " << dKilowatts << "\n\n";
+		std::cout << "\n\nInputted horsepower value: " << dHorsepower << "hp\nConverted kilowatt value: " << dKilowatts << "kw\n\n";
 
 		return;
 	}
@@ -487,7 +487,7 @@ namespace converter
 			slowcolourfn(ConfigObjMain.sColourSubheading, ConfigObjMain.sColourSubheadingBack, "Welcome to the Light-Years to Kilometres Converter!");
 			std::cout << "\n\n";
 			while (true) {
-				dLightYears = NumInputll("Please input the light-years value that you want to convert: > ");
+				dLightYears = NumInputld("Please input the light-years value that you want to convert: > ");
 
 				// Negative numbers are not allowed
 				if (dLightYears < 0) {
@@ -512,7 +512,7 @@ namespace converter
 		colourSubheading();
 		std::cout << "Results:" << NOULINE_STR;
 		colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
-		std::cout << "\n\nInputted light-years value: " << dLightYears << "\nConverted kilometres value: " << dKilometres << "\n\n";
+		std::cout << "\n\nInputted light-years value: " << dLightYears << " light-years\nConverted kilometres value: " << dKilometres << "km\n\n";
 
 		return;
 	}
@@ -524,7 +524,7 @@ namespace converter
 			slowcolourfn(ConfigObjMain.sColourSubheading, ConfigObjMain.sColourSubheadingBack, "Welcome to the Kilometres to Light-Years Converter!");
 			std::cout << "\n\n";
 			while (true) {
-				dKilometres = NumInputll("Please input the kilometres value that you want to convert: > ");
+				dKilometres = NumInputld("Please input the kilometres value that you want to convert: > ");
 
 				// Negative numbers are not allowed
 				if (dKilometres < 0) {
@@ -549,7 +549,7 @@ namespace converter
 		colourSubheading();
 		std::cout << "Results:" << NOULINE_STR;
 		colour(ConfigObjMain.sColourGlobal, ConfigObjMain.sColourGlobalBack);
-		std::cout << "\n\nInputted kilometres value: " << dKilometres << "\nConverted light-years value: " << dLightYears << "\n\n";
+		std::cout << "\n\nInputted kilometres value: " << dKilometres << "km\nConverted light-years value: " << dLightYears << " light-years\n\n";
 
 		return;
 	}

Core/ZeeTerminalCore.cpp

@@ -212,7 +212,7 @@ namespace zt {
 		std::random_device rdRandNum;
 
 		// distribution in range [min, max]
-		std::uniform_real_distribution<> dist(min, max);
+		std::uniform_real_distribution<long double> dist(min, max);
 
 		return dist(rdRandNum);
 	}
@@ -1104,8 +1104,9 @@ namespace zt {
 	// Parameters: sTitle for the title string.
 	bool SetWindowTitle(std::string sTitle) {
 		if (bAnsiVTSequences) {
-			if (sTitle.length() > 256) {
-				VerbosityDisplay("ERROR: In SetWindowTitle() - String argument incorrect due to ANSI 256 max string char limit for title.\n");
+			if (sTitle.length() > 254) {
+				VerbosityDisplay("ERROR: In SetWindowTitle() - String argument incorrect due to ANSI 254 max string char limit for title.\n");
+				return false;
 			}
 
 			// Use ANSI VT sequences if they work on current terminal
@@ -1117,7 +1118,7 @@ namespace zt {
 				return true;
 			}
 			else {
-				VerbosityDisplay("ERROR: In SetWindowTitle() - String argument incorrect due to WIN32 API 256 max string char limit for title.\n");
+				VerbosityDisplay("ERROR: In SetWindowTitle() - String argument incorrect due to WIN32 API 254 max string char limit for title.\n");
 				return false;
 			}
 		}

ZeeTerminal.cpp

@@ -354,8 +354,9 @@ int main(int argc, char* argv[])
 
 		// Declare fileout stream for ToFile feature
 		std::ofstream ToFile_Out{};
-		// Declare std::streambuf variable so that just in case tofile feature is enabled, the previous stdout buffer can be saved
+		// Declare std::streambuf variables so that just in case tofile feature is enabled, the previous stdout buffer can be saved
 		std::streambuf* coutStreambufBuffer{};
+		std::streambuf* cerrStreambufBuffer{};
 
 		/* The following will be based on parsing sCommandArgsBuffer for the actual arguments. */
 		// Copy the string option arguments into sStringOptionCommandArgs with correct formatting
@@ -552,8 +553,11 @@ int main(int argc, char* argv[])
 		if (bToFileFeatureActivated == true) {
 			// Get index of last string in data string array by calculating its array size
 			size_t nLastDataStringArrayMemberIndex = 0;
-			for (nLastDataStringArrayMemberIndex = nArgArraySize - 1; nLastDataStringArrayMemberIndex >= 0 && sStringDataCommandArgs[nLastDataStringArrayMemberIndex] == ""; nLastDataStringArrayMemberIndex--) {}
-
+			for (nLastDataStringArrayMemberIndex = nArgArraySize - 1; sStringDataCommandArgs[nLastDataStringArrayMemberIndex] == ""; nLastDataStringArrayMemberIndex--) {
+				if (sStringDataCommandArgs[nLastDataStringArrayMemberIndex] == "" && nLastDataStringArrayMemberIndex == 0) {
+					break;
+				}
+			}
 			// Open file using std::ofstream object and the filepath to be the last data string in the data string array
 			ToFile_Out.open(sStringDataCommandArgs[nLastDataStringArrayMemberIndex]);
 
@@ -568,11 +572,17 @@ int main(int argc, char* argv[])
 				ToFile_Out.close();
 			}
 			else {
-				// Save old buffer
+				// Save old buffer for std::cout
 				coutStreambufBuffer = std::cout.rdbuf();
 
-				// Redirect stdout to the new stream
+				// Redirect std::cout to the new stream
 				std::cout.rdbuf(ToFile_Out.rdbuf());
+
+				// Save old buffer for std::cerr
+				cerrStreambufBuffer = std::cerr.rdbuf();
+
+				// Redirect std::cerr to the new stream
+				std::cerr.rdbuf(ToFile_Out.rdbuf());
 			}
 		}
 
@@ -588,6 +598,7 @@ int main(int argc, char* argv[])
 
 			// Undo the streambuf modifications
 			std::cout.rdbuf(coutStreambufBuffer);
+			std::cerr.rdbuf(cerrStreambufBuffer);
 
 			// Close the file stream
 			ToFile_Out.close();