Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils/gprofng: patch needed for musl #181

Open
voltagex opened this issue Jan 13, 2024 · 2 comments
Open

binutils/gprofng: patch needed for musl #181

voltagex opened this issue Jan 13, 2024 · 2 comments

Comments

@voltagex
Copy link

https://sourceware.org/bugzilla/show_bug.cgi?id=30779

Mainly adding this here in case anyone else hits it, or more likely, when I search this again in a year.

../../../src_binutils/gprofng/libcollector/iolib.c:112:49: error: unknown type name 'off64_t'; did you mean 'off_t'?

This may only impact binutils 2.41, I'm not sure.

@voltagex
Copy link
Author

voltagex commented Jan 13, 2024

I ended up needing to disable gprofng in litecross completely, as I was getting strange errors saying it couldn't find memcpy and things like that.

@richfelker
Copy link
Owner

richfelker commented Mar 15, 2024

The commit "fixing" it is all wrong and hard-codes assumptions about musl, invents a musl macro, and pokes at namespace reserved to the implementation.

The right fix is to revert the patch https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=576d2c97d8de26d1ab5a2058e8ba4ffd00b8096d;hp=62544b0cf1b428fb86f01f56783437bd78f9097c and instead remove all the unnecessary 64's that were there for LFS64 stuff, and use standard type uint64_t in place of __u64.

But being that gprof has never worked on musl and that gprofng seems to have a bad record on even trying to do the right thing, I think we should just add --disable-gprofng when adding support for new binutils versions that include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants