ci(.github/workflows/): split mise task steps to several steps (#183)

* ci(.github/workflows/e2e.yml): split fixtures build to several steps

* ci(.github/workflows/): explicitly install package.json dependencies

* style(mise.toml): format with taplo

Author: risu729

.github/workflows/e2e.yml

@@ -29,6 +29,20 @@ jobs:
         with:
           experimental: true
 
+      - name: Install package.json dependencies
+        run: mise run buni
+
+      - name: Build Package
+        run: mise run build
+
+      - name: Install E2E Test Fixtures Dependencies
+        run: bun install --frozen-lockfile
+        working-directory: tests/e2e/fixtures
+
+      - name: Build E2E Test Fixtures with astro-better-image-service
+        run: bun run build
+        working-directory: tests/e2e/fixtures
+
       - name: Store Dependency Versions
         id: dependency-versions
         run: |
@@ -42,9 +56,6 @@ jobs:
           path: ~/.cache/ms-playwright
           key: playwright-browsers-${{ runner.os }}-${{ steps.dependency-versions.outputs.playwright }}
 
-      - name: Install package.json dependencies
-        run: mise run buni
-
       - name: Install Playwright Browsers and Dependencies
         id: playwright-install
         if: steps.restore-browsers-cache.outputs.cache-hit != 'true'
@@ -89,6 +100,12 @@ jobs:
         with:
           experimental: true
 
+      - name: Install package.json dependencies
+        run: mise run buni
+
+      - name: Build Package
+        run: mise run build
+
       - name: Store Dependency Versions
         id: dependency-versions
         run: |
@@ -104,9 +121,6 @@ jobs:
           path: ~/.cache/ms-playwright
           key: playwright-browsers-${{ runner.os }}-${{ steps.dependency-versions.outputs.playwright }}
 
-      - name: Install package.json dependencies
-        run: mise run buni
-
       - name: Install Playwright Browsers and Dependencies
         id: playwright-install
         if: steps.restore-browsers-cache.outputs.cache-hit != 'true'
@@ -127,16 +141,21 @@ jobs:
         id: fixtures-hash
         run: echo "hash=${{ hashFiles('tests/e2e/fixtures/**/*', 'tests/e2e/conversion.test.ts') }}" >> "$GITHUB_OUTPUT"
 
+      - name: Install E2E Test Fixtures Dependencies
+        run: bun install --frozen-lockfile
+        working-directory: tests/e2e/fixtures
+
       - name: Restore Snapshots Cache
         id: restore-snapshots-cache
         uses: actions/cache/restore@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
         with:
           path: tests/e2e/conversion.test.ts-snapshots
-          key: "default-service-snapshots-${{ runner.os }}-${{ steps.dependency-versions.outputs.astro }}-${{ steps.dependency-versions.outputs.playwright }}-${{ steps.fixtures-hash.outputs.hash }} "
+          key: "default-service-snapshots-${{ runner.os }}-${{ steps.dependency-versions.outputs.astro }}-${{ steps.dependency-versions.outputs.playwright }}-${{ steps.fixtures-hash.outputs.hash }}"
 
       - name: Build E2E Test Fixtures with the Default Image Service
         if: steps.restore-snapshots-cache.outputs.cache-hit != 'true'
-        run: mise run test:e2e:fixtures:build
+        run: bun run build
+        working-directory: tests/e2e/fixtures
         env:
           USE_DEFAULT_IMAGE_SERVICE: true
 
@@ -154,7 +173,8 @@ jobs:
           key: ${{ steps.restore-snapshots-cache.outputs.cache-primary-key }}
 
       - name: Build E2E Test Fixtures with astro-better-image-service
-        run: mise run test:e2e:fixtures:build
+        run: bun run build
+        working-directory: tests/e2e/fixtures
 
       - name: Playwright Image Services Consistency Test
         id: playwright-test-conversion

.github/workflows/lint.yml

@@ -66,6 +66,10 @@ jobs:
         with:
           experimental: true
 
+      - name: Install package.json dependencies
+        if: matrix.buni
+        run: mise run buni
+
       - name: Run ${{ matrix.name }}
         run: mise run ${{ matrix.task }}
 

.github/workflows/release.yml

@@ -58,6 +58,9 @@ jobs:
         with:
           experimental: true
 
+      - name: Install Dependencies
+        run: mise run buni
+
       - name: Build
         run: mise run build
 

.github/workflows/scripts/list-mise-tasks.ts

@@ -1,11 +1,6 @@
 // biome-ignore lint/nursery/noUndeclaredDependencies:
 import { $ } from "bun";
-import {
-	type EdgeModel,
-	type NodeModel,
-	type NodeRef,
-	fromDot,
-} from "ts-graphviz";
+import { type EdgeModel, type NodeRef, fromDot } from "ts-graphviz";
 
 $.throws(true);
 
@@ -38,36 +33,57 @@ const getEdgeTargets = ({ targets }: EdgeModel) => {
 	};
 };
 
-const getNodeFromRef = ({ id }: NodeRef) => {
+const getChildNodes = (
+	node: NodeRef,
+	edges: ReturnType<typeof getEdgeTargets>[],
+	recursive = false,
+): NodeRef[] => {
+	const children = edges
+		.filter(({ from }) => from.id === node.id)
+		.map(({ to }) => to);
+
+	if (recursive) {
+		return children.flatMap((child) => [
+			child,
+			...getChildNodes(child, edges, true),
+		]);
+	}
+
+	return children;
+};
+
+const getNodeLabel = ({ id }: NodeRef) => {
 	const node = ciTasks.nodes.find((node) => node.id === id);
 	if (!node) {
 		throw new Error(`node with id ${id} not found`);
 	}
-	return node;
-};
-
-const getNodeLabel = (node: NodeModel) => {
 	const label = node.attributes.get("label");
 	if (!label) {
 		throw new Error("missing label in node");
 	}
 	return label;
 };
 
+const edges = ciTasks.edges.map(getEdgeTargets);
+
 const tasks: {
 	name: string;
 	task: string;
-}[] = ciTasks.edges
-	.map(getEdgeTargets)
-	.filter(({ from }) => from.id === rootNode.id)
-	.map(({ to }) => {
-		const taskName = getNodeLabel(getNodeFromRef(to));
-		// remove prefix if exists
-		const name = taskName.split(":")[1] ?? taskName;
-		return {
-			name: name,
-			task: taskName,
-		};
-	});
+	buni: boolean;
+}[] = getChildNodes(rootNode, edges).map((to) => {
+	const taskName = getNodeLabel(to);
+	// remove prefix if exists
+	const name = taskName.split(":")[1] ?? taskName;
+
+	const depends = getChildNodes(to, edges, true).map((node) =>
+		getNodeLabel(node),
+	);
+
+	return {
+		name: name,
+		task: taskName,
+		buni: depends.some((dep) => dep === "buni"),
+	};
+});
 
 console.write(JSON.stringify(tasks));

.github/workflows/unit.yml

@@ -29,6 +29,9 @@ jobs:
         with:
           experimental: true
 
+      - name: Install Dependencies
+        run: mise run buni
+
       - name: Test
         run: mise run test:unit
 

mise.toml

@@ -57,17 +57,10 @@ run = "bun run playwright test vrt format"
 depends = ["buni"]
 run = "bun run playwright test vrt --update-snapshots"
 
-[tasks."test:e2e:fixtures:install"]
-depends = ["build"]
-run = "bun install --frozen-lockfile --cwd tests/e2e/fixtures"
-
-[tasks."test:e2e:fixtures:build"]
-depends = ["test:e2e:fixtures:install"]
-run = "bun run --cwd tests/e2e/fixtures astro build"
-
 [tasks."test:e2e:fixtures:server"]
-depends = ["test:e2e:fixtures:build"]
-run = "bun run --cwd tests/e2e/fixtures astro preview"
+depends = ["build"]
+run = ["bun install --frozen-lockfile", "bun run build", "bun run preview"]
+dir = "tests/e2e/fixtures"
 
 [tasks."test:e2e:fixtures:remove-symlinks"]
 # remove before some checks to avoid symlink loops

playwright.config.ts

@@ -14,7 +14,9 @@ export default defineConfig({
 	},
 
 	webServer: {
-		command: "mise run test:e2e:fixtures:server",
+		command: process.env["CI"]
+			? "bun run --cwd tests/e2e/fixtures preview"
+			: "mise run test:e2e:fixtures:server",
 		url: "http://localhost:4321",
 		// set to 5 minutes because image optimization can take a while
 		timeout: 5 * 60 * 1000,

tests/e2e/fixtures/package.json

@@ -4,5 +4,9 @@
 	"type": "module",
 	"dependencies": {
 		"astro-better-image-service": "link:astro-better-image-service"
+	},
+	"scripts": {
+		"build": "astro build",
+		"preview": "astro preview"
 	}
 }