From 06d002c75e9a68ab42d047c3cf7fd624ee571992 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 4 Jun 2024 14:33:19 +0000 Subject: [PATCH 1/3] chore(deps): update dependency @biomejs/biome to v1.8.0 --- bun.lockb | Bin 455396 -> 455372 bytes package.json | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/bun.lockb b/bun.lockb index 42ddc9c8acfda13b50dfbae9c5edb830edc35ab4..de3a6ff7f001fa330c837e39d0e3b1190cc39645 100755 GIT binary patch delta 1279 zcmaFzRQk+Q=?Qv@O`)HcrK)_rWyJi(GkUMM=h}rE1VXi?j~;yc=rL=n(iEFU|E>Ov zrpc384wy{ek<7>gX8eFLEK;B%6)?sQ7~=~+4}oE zF~T{2B(qMOk7g3_TqBvW0|NUJn)boDQ6N7251b=iLo<7%@ zS)xAVgT=yA2P{`wUJO(H#M}^8@lGV*rJ|Rrm*m^xZ_|vuB5Rd+a;4`StGXZftKxxc zLAFk^_NsTPCY48A7k@8Z&%=mtULmscisimNGkL12H+PfwNp&73$7MY(LM=DBb>6)+ zo-MoEt^RPVO!2Fm&n4M(DnuRo>!WAZa~*N>=$yK>=klbmbF<&aP4_hcIs6SbbLPgC$qDS`vQjz= z84oB=tICPK1$7?CWyQ$OD-n=5`-$_)%xPUrOQX71`&V<`>D!_^`SFT72Gh>8_G$lQ zjC*hUbg86lsE1N&8QUb@12=9uNrlg6xF1$H>Cvy>4AcLDoR?~HiQnz~rOLlSQ=BEa zE|?l|7q%?^(P`-0^__#Y>Vat^-xbD1nJKqgy`l|nF$bM%o1o(-tI)Aww#~GulQZrc zLY>zDbY3a4^VDl|mi+NpLspXF>JpAaAxKmNyvKYz3 z|2WqLhD3T+Oo;uo|A1bi)0Pd+L4{`@e4oD7lv%=I$H(LQ-u+V1Elzx2oMO%weEC50 zTc5P#cV?_h@@G8lU2u=l`m;{(!QY(Jd;IKe&re z4+v*wX;&~~-mYNA;?u}%p=Yo?e>=;{E9O8J(A~!Ij0_SC3=J2}HaqP<_bHBr(NGT} z;|-J%2g>k&o<2?9?)(C%%yj=AR&l82YM>G^ppvIQjkBL9GczGHPlOt4ue*{X>z3Sm znC7`a&9V^lj{ud(0yT&BJ2b8HdZY|hvi)KYYdI6sr;qJk{jA%)`q^ya*?}7LO46&Q zFZ{?RwtVqBHbzE^>5049l&0ssW8;{9?me3px&YVo`uA+C(~Ul`iK0vKPOtyKCX6D= z_mPcz`iT#0(&(Z}C<4(R*;LR4xTbFbI?5U9!o2*HRE5mE;*!Li9R1{s)Z}br5xuNp jV2Fc3NlT%2sB`#Gf1f2%*E zY4T*2%O=xzBs21W89!hQixj9x1&px+#`pnaSfs+#Ko~lcJXqSdq%v;blFAf#wtf*~ zfb#Q~vA?r_-I&$FH(Rkr@{P)($r=ovw|chJTC1mvoZFRr(pa?kn(e#4+l%+V)sJyX z6Sj-KY0=umID3m#Ark`wBLfSA00RRDl!*VrOlzgJjJjrt8lL^!Vy*?G%^gV|pApF8;me zbJhE;SnmeaxcW=Vc%Lk}lx@r^pgnK$PZOspPh|fe{W`DW!1w9CCP3%yE1#QqymEP` zoPS00<5NOf#vLx-WO|i-bMNz5hn-q{ZExoUJz`Y-91iC%7oNss(tSMBuEA?q} zl4YZ$I^$NU_jV3?apg;@t5mJ-Y-GB?e3Y&2S?%<{Am^zT%u+hu<>FFZ(ki$y(m{2( z`s^cZPkIHHi&dOldw1srp+tA9kBLhkKXftoJ;2&~%Ajj^>!GdNtvNe0)8e&s(xA?3 z06MP}*?GH)o%oh=^}V<;$z|i_9juDqqc+`+=Fzh|?#pas?XLucF}}`i63|i9Xnw4+ z>HPXRukSuj-0jDGcKaQxJzrmj$(gN-UGmm}C+~~MlSGD@QVQu&A%a^jPyXO8K0P3u znWbI9jCs3)8H-ONv$>w}_WbQEE3cRXSwMFi$1^fWFfcS+G~4X7|JSN- zMjR-^|9Sc}dAsuqpfc0_dsxMxnyZ0I#DGek{xr^hqRh;M&^!@ptiA3^j;vd9?_rwf z0yWD*%s&EDA`8?U+V9Y`&g+pfRLS;>J*?$SOuV1kz4}?Vd-b!~#Ipl6=#`{bO<(wt zO>Ft%cWjK)lN{NUrsuw6 Date: Wed, 5 Jun 2024 04:18:56 +0900 Subject: [PATCH 2/3] chore: follow biome --- biome.jsonc | 6 ++++-- package.json | 2 +- tests/e2e/conversion.test.ts | 2 +- tests/e2e/fixtures/src/pages/[...path].astro | 2 +- tests/e2e/fixtures/src/pages/index.astro | 2 +- tests/e2e/format.test.ts | 2 +- tests/e2e/vrt.test.ts | 2 +- 7 files changed, 10 insertions(+), 8 deletions(-) diff --git a/biome.jsonc b/biome.jsonc index 9739acc6..9099a4dd 100644 --- a/biome.jsonc +++ b/biome.jsonc @@ -28,10 +28,12 @@ // collides with the lint/nursery/useImportRestrictions rule "noBarrelFile": "off" }, + "correctness": { + // this package runs on Node.js + "noNodejsModules": "off" + }, "nursery": { "all": true, - // this package runs on Node.js - "noNodejsModules": "off", // handled by Knip "noUndeclaredDependencies": "off" } diff --git a/package.json b/package.json index 07cb2a09..dbf973a8 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,7 @@ "build": "tsc --project tsconfig.src.json", "commit": "git-cz", "check": "concurrently \"bun:check:*(!type:)\"", - "check:biome": "biome check --apply --error-on-warnings .", + "check:biome": "biome check --fix --error-on-warnings", "check:type": "concurrently \"bun:check:type:*\"", "check:type:base": "tsc --project tsconfig.base.json", "check:type:src": "tsc --noEmit --project tsconfig.src.json", diff --git a/tests/e2e/conversion.test.ts b/tests/e2e/conversion.test.ts index c4deec09..382a465a 100644 --- a/tests/e2e/conversion.test.ts +++ b/tests/e2e/conversion.test.ts @@ -2,7 +2,7 @@ import { readdir } from "node:fs/promises"; import { setTimeout } from "node:timers/promises"; import { expect, test } from "@playwright/test"; // biome-ignore lint/nursery/useImportRestrictions: import required for test -import { AVAILABLE_FORMAT_CONVERSIONS } from "./fixtures/src/formats"; +import { AVAILABLE_FORMAT_CONVERSIONS } from "./fixtures/src/formats.ts"; // intended to run on CI, with the expected snapshots taken with the default image service diff --git a/tests/e2e/fixtures/src/pages/[...path].astro b/tests/e2e/fixtures/src/pages/[...path].astro index 97fc84e8..9d466e68 100644 --- a/tests/e2e/fixtures/src/pages/[...path].astro +++ b/tests/e2e/fixtures/src/pages/[...path].astro @@ -5,7 +5,7 @@ import type { GetStaticPaths, ImageMetadata } from "astro"; import { AVAILABLE_FORMAT_CONVERSIONS, type VALID_INPUT_FORMATS, -} from "../formats"; +} from "../formats.ts"; import svgImage from "../images/astro.svg"; import tiffImage from "../images/capybara.tiff"; diff --git a/tests/e2e/fixtures/src/pages/index.astro b/tests/e2e/fixtures/src/pages/index.astro index 6f5bf74c..d43bfeba 100644 --- a/tests/e2e/fixtures/src/pages/index.astro +++ b/tests/e2e/fixtures/src/pages/index.astro @@ -1,6 +1,6 @@ --- // biome-ignore lint/correctness/noUnusedImports: used in the template -import { AVAILABLE_FORMAT_CONVERSIONS } from "../formats"; +import { AVAILABLE_FORMAT_CONVERSIONS } from "../formats.ts"; // biome-ignore lint/correctness/noUnusedVariables: used in the template const imageService = process.env["USE_DEFAULT_IMAGE_SERVICE"] diff --git a/tests/e2e/format.test.ts b/tests/e2e/format.test.ts index 49afc511..d0fc5c66 100644 --- a/tests/e2e/format.test.ts +++ b/tests/e2e/format.test.ts @@ -4,7 +4,7 @@ import { AVAILABLE_FORMAT_CONVERSIONS, DEFAULT_OUTPUT_FORMAT, // biome-ignore lint/nursery/useImportRestrictions: import required for test -} from "./fixtures/src/formats"; +} from "./fixtures/src/formats.ts"; test.describe("Image Format Conversion", () => { for (const { diff --git a/tests/e2e/vrt.test.ts b/tests/e2e/vrt.test.ts index e6237323..9f0b8fb9 100644 --- a/tests/e2e/vrt.test.ts +++ b/tests/e2e/vrt.test.ts @@ -1,7 +1,7 @@ import { setTimeout } from "node:timers/promises"; import { expect, test } from "@playwright/test"; // biome-ignore lint/nursery/useImportRestrictions: import required for test -import { AVAILABLE_FORMAT_CONVERSIONS } from "./fixtures/src/formats"; +import { AVAILABLE_FORMAT_CONVERSIONS } from "./fixtures/src/formats.ts"; test.describe("Visual Regression", () => { for (const { From 01fc15aaaeb4fa80b803c9781f28bc4e57d0a586 Mon Sep 17 00:00:00 2001 From: risu729 Date: Wed, 5 Jun 2024 04:22:52 +0900 Subject: [PATCH 3/3] ci(check.yml): remove unnecessary argument of biome --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index cb652ee9..9853f45b 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -79,7 +79,7 @@ jobs: - name: Biome if: ${{ !cancelled() && steps.install.outcome == 'success' }} - run: bun run biome ci --error-on-warnings . + run: bun run biome ci --error-on-warnings - name: tsc (source) if: ${{ !cancelled() && steps.install.outcome == 'success' }}