Skip to content

Commit 42dfd07

Browse files
authored
Fix incorrect call to RemoveFailedNode (openhab#1150)
Signed-off-by: Chris Jackson <[email protected]>
1 parent dbe66e5 commit 42dfd07

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/main/java/org/openhab/binding/zwave/handler/ZWaveControllerHandler.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -684,8 +684,7 @@ public Collection<ZWaveNode> getNodes() {
684684
* Transmits the {@link ZWaveCommandClassTransactionPayload} to a Node.
685685
* This will not wait for the transaction response.
686686
*
687-
* @param transaction
688-
* the {@link ZWaveCommandClassTransactionPayload} message to send.
687+
* @param transaction the {@link ZWaveCommandClassTransactionPayload} message to send.
689688
*/
690689
public void sendData(ZWaveCommandClassTransactionPayload transaction) {
691690
if (controller == null) {
@@ -742,7 +741,7 @@ public void replaceFailedNode(int nodeId) {
742741
if (controller == null) {
743742
return;
744743
}
745-
controller.requestRemoveFailedNode(nodeId);
744+
controller.requestSetFailedNode(nodeId);
746745
}
747746

748747
public void reinitialiseNode(int nodeId) {

src/main/java/org/openhab/binding/zwave/handler/ZWaveThingHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1001,10 +1001,10 @@ public void handleConfigurationUpdate(Map<String, Object> configurationParameter
10011001
case "action":
10021002
if ("failed".equals(cfg[1]) && valueObject instanceof Boolean && ((Boolean) valueObject) == true) {
10031003
controllerHandler.replaceFailedNode(nodeId);
1004+
controllerHandler.checkNodeFailed(nodeId);
10041005
}
10051006
if ("remove".equals(cfg[1]) && valueObject instanceof Boolean && ((Boolean) valueObject) == true) {
10061007
controllerHandler.removeFailedNode(nodeId);
1007-
controllerHandler.checkNodeFailed(nodeId);
10081008
}
10091009
if ("reinit".equals(cfg[1]) && valueObject instanceof Boolean && ((Boolean) valueObject) == true) {
10101010
logger.debug("NODE {}: Re-initialising node!", nodeId);

0 commit comments

Comments
 (0)