New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to use the output_directory from gym if provided #64

Open

asoneji opened this issue Feb 11, 2021 · 1 comment · May be fixed by #74

Labels

good first issue

asoneji commented Feb 11, 2021

In our gym config, we have provided output_directory dir. When using IPASizeProvider we got the follwoing error:

[17:28:41]: $ ../Pods/SwiftInfo/bin/swiftinfo
[17:28:47]: ▸ * Extracting ipa_size
[17:28:47]: ▸ * **ipa_size:** .ipa not found! Attempted to find .ipa at: ../build/

I noticed is not using the output_directory dir from gym and instead, it is expecting the ipa to be inside the ./build folder.

The text was updated successfully, but these errors were encountered:

Owner

rockbruno commented Feb 11, 2021

Seems like we could to add a path parameter to IPASizeProvider. Should be an easy fix 👍

rockbruno added the good first issue label

wacumov linked a pull request

that will close this issue

Add path parameter to IPASizeProvider #74

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment