Latest layout changes slightly unstable/off

[ferdnyc]

Description

Here's a screencast of the current version 50.1.1 popup on my system:

Three observations:

Width changes

I think because the word "Wednesday" is so long, the width of the forecast panel changes when switching between day and week view, and changes the width of the entire popup. It's not a big deal, but noticeable.

Loss of forecast for +12 – +24 hour period

Prior to the addition of the page indicators, the forecast view used to have three pages, and cycled between week, next 12 hours, and following 12 hours. Is there any reason it was changed to only show the next 12 hours? I liked being able to check the hourly forecast for the next day, in the evening, but now I can only see the overnight temps.

Spacing/centering of detail items

There's something "weird" about the layout of the details elements, that's not strictly about centering. Even if all of the elements were centered in their frames, assuming the frames are the same size, then at least things like "Sunrise" and "Sunset" should line up vertically, since they're almost exactly the same size.

Compare the layout of the items in the screencast with the layout of their display in the Details tab of the Settings:

For "Sunset" to be so far to the left of "Sunrise" in the screencast, something weird has to be going on. (Possibly due to the length of the word "Precipitation".)

Actually, yeah, now I see it. The left and right text edges of both rows line up, it's just the stuff in between that's all over the place. So it's like a flexbox holding variable-sized content set to justify-content: space-between. Rather than a container of equal-size contents, like in the Settings view.

System

Fedora 44 x86_64

Settings

{
 "details-list": "['conditionText', 'windSpeedAndDir', 'sunrise', 'humidity', 'feelsLike', 'gusts', 'sunset', 'precipitation']",
 "temp-unit": "'celsius'",
 "show-suntime": "false",
 "theme": "''",
 "show-suntime-as-countdown": "false",
 "secondary-panel-detail": "''",
 "pressure-unit": "'mmHg'",
 "rain-measurement-unit": "'in'",
 "is-activated": "true",
 "panel-box": "'center'",
 "panel-priority": "0",
 "speed-unit": "'kph'",
 "panel-offset": "20.0",
 "main-location-index": "1",
 "my-loc-provider": "'disable'",
 "my-loc-refresh-min": "45.0",
 "show-refresh-button": "true",
 "unit-preset": "'us'",
 "app-version": "50.1.1",
 "gnome-version": "50.3",
 "user-locale": "en-US"
}

[romanlefler]

Thank you for the report, I especially don't know how I missed the 3 -> 2 page forecast regression. That was a simple off-by-one error, but the layout stuff I'll have to think about how to handle more elegantly.

[ferdnyc]

On the subject of the details items, I also wonder if, perhaps, the values should be in white text, instead of muted. On the theory that anything that's "live data", and not chrome, should be highlighted.

i.e., instead of what's in the screencast, this: