fixup! fixup! Make provider holdable

Author: root-expert

lib/puppet/provider/package/snap.rb

@@ -66,6 +66,7 @@ def hold
     Puppet.info("@property_hash = #{@property_hash}")
     Puppet.info("install_options = #{@resource[:install_options]}")
     modify_snap('hold') if should_change_hold?(@resource[:install_options])
+    @property_hash[:mark] = 'hold'
   end
 
   def unhold
@@ -143,14 +144,16 @@ def should_change_hold?(options)
     should_hold_time = self.class.parse_time_from_options(options)
     current_hold_time = @property_hash[:hold_time]
 
+    # if current hold time is nil we are fresh holding this snap
+    return true if current_hold_time.nil?
+
     parsed_hold_time = DateTime.parse(current_hold_time)
     # If the hold time is more than 100 years, assume "forever"
     current_hold_time = 'forever' if (parsed_hold_time - DateTime.now).to_i > 365 * 100
 
     Puppet.info("should = #{should_hold_time}, current = #{current_hold_time}")
-
-    false if current_hold_time == should_hold_time
-    true
+    Puppet.info("equal = #{current_hold_time == should_hold_time}")
+    current_hold_time != should_hold_time
   end
 
   def self.channel_from_options(options)