Skip to content

[unuran] download from LCG instead of bundle builtin and use CMake target#21946

Open
ferdymercury wants to merge 8 commits into
root-project:masterfrom
ferdymercury:bunur2
Open

[unuran] download from LCG instead of bundle builtin and use CMake target#21946
ferdymercury wants to merge 8 commits into
root-project:masterfrom
ferdymercury:bunur2

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

Variant of #21938 but using LCG link

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 9h 18m 49s ⏱️
 3 856 tests  3 856 ✅ 0 💤 0 ❌
76 166 runs  76 166 ✅ 0 💤 0 ❌

Results for commit 06e95a5.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo self-assigned this Apr 19, 2026
as done by bellenot in libgif etc
@ferdymercury

Copy link
Copy Markdown
Collaborator Author

gentle ping @lmoneta

Comment thread builtins/unuran/0001-allow-compilation-from-CMake.patch
@ferdymercury ferdymercury reopened this Jun 3, 2026
@dpiparo

dpiparo commented Jun 8, 2026

Copy link
Copy Markdown
Member

thanks for these changes.
The only difference between unuran and other packages now not in source, e.g. lzma, is that it is not installable on linux and mac: indeed unuran is not present in Homebrew. This is not a blocker, but certainly something that introduces a symmetry, requiring always to have an internet connection on mac, because it is not possible to install locally all ROOT dependencies (unuran does not exist in brew)

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Yep, libunuran-dev exists on latest ubuntu and unuran-devel exists on alma, but not on homebrew for mac.
Do we know of someone with experience with homebrew that could be willing to give it a try to adding a formula for it so that we can restore symmetry? Maybe @henryiii ?

@ferdymercury

ferdymercury commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

mac: indeed unuran is not present in Homebrew.

I just proposed a new homebrew formula: Homebrew/homebrew-core#288800

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Formula merged! So unuran is now part of homebrew.

@ferdymercury

ferdymercury commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@dpiparo @couet @linev could you install unuran via brew in the Mac14/15/26/beta runners?
That way we can turn the builtin to OFF in the CI. (Or at least on some of these macs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants