Recommend pkgcheck GitHub Action?

[noamross]

@assignUser and @mpadge have created the pkgcheck GitHub Action. Once this is has had a few real-world tests, should we recommend this? It would be included both in CI best practices and be referenced in chapter 6.2, where currently mention the pkgcheck package.

[maelle]

I'm not sure developers should run it at every commit, so maybe the dev guide should emphasis the manual triggering / using the action as PR command à la https://github.com/r-lib/actions/blob/v2-branch/examples/pr-commands.yaml

[mpadge]

There should be no problem running it with every commit - it's docker-based, so much faster than r-lib/actions/rcmdcheck actions anyway. Plus the idea will be to slowly move towards scraping workflow logs where they exist instead of calling our own external service.

[maelle]

Thanks, this makes sense!

[assignUser]

The action takes <5 min to run, it can be a bit longer depending on the number and complexity of the installed dependencies. See also: ropensci-review-tools/pkgcheck-action#23

[mpadge]

I'm going to move this issue to next milestone, because there have been an awful lot of build issues on actions lately, related to general {pak} stuff beyond this repo. The docker build is passing again as of yesterday, but has been generally failing for the last 2 weeks or so. Plus it might be good to wait for ropensci-review-tools/pkgcheck#143, which might mess with actions in the meantime.