-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for headless mode #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for headless mode #21
Conversation
|
When I echo |
When I checked with rolling it did, I can check it again this evening |
|
@pgesel-rai I just tested the setup with |
|
I am going to do some more testing. I wonder if the effort based controller I am running can cause issues. Are you using a position interface? |
Yes!! mujoco_ros2_simulation/test/test_resources/test_robot.xml Lines 44 to 47 in 040657b
|
|
I messed up the backport. This works on the Humble branch. Looks good! |
I'm glad it is working. Can you approve the PR, if the changes look good to you? |
eholum-nasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Works beautifully for me on jazzy. Just minor nits about adding some comments.
@pgesel-rai If you have a functional back port ready to go can you open a PR for the humble branch? This is something that we would use on humble, too.
Co-authored-by: Erik Holum <[email protected]>
eholum-nasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Fixes: #20
@pgesel-rai FYI
In future, we can add some changes, like if we set the headless parameter from the launch file, we can toggle the behaviour