Skip to content

add ros2 service info -v to "Understanding services" (#6038) #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2025
Merged

add ros2 service info -v to "Understanding services" (#6038) #6044

merged 5 commits into from
Nov 25, 2025

Conversation

@Muhammadjunaidmalik1
Copy link
Contributor

@Muhammadjunaidmalik1 Muhammadjunaidmalik1 commented Nov 23, 2025 •
edited by fujitatomoya
Loading

Description

  • The PR adds the newly added --verbose functionality in rolling, for ROS services tutorials. (ros2 service info -v )
  • The feature is currently only available if code is built from source of the rolling branch.
  • Details of this new feature are mentioned in the thread (add verbose in service-info verb ros2cli#916) in the ROS2 rolling documentation.

Here is the link that shows details about the issue:
#6038

Fixes #6038

Did you use Generative AI?

Partially, In some regions in the text. But not in code blocks, i tested the feature myself by building it from source.

Additional Information

@Muhammadjunaidmalik1 Muhammadjunaidmalik1 mentioned this pull request Nov 23, 2025
Closed
fujitatomoya
fujitatomoya requested changes Nov 24, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muhammadjunaidmalik1 thanks for creating issue.

almost lgtm, several minor changes requested. can you address them?

ahcorde
ahcorde requested changes Nov 24, 2025
View reviewed changes
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 25, 2025

@Muhammadjunaidmalik1 we are almost there, CI is not happy can you address the following failures?

https://github.com/ros2/ros2_documentation/actions/runs/19658667055/job/56306688869?pr=6044

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 25, 2025

@Mergifyio rebase

Muhammadjunaidmalik1 and others added 5 commits November 25, 2025 22:20
@Muhammadjunaidmalik1 @fujitatomoya
add ros2 service info -v to "Understanding services" (ros2#6038)
8f2a4ea
@Muhammadjunaidmalik1 @fujitatomoya
Suggested changes
d70872b
@Muhammadjunaidmalik1 @ahcorde @fujitatomoya
Update source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Service…
5c26176 
…s/Understanding-ROS2-Services.rst

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Muhammad Junaid <[email protected]>
@Muhammadjunaidmalik1 @ahcorde @fujitatomoya
Update source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Service…
491c493 
…s/Understanding-ROS2-Services.rst

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Muhammad Junaid <[email protected]>
@Muhammadjunaidmalik1 @ahcorde @fujitatomoya
Update source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Service…
e52a25b 
…s/Understanding-ROS2-Services.rst

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Muhammad Junaid <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the origin/muhammad/issues/6038 branch from 668b5a3 to e52a25b Compare November 25, 2025 22:20
@fujitatomoya fujitatomoya enabled auto-merge (squash) November 25, 2025 22:20
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 25, 2025

@ahcorde can you approve this to merge?

this feature is only available on rolling branch. that means we do not need any backports for this doc enhancement.

@ahcorde ahcorde enabled auto-merge (squash) November 25, 2025 22:37
@ahcorde ahcorde merged commit 35be3f4 into ros2:rolling Nov 25, 2025
5 checks passed
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 25, 2025

@Muhammadjunaidmalik1 thanks for the great work on your 1st contribution for ROS 2 project 👍

@ahcorde thanks for the review!

@Muhammadjunaidmalik1 Muhammadjunaidmalik1 deleted the origin/muhammad/issues/6038 branch November 26, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@Muhammadjunaidmalik1 Muhammadjunaidmalik1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add ros2 service info -v to "Understanding services"

3 participants

@Muhammadjunaidmalik1 @fujitatomoya @ahcorde