Remove logging message and update tests

Author: rosle

lib/google_crawler/search/search_keyword_worker.ex

@@ -27,8 +27,6 @@ defmodule GoogleCrawler.SearchKeywordWorker do
   end
 
   def handle_call({:search, keyword_id}, _from, state) do
-    IO.puts("Handle call #{keyword_id}")
-
     keyword = Search.get_keyword(keyword_id)
     Search.update_keyword(keyword, %{status: :in_progress})
 
@@ -45,8 +43,6 @@ defmodule GoogleCrawler.SearchKeywordWorker do
   end
 
   def handle_info({ref, result}, state) do
-    IO.puts("Handle info | success")
-
     {keyword, _retry_count} = Map.get(state, ref)
 
     Search.update_keyword(keyword, %{
@@ -62,22 +58,17 @@ defmodule GoogleCrawler.SearchKeywordWorker do
   end
 
   def handle_info({:DOWN, ref, :process, _pid, _reason}, state) do
-    IO.puts("Handle info | failed")
-
     {keyword, retry_count} = Map.get(state, ref)
 
     new_state =
       if retry_count < @max_retry_count do
-        IO.puts("Retry... #{retry_count}")
         task = start_task(keyword)
 
         state
         |> Map.delete(ref)
         |> Map.put(task.ref, {keyword, retry_count + 1})
       else
-        IO.puts("Done with failed...")
         Search.update_keyword(keyword, %{status: :failed})
-
         Map.delete(state, ref)
       end
 

test/google_crawler/search/search_keyword_worker_test.exs

@@ -14,6 +14,9 @@ defmodule GoogleCrawler.Search.SearchKeywordWorkerTest do
 
     assert %{^task_ref => {keyword, 0}} = SearchKeywordWorker.get_state()
     assert Search.get_keyword(keyword.id).status == :in_progress
+
+    :timer.sleep(1000)
+    assert SearchKeywordWorker.get_state() == %{}
   end
 
   test "search/1 updates the keyword result when the task is completed" do

test/google_crawler/search_test.exs

@@ -30,7 +30,7 @@ defmodule GoogleCrawler.SearchTest do
 
       assert {:ok, %Keyword{} = keyword} = Search.create_keyword(keyword_attrs, user)
       assert keyword.keyword == "elixir"
-      assert keyword.status == :created
+      assert keyword.status == :in_queue
       assert keyword.user_id == user.id
     end
 
@@ -45,20 +45,9 @@ defmodule GoogleCrawler.SearchTest do
       keyword = KeywordFactory.create()
       keyword_attrs = %{keyword: "new", status: :in_progress}
 
-      # assert {:ok, %Keyword{} = keyword} = Search.update_keyword(keyword, keyword_attrs)
-      # assert keyword.keyword == "new"
-      # assert keyword.status == :in_progress
-
-      Search.update_keyword(keyword, %{status: :in_progress})
-      Search.update_keyword(keyword, %{status: :failed})
-      Search.update_keyword(keyword, %{status: :in_progress})
-      Search.update_keyword(keyword, %{status: :failed})
-      Search.update_keyword(keyword, %{status: :in_progress})
-      Search.update_keyword(keyword, %{status: :failed})
-      Search.update_keyword(keyword, %{status: :in_progress})
-      Search.update_keyword(keyword, %{status: :completed})
-
-      IO.inspect(Search.get_keyword(keyword.id))
+      assert {:ok, %Keyword{} = keyword} = Search.update_keyword(keyword, keyword_attrs)
+      assert keyword.keyword == "new"
+      assert keyword.status == :in_progress
     end
 
     test "update_keyword/2 with invalid data returns error changeset" do