ArduinoCITable copy construction and clearing (bug chasing)

Author: ianfixes

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - CPP library class now reaches into included Arduino libraries for source files
 - SPI mocks
 - `ensure_arduino_installation.rb` to allow custom libraries to be installed
+- Copy constructor for `ArduinoCITable`
 
 ### Changed
 - Refactored documentation
@@ -24,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 - OSX splash screen re-disabled
+- ArduinoCITable didn't initialize its size on `clear()`
 
 ### Security
 

SampleProjects/TestSomething/test/table.cpp

@@ -18,8 +18,7 @@ void setResult3(long l, int k, int v) {
 }
 
 
-unittest(basic_table)
-{
+unittest(basic_table) {
   ArduinoCITable<String, int> t;
   assertTrue(t.empty());
 
@@ -46,6 +45,40 @@ unittest(basic_table)
 
 }
 
+unittest(clear) {
+  ArduinoCITable<String, int> t1;
+  int data[5] = {11, 22, 33, 44, 55};
+
+  for (int i = 0; i < 5; ++i) {
+    t1.add(String(data[i]), data[i]);
+  }
+
+  assertEqual(5, t1.size());
+  t1.clear();
+  assertEqual(0, t1.size());
+}
+
+unittest(copy_construction) {
+  ArduinoCITable<String, int> t1;
+  int data[5] = {11, 22, 33, 44, 55};
+
+  for (int i = 0; i < 5; ++i) {
+    t1.add(String(data[i]), data[i]);
+  }
+
+  ArduinoCITable<String, int> t2 = t1;
+  t1.clear();
+  assertEqual(0, t1.size());
+  assertEqual(5, t2.size());
+
+  for (int i = 0; i < 5; ++i) {
+    assertTrue(t2.has(String(data[i])));
+    assertTrue(t2.remove(String(data[i])));
+    assertFalse(t2.has(String(data[i])));
+  }
+  assertEqual(0, t2.size());
+}
+
 unittest(iteration_no_arg) {
   ArduinoCITable<int, int> t;
   for (int i = 0; i < 5; ++i) {

cpp/arduino/ci/Table.h

@@ -27,6 +27,13 @@ class ArduinoCITable {
   public:
     ArduinoCITable() : mNilK(), mNilV() { init(); }
 
+    ArduinoCITable(const ArduinoCITable& obj) : mNilK(), mNilV() {
+      init();
+      for (Node* p = obj.mStart; p; p = p->next) {
+        add(p->key, p->val);
+      }
+    }
+
     // number of things in the table
     inline unsigned long size() const { return mSize; }
 
@@ -119,6 +126,7 @@ class ArduinoCITable {
         mStart = mStart->next;
         delete p;
       }
+      mSize = 0;
     }
 
     ~ArduinoCITable() { clear(); }