Skip to content

Commit 2d3285a

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Bump Xcode to version 16.2 (facebook#51014)
Summary: Pull Request resolved: facebook#51014 Starting from the [24th of April](https://developer.apple.com/news/upcoming-requirements/?id=02212025a), Apple only accepts app built with Xcode 16.0 or greater This change bumps our CI to ensure that everything works with Xcode 16. ## Changelog: [Internal] - Bump CI to Xcode 16.2 Reviewed By: javache Differential Revision: D73924819 fbshipit-source-id: 82cdca5e12cee505de6e97513c07678776642d88
1 parent 9683287 commit 2d3285a

File tree

9 files changed

+28
-18
lines changed

9 files changed

+28
-18
lines changed

.github/actions/build-hermesc-apple/action.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ inputs:
1010
runs:
1111
using: composite
1212
steps:
13+
- name: Setup xcode
14+
uses: ./.github/actions/setup-xcode
1315
- name: Restore Hermes workspace
1416
uses: ./.github/actions/restore-hermes-workspace
1517
- name: Hermes apple cache

.github/actions/setup-xcode/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ inputs:
44
xcode-version:
55
description: 'The xcode version to use'
66
required: false
7-
default: '15.2'
7+
default: '16.2.0'
88
runs:
99
using: "composite"
1010
steps:

.github/actions/test-ios-helloworld/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ runs:
4343
- name: Run yarn
4444
uses: ./.github/actions/yarn-install
4545
- name: Setup ruby
46-
uses: ruby/setup-ruby@v1.170.0
46+
uses: ruby/setup-ruby@v1
4747
with:
4848
ruby-version: ${{ inputs.ruby-version }}
4949
- name: Download ReactNativeDependencies

.github/actions/test-ios-rntester/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ runs:
4848
name: hermes-darwin-bin-${{ inputs.flavor }}
4949
path: ${{ inputs.hermes-tarball-artifacts-dir }}
5050
- name: Setup ruby
51-
uses: ruby/setup-ruby@v1.170.0
51+
uses: ruby/setup-ruby@v1
5252
with:
5353
ruby-version: ${{ inputs.ruby-version }}
5454
- name: Prepare IOS Tests

.github/actions/test-library-on-nightly/action.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ runs:
2121
cd /tmp/RNApp
2222
yarn add ${{ inputs.library-npm-package }}
2323
24+
# iOS
25+
- name: Setup xcode
26+
if: ${{ inputs.platform == 'ios' }}
27+
uses: ./.github/actions/setup-xcode
2428
- name: Build iOS
2529
shell: bash
2630
if: ${{ inputs.platform == 'ios' }}
@@ -32,6 +36,8 @@ runs:
3236
-workspace RNApp.xcworkspace \
3337
-scheme RNApp \
3438
-sdk iphonesimulator
39+
40+
# Android
3541
- name: Setup Java for Android
3642
if: ${{ inputs.platform == 'android' }}
3743
uses: actions/setup-java@v2

.github/workflows/nightly.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
hermes-version-file: ${{ env.HERMES_VERSION_FILE }}
4141

4242
build_hermesc_apple:
43-
runs-on: macos-13
43+
runs-on: macos-14
4444
needs: prepare_hermes_workspace
4545
env:
4646
HERMES_WS_DIR: /tmp/hermes
@@ -80,7 +80,7 @@ jobs:
8080
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
8181

8282
build_hermes_macos:
83-
runs-on: macos-13
83+
runs-on: macos-14
8484
needs: [build_apple_slices_hermes, prepare_hermes_workspace]
8585
env:
8686
HERMES_WS_DIR: /tmp/hermes

.github/workflows/publish-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
hermes-version-file: ${{ env.HERMES_VERSION_FILE }}
3939

4040
build_hermesc_apple:
41-
runs-on: macos-13
41+
runs-on: macos-14
4242
needs: prepare_hermes_workspace
4343
env:
4444
HERMES_WS_DIR: /tmp/hermes
@@ -77,7 +77,7 @@ jobs:
7777
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
7878

7979
build_hermes_macos:
80-
runs-on: macos-13
80+
runs-on: macos-14
8181
needs: [build_apple_slices_hermes, prepare_hermes_workspace]
8282
env:
8383
HERMES_WS_DIR: /tmp/hermes

.github/workflows/test-all.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
hermes-version-file: ${{ env.HERMES_VERSION_FILE }}
5757

5858
build_hermesc_apple:
59-
runs-on: macos-13
59+
runs-on: macos-14
6060
needs: prepare_hermes_workspace
6161
env:
6262
HERMES_WS_DIR: /tmp/hermes
@@ -96,7 +96,7 @@ jobs:
9696
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
9797

9898
build_hermes_macos:
99-
runs-on: macos-13
99+
runs-on: macos-14
100100
needs: [build_apple_slices_hermes, prepare_hermes_workspace]
101101
env:
102102
HERMES_WS_DIR: /tmp/hermes
@@ -121,7 +121,7 @@ jobs:
121121
secrets: inherit
122122

123123
test_ios_rntester_ruby_3_2_0:
124-
runs-on: macos-13
124+
runs-on: macos-14
125125
needs:
126126
[build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos, prebuild_apple_dependencies]
127127
env:
@@ -138,7 +138,7 @@ jobs:
138138
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
139139

140140
test_ios_rntester_dynamic_frameworks:
141-
runs-on: macos-13
141+
runs-on: macos-14
142142
needs:
143143
[build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos, prebuild_apple_dependencies]
144144
env:
@@ -161,7 +161,7 @@ jobs:
161161
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
162162

163163
test_ios_rntester:
164-
runs-on: macos-13-large
164+
runs-on: macos-14-large
165165
needs:
166166
[build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos, prebuild_apple_dependencies]
167167
env:
@@ -197,7 +197,7 @@ jobs:
197197

198198
test_e2e_ios_rntester:
199199
if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }}
200-
runs-on: macos-13-large
200+
runs-on: macos-14-large
201201
needs:
202202
[test_ios_rntester]
203203
env:
@@ -220,6 +220,8 @@ jobs:
220220
path: /tmp/RNTesterBuild/RNTester.app
221221
- name: Check downloaded folder content
222222
run: ls -lR /tmp/RNTesterBuild
223+
- name: Setup xcode
224+
uses: ./.github/actions/setup-xcode
223225
- name: Run E2E Tests
224226
uses: ./.github/actions/maestro-ios
225227
with:
@@ -231,7 +233,7 @@ jobs:
231233

232234
test_e2e_ios_templateapp:
233235
if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }}
234-
runs-on: macos-13-large
236+
runs-on: macos-14-large
235237
needs: [build_npm_package, prebuild_apple_dependencies]
236238
env:
237239
HERMES_WS_DIR: /tmp/hermes
@@ -253,7 +255,7 @@ jobs:
253255
- name: Run yarn
254256
uses: ./.github/actions/yarn-install
255257
- name: Setup ruby
256-
uses: ruby/setup-ruby@v1.170.0
258+
uses: ruby/setup-ruby@v1
257259
with:
258260
ruby-version: 2.6.10
259261
- name: Download Hermes
@@ -589,7 +591,7 @@ jobs:
589591
compression-level: 0
590592

591593
test_ios_helloworld_with_ruby_3_2_0:
592-
runs-on: macos-13
594+
runs-on: macos-14
593595
needs: [prepare_hermes_workspace, build_hermes_macos, prebuild_apple_dependencies] # prepare_hermes_workspace must be there because we need its reference to retrieve a couple of outputs
594596
env:
595597
PROJECT_NAME: iOSTemplateProject
@@ -607,7 +609,7 @@ jobs:
607609
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
608610

609611
test_ios_helloworld:
610-
runs-on: macos-13
612+
runs-on: macos-14
611613
needs: [prepare_hermes_workspace, build_hermes_macos, prebuild_apple_dependencies] # prepare_hermes_workspace must be there because we need its reference to retrieve a couple of outputs
612614
strategy:
613615
matrix:

.github/workflows/test-libraries-on-nightlies.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runner-setup:
1414
runs-on: ubuntu-latest
1515
outputs:
16-
runners: '{"ios":"macos-13-large", "android": "ubuntu-latest"}'
16+
runners: '{"ios":"macos-14-large", "android": "ubuntu-latest"}'
1717
steps:
1818
- run: echo no-op
1919

0 commit comments

Comments
 (0)